Add timeout param, only tested in demo so far #52
+79
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Obviously this needs an integration test, but I wanted to just get implementation structure now. It is functional, tested with the demo script.
There are some aesthetic changes we could make, like call it "timeout" instead of "cancel"... but obviously timeout uses the same mechanism as cancel. Maybe I'll just rename the exception to
DispatcherInterrupt
or something like that.Also, I'm relatively happy with the structure, although it took some thought. I implemented "delayed" task in the "main" part of the code. It's non-obvious that timeouts will go in the pool part, but the pool can gate on capacity, and timeouts don't start until the worker actually starts running it. And this is definitely something we want enforced in the parent, in general.