Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure on MacOS since cp does not support --parents #246

Closed
ClausHolbechArista opened this issue Dec 1, 2023 · 1 comment · Fixed by #391
Closed

Failure on MacOS since cp does not support --parents #246

ClausHolbechArista opened this issue Dec 1, 2023 · 1 comment · Fixed by #391
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@ClausHolbechArista
Copy link

ClausHolbechArista commented Dec 1, 2023

Hi team
tox-ansible fails on MacOS with an error for cp not supporting --parents.

This line:

copy_cmd = f"cp -r --parents $(git ls-files 2> /dev/null || ls) {galaxy_build_dir}"

contains --parents which is not supported on MacOS. Changing to -p should solve it for all platforms. -p is not doing the same, so on MacOS ppl would have to install GNU cp.

Can you look into other alternatives to make this more portable?

Thanks

@ssbarnea
Copy link
Member

More portable would be to use a pure python approach and avoid using cp or rsync which both have their own portability issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
Status: Done
3 participants