Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where committing in CI doesn't make sense #87

Open
Andy-Grigg opened this issue Jun 14, 2023 · 0 comments
Open

Handle the case where committing in CI doesn't make sense #87

Andy-Grigg opened this issue Jun 14, 2023 · 0 comments

Comments

@Andy-Grigg
Copy link
Collaborator

The 'Generate Client Library' CI workflow expects to always commit the generated code, but there are situations where that doesn't make sense:

  • Dependabot PRs - These generally shouldn't be making any changes to the code
  • Running CI on main - We don't want to push directly to main

For the dependabot PRs, not bumping the version number in this case might be a good option, since then the happy case will be no changes to the code, and the commit won't happen.

For running CI on main, this might just be a check to not commit on main, or potentially if run on main to always create a separate branch and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant