Skip to content

Commit 18a95f5

Browse files
authored
docs: Contributing fix (#578)
1 parent 2550296 commit 18a95f5

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

docs/react/contributing.en-US.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ The core team is monitoring for pull requests. We will review your pull request
5454
3. If you've fixed a bug or added code that should be tested, add tests!
5555
4. Ensure the test suite passes (npm run test). Tip: `npm test -- --watch TestName` is helpful in development.
5656
5. Run `npm test -- -u` to update the [jest snapshots](https://jestjs.io/docs/snapshot-testing) and commit these changes as well (if there are any updates).
57-
6. Ensure the UI change passes `npm run test:image`, Run `npm run test:image -- -u` to update UI snapshots and commit these changes as well (if there are any updates), **UI test base on [Docker](https://docs.docker.com/get-docker/), need download the corresponding installation according to the platform**
58-
7. Make sure your code lints (npm run lint). Tip: Lint runs automatically when you `git commit` (Use [Git Hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)).
59-
8. Finally, please make sure that all GitHub CI checks pass, if they fail, you can click `detail` to enter the details to view the reason.
57+
6. Make sure your code lints (npm run lint). Tip: Lint runs automatically when you `git commit` (Use [Git Hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks)).
58+
7. Finally, please make sure that all GitHub CI checks pass, if they fail, you can click `detail` to enter the details to view the reason.
6059

6160
Sending a Pull Request to [react-component](https://github.com/react-component/):
6261

docs/react/contributing.zh-CN.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,8 @@ Ant Design 团队会关注所有的 pull request,我们会 review 以及合并
5454
3. 如果你修复了一个 bug 或者新增了一个功能,请确保编写了相应的测试,这很重要。
5555
4. 确认所有的测试都通过了 `npm run test`。小贴士:开发过程中可以用 `npm test -- --watch TestName` 来运行指定的测试。
5656
5. 运行 `npm test -- -u` 来更新 [jest snapshot](https://jestjs.io/zh-Hans/docs/snapshot-testing) 并且把这些更新也提交上来(如果有的话)。
57-
6. 确认所有的 UI 改动通过 `npm run test:image`,可以运行 `npm run test:image -- -u` 更新 UI 快照并且把这些更新也提交上来(如果有的话),**UI 测试基于 [Docker](https://docs.docker.com/get-docker/),根据平台下载对应的安装程序。**
58-
7. 确保你的代码通过了 lint 检查 `npm run lint`。小贴士: Lint 会在你 `git commit` 的时候自动运行(通过[Git Hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks))。
59-
8. 最后请确保所有 GitHub CI 检查通过,如果失败,可点击 `detail` 进入详情查看原因。
57+
6. 确保你的代码通过了 lint 检查 `npm run lint`。小贴士: Lint 会在你 `git commit` 的时候自动运行(通过[Git Hooks](https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks))。
58+
7. 最后请确保所有 GitHub CI 检查通过,如果失败,可点击 `detail` 进入详情查看原因。
6059

6160
[react-component](https://github.com/react-component/) 发送 pull request:
6261

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@
7171
"pretest": "npm run version",
7272
"test": "jest --config .jest.js --no-cache --collect-coverage",
7373
"test:dekko": "tsx ./tests/dekko/index.test.ts",
74-
"test:image": "jest --config .jest.image.js --no-cache -i -u --forceExit",
7574
"test:node": "npm run version && jest --config .jest.node.js --no-cache",
7675
"test:package-diff": "antd-tools run package-diff",
7776
"test:site": "jest --config .jest.site.js",

0 commit comments

Comments
 (0)