Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to destroy the adaptor in react native #6399

Closed
vincemavill opened this issue Jun 12, 2024 · 11 comments · Fixed by ant-media/WebRTC-React-Native-SDK#23
Closed

How to destroy the adaptor in react native #6399

vincemavill opened this issue Jun 12, 2024 · 11 comments · Fixed by ant-media/WebRTC-React-Native-SDK#23
Assignees
Labels

Comments

@vincemavill
Copy link

How can i destroy the adaptor Ant media, because the
pong command still showing on the logs and green dot doesn't disappear on the top right corner, even though I trigger the adaptor.stop(stream_id) and navigate back to other screen.

@vincemavill
Copy link
Author

@mustafaboleken hope you can help sir, thank you

@mekya mekya added the support label Jun 24, 2024
@mekya mekya moved this to Next Sprint in Ant Media Server Jun 24, 2024
@mekya
Copy link
Contributor

mekya commented Jun 24, 2024

Hi @vincemavill,
Thank you for raising the issue and your patience. I'm putting this in the backlog. I'll try to schedule this week if we have some bandwidth.

Cheers
Oguz

@mekya mekya moved this from Next Sprint to 🔖 Sprint in Ant Media Server Jun 24, 2024
@vincemavill
Copy link
Author

@mekya any updates with this? thank you

@mustafaboleken
Copy link
Contributor

Hi @vincemavill,

I just got back from the vacation. Preparing the guide, I will share it with you today.

@mustafaboleken
Copy link
Contributor

Hi @vincemavill,

It's ready to test. You can use the published sample. Btw, due to not making a breaking change, I added extra functions to closing the local stream and WebSocket, reinitialing WebSocket, and some extra callbacks. Please let me know if this approach works for you.

ant-media/WebRTC-React-Native-SDK#23

@burak-58 burak-58 moved this from 🏗 In progress to After sprint in Ant Media Server Jul 15, 2024
@Jastc
Copy link

Jastc commented Jul 16, 2024

Hi @mustafaboleken, I happened to have the same issue with the adaptor and the changes fixes it!

I only have one small issue; When you stop the stream and want start the stream again, you have to call the function/callback which calls adaptor.publish(streamNameRef.current) (in case of the example code the handlePublish) twice, instead of the expected single press, in order to stream again..

Is there a way around this or is an additional adjustment needed in order to fix this?

@mustafaboleken
Copy link
Contributor

Hi @Jastc

Let me update the sample. So, you don't need to double-click on it.

@burak-58 burak-58 moved this from After sprint to 🏗 In progress in Ant Media Server Jul 23, 2024
@mustafaboleken
Copy link
Contributor

I updated the sample. You can check it again.

@burak-58 burak-58 moved this from 🏗 In progress to After sprint in Ant Media Server Jul 29, 2024
@Jastc
Copy link

Jastc commented Aug 12, 2024

Hi @mustafaboleken, I'm not sure if you get a notification of it or not, but I added some comments to the changes you've made in the example code -> ant-media/WebRTC-React-Native-SDK#23

@mekya mekya moved this from After sprint to 🏗 In progress in Ant Media Server Aug 12, 2024
@mekya
Copy link
Contributor

mekya commented Aug 12, 2024

I've moved it to "In Progress" again to follow up closely in the sprint meeting.

Thank you @Jastc

@mustafaboleken
Copy link
Contributor

Hi @Jastc

For some reason I missed the notification, thanks for remind from here, I will check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants