Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCenter shutdown - do you plan to move the latest version to another repository? #96

Open
natario1 opened this issue Mar 1, 2021 · 20 comments

Comments

@natario1
Copy link

natario1 commented Mar 1, 2021

Hi @mekya , I know that you said that you don't maintain this library anymore and we don't expect new versions. But given that jcenter is shutting down, I was wondering if you plan to migrate at least v3.1.0 to some other repository manager like maven central, so that it can still be consumed by everyone?

As far as I can see, the lib is currently jcenter only, please correct me if I'm wrong. And many apps and libraries depend on LibRtmp, e.g. ExoPlayer RTMP module. So we'd appreciate this a lot. Thanks!

@mekya
Copy link
Contributor

mekya commented Mar 1, 2021

Hi @natario1 ,
Yeah likely we can migrate to maven central.

What's the timeline for jcenter?

@natario1
Copy link
Author

natario1 commented Mar 1, 2021

AFAIU by the end of march 2021, publishing is blocked, but they'll still serve packages until 1st of February 2022. I might read this wrong though. https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

@mekya
Copy link
Contributor

mekya commented Mar 4, 2021

I see. Thank you.
I think we definitely add the lib to the maven repo or somewhere.

@natario1
Copy link
Author

natario1 commented Mar 4, 2021

Great! Thank you.

@ojw28
Copy link

ojw28 commented Aug 9, 2021

@mekya - Is there any update on this? I would expect the warnings in Android Studio to be progressively more prominent the closer toward the deadline we get.

@mekya
Copy link
Contributor

mekya commented Aug 10, 2021

Hi @ojw28 ,

Recently, I'm using this project in another product. I've found a bug in this code in NAL unit parsing.

I am trying to fix it in this week and I can send the project to the maven central after that.

@mekya
Copy link
Contributor

mekya commented Aug 13, 2021

Hi Guys,

There is SNAPSHOT version available sonatype. Can you check if it is working for you?
https://oss.sonatype.org/#nexus-search;gav~io.antmedia~rtmp-client~~~~kw,versionexpand

implementation 'io.antmedia:rtmp-client:3.2.0-SNAPSHOT

And add snapshot repo to your repositories

maven {
   url "https://oss.sonatype.org/content/repositories/snapshots"
}

@ojw28
Copy link

ojw28 commented Aug 16, 2021

@mekya - Is this just a step toward the goal of providing a versioned release somewhere, or is this intended to be a replacement for distribution via jcenter? I think we're really looking for a versioned release (i.e., the ability to depend on a specific version, and expect that the binary wont change unless we change the version that we're depending on). Thanks!

@mekya
Copy link
Contributor

mekya commented Aug 16, 2021

Hi @ojw28 ,

This is just a step toward the goad of providing a versioned release somewhere. If it seems ok for you, I can create a versioned release(not snapshot) that binary won't change to the maven central.

@ojw28
Copy link

ojw28 commented Aug 17, 2021

Thanks for the clarification. I'd be happy to test this given a media RTMP link that's accessible over the internet. Unfortunately I've not been able to find a working one. Do you know of one that I could use for testing?

@mekya
Copy link
Contributor

mekya commented Aug 17, 2021

Hi @ojw28 ,

I think you may try this one :)

rtmp://wowzaec2demo.streamlock.net/vod/mp4:BigBuckBunny_115k.mov

PS: TBH, I've not find an opportunity to test it in the Exoplayer. So I'm wondering if it works for you.

@ojw28
Copy link

ojw28 commented Aug 17, 2021

I gave the snapshot a try with ExoPlayer, and it appears to work correctly.

@mekya
Copy link
Contributor

mekya commented Aug 17, 2021

Good to know. I can publish as a versioned release(3.2.0) whenever you're ok.

Btw, what do you think adding WebRTC playback(a kind of experimental extension) to the ExoPlayer for real time playback? I think we can make this development.

@ojw28
Copy link

ojw28 commented Aug 17, 2021

Good to know. I can publish as a versioned release(3.2.0) whenever you're ok.

That would be great. Please let us know where we can get it, when available.

Btw, what do you think adding WebRTC playback(a kind of experimental extension) to the ExoPlayer for real time playback? I think we can make this development.

This isn't on our roadmap for the near future, but we'd consider a high quality pull request adding support.

@mekya
Copy link
Contributor

mekya commented Aug 17, 2021

That would be great. Please let us know where we can get it, when available.

Ok. I can send it in my convenient time.

This isn't on our roadmap for the near future, but we'd consider a high quality pull request adding support.

What makes a PR high quality for you? Do you have development guidelines?

@ojw28
Copy link

ojw28 commented Sep 7, 2021

@mekya - Do you have an ETA on when there will be a versioned release? Thanks!

@mekya
Copy link
Contributor

mekya commented Sep 8, 2021

I think I can push to the repo in a couple of days If you don't have any feedback.

@ojw28
Copy link

ojw28 commented Sep 8, 2021

We don't have any feedback other than it appears to work correctly, as noted above. Thanks!

@ojw28
Copy link

ojw28 commented Oct 6, 2021

@mekya - Any update on this? Thanks!

@mekya
Copy link
Contributor

mekya commented Oct 21, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants