Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong urls #3

Open
cmoulliard opened this issue Mar 18, 2014 · 3 comments
Open

Wrong urls #3

cmoulliard opened this issue Mar 18, 2014 · 3 comments

Comments

@cmoulliard
Copy link

The following urls defined in the demo.js file are wrong

var urlImages = 'https://raw2.github.com/asciidoctor/asciidoctor.js/master/examples/';
var urlLink = 'https://github.com/Nikku/asciidoc-samples/blob/master/';

Should be

var urlImages = 'https://raw.github.com/asciidoctor/asciidoctor.js/master/examples/';
var urlLink = 'https://github.com/opendevise/asciidoc-samples';
@anthonny
Copy link
Owner

Ok, i'll change that :)

But i think urlLink should be :
var urlLink = 'https://github.com/opendevise/asciidoc-samples/blob/master/';

@cmoulliard
Copy link
Author

Then you will get a Page not found - https://github.com/opendevise/asciidoc-samples/blob/master/
To be tested.

It could be more interesting that we let the user to specify the gitproject or location of the images - What do you think ?

I'm also playing a little bit with ace and ace-ui (https://github.com/cmoulliard/asciidoc-ace-editor) and experiment additional features (select theme, change font size, select a different Asciidoc style, .... Thx for your hard work.

@anthonny
Copy link
Owner

anthonny commented Jun 1, 2014

I just updated the example.
I included tiger.png and include.adoc in the examples directory

I'm agree with you, it's more interesting to let user to specify url's.
If it's ok for you, we can close it ;)

Sorry for this late answer, and thank you for the note in your project, very affected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants