Skip to content

fix(ui): initialize state selectively to prevent background task conflicts #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tusharmath merged 3 commits into from
Apr 1, 2026
+5 −2
Merged

fix(ui): initialize state selectively to prevent background task conflicts #2773

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46fa49a
fix(ui): initialize state selectively to prevent background task conf…
tusharmath Apr 1, 2026
954db0b
Merge branch 'main' into join-handle-fix
tusharmath Apr 1, 2026
79fe89a
Merge branch 'main' into join-handle-fix
tusharmath Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions crates/forge_main/src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,11 @@ impl<A: API + ConsoleWriter + 'static, F: Fn() -> A + Send + Sync> UI<A, F> {
}
},
TopLevelCommand::Info { porcelain, conversation_id } => {
// Make sure to init model
self.on_new().await?;
// Only initialize state (agent/provider/model resolution).
// Avoid on_new() which also spawns fire-and-forget background
// tasks via hydrate_caches() that race with process exit and
// cause "JoinHandle polled after completion" panics.
self.init_state(false).await?;

self.on_info(porcelain, conversation_id).await?;
return Ok(());
Expand Down
Loading