Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of ANTLR4 grammars #23

Open
matthiasbalke opened this issue Dec 28, 2018 · 5 comments
Open

Formatting of ANTLR4 grammars #23

matthiasbalke opened this issue Dec 28, 2018 · 5 comments

Comments

@matthiasbalke
Copy link
Contributor

As soon as diffplug/spotless#328 is merged, we should eat our own dogfood and format our ANTLR4 grammars using spotless, which in turns uses Antlr4Formatter.

matthiasbalke added a commit to matthiasbalke/Antlr4Formatter that referenced this issue Dec 28, 2018
@matthiasbalke
Copy link
Contributor Author

I've added the config in my commit. But the spotless PR must be merged and released first.

@teverett
Copy link
Member

I like the idea, but this is a big decision: there are many contributors to grammars-v4. Lets leave this open for now.

@matthiasbalke
Copy link
Contributor Author

Oh I ment to start with the ANTLR4 grammars we are using in the formatter. If we are comfortable with the formatting, we can go one step further.

@teverett
Copy link
Member

teverett commented Dec 28, 2018 via email

@matthiasbalke
Copy link
Contributor Author

This issue was closed by #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants