[golang] Fix go_parser_base table update #4626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the package name aliased, table should register aliased name. But previous code registers aliased name on debug condition. Other language base parser implementation registers aliased names. Only golang had this bug. Fix debug condition. Signed-off-by: JaeSang Yoo <[email protected]>
|
The CI failure seems unrelated to this PR. Since the JS base parser seems incomplete, maybe those tests should be skipped until it’s properly implemented. Up to you, but my suggestion would be to exclude the incomplete parser from CI. |
|
The problem is that the changes for the target were never completed. So, JavaScript should not be in the desc.xml file. Please remove it and the extra semicolon. In other words, the target does not work for the grammar. |
The JavaScript target was incomplete and should not be listed in desc.xml. This avoids CI failures caused by the incomplete parser.
|
@teverett could you re-approve workflow for this PR? It changed test targets to skip failing jobs. |
|
@JSYoo5B thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the package name aliased, table should register aliased name.
But previous code registers aliased name on debug condition.
Other language base parser implementation registers aliased names.
Only golang had this bug. Fix debug condition.