injectLocalDetails changes (#100)

* injectLocalDetails changes

* add err check

* fix sb.injectLocalDetails on StateRebuild

* fix test

Author: requilence

cmd/grpcserver/grpc.go

@@ -4,23 +4,20 @@
 package main
 
 import (
-	"bytes"
-	"compress/gzip"
 	"context"
-	"encoding/base64"
 	"fmt"
 	"net"
 	"net/http"
 	//nolint: gosec
 	_ "net/http/pprof"
 	"os"
 	"os/signal"
-	"runtime"
 	"strconv"
 	"syscall"
 	"time"
 
 	"github.com/anyproto/any-sync/app"
+	"github.com/anyproto/anytype-heart/util/debug"
 	grpc_middleware "github.com/grpc-ecosystem/go-grpc-middleware"
 	grpc_zap "github.com/grpc-ecosystem/go-grpc-middleware/logging/zap"
 	grpc_prometheus "github.com/grpc-ecosystem/go-grpc-prometheus"
@@ -125,7 +122,7 @@ func main() {
 				select {
 				case <-doneCh:
 				case <-time.After(defaultUnaryWarningAfter):
-					log.With("method", info.FullMethod).With("in_progress", true).With("goroutines", base64GzippedStack()).With("total", defaultUnaryWarningAfter.Milliseconds()).Warnf("grpc unary request is taking too long")
+					log.With("method", info.FullMethod).With("in_progress", true).With("goroutines", debug.StackCompact(true)).With("total", defaultUnaryWarningAfter.Milliseconds()).Warnf("grpc unary request is taking too long")
 				}
 			}()
 			resp, err = handler(ctx, req)
@@ -294,23 +291,3 @@ func onNotLoggedInError(resp interface{}, rerr error) interface{} {
 	}
 	return resp
 }
-
-func stackAllGoroutines() []byte {
-	buf := make([]byte, 1024)
-	for {
-		n := runtime.Stack(buf, true)
-		if n < len(buf) {
-			return buf[:n]
-		}
-		buf = make([]byte, 2*len(buf))
-	}
-}
-
-func base64GzippedStack() string {
-	var buf bytes.Buffer
-	gz := gzip.NewWriter(&buf)
-	_, _ = gz.Write(stackAllGoroutines())
-	_ = gz.Close()
-
-	return base64.StdEncoding.EncodeToString(buf.Bytes())
-}

core/block/editor/smartblock/smartblock.go

@@ -892,6 +892,15 @@ func (sb *smartBlock) injectLinksDetails(s *state.State) {
 }
 
 func (sb *smartBlock) injectLocalDetails(s *state.State) error {
+	if pbtypes.GetString(s.LocalDetails(), bundle.RelationKeyWorkspaceId.String()) == "" {
+		wsId, err := sb.coreService.GetWorkspaceIdForObject(sb.Id())
+		if wsId != "" {
+			s.SetDetailAndBundledRelation(bundle.RelationKeyWorkspaceId, pbtypes.String(wsId))
+		} else {
+			log.With("objectID", sb.Id()).Errorf("injectLocalDetails empty workspace: %v", err)
+		}
+	}
+
 	if sb.objectStore == nil {
 		return nil
 	}
@@ -943,15 +952,11 @@ func (sb *smartBlock) injectLocalDetails(s *state.State) error {
 			s.SetDetailAndBundledRelation(bundle.RelationKeyCreator, pbtypes.String(creator))
 		}
 
-		s.SetDetailAndBundledRelation(bundle.RelationKeyCreatedDate, pbtypes.Float64(float64(createdDate)))
-	}
-
-	if pbtypes.GetString(s.LocalDetails(), bundle.RelationKeyWorkspaceId.String()) == "" {
-		wsId, _ := sb.coreService.GetWorkspaceIdForObject(sb.Id())
-		if wsId != "" {
-			s.SetDetailAndBundledRelation(bundle.RelationKeyWorkspaceId, pbtypes.String(wsId))
+		if createdDate != 0 {
+			s.SetDetailAndBundledRelation(bundle.RelationKeyCreatedDate, pbtypes.Float64(float64(createdDate)))
 		}
 	}
+
 	return nil
 }
 
@@ -1022,6 +1027,10 @@ func (sb *smartBlock) StateRebuild(d state.Doc) (err error) {
 		return ErrIsDeleted
 	}
 	d.(*state.State).InjectDerivedDetails()
+	err = sb.injectLocalDetails(d.(*state.State))
+	if err != nil {
+		log.Errorf("failed to inject local details in StateRebuild: %v", err)
+	}
 	d.(*state.State).SetParent(sb.Doc.(*state.State))
 	// todo: make store diff
 	sb.execHooks(HookBeforeApply, ApplyInfo{State: d.(*state.State)})

core/block/editor/smartblock/smartblock_test.go

@@ -105,6 +105,7 @@ func newFixture(t *testing.T) *fixture {
 
 	coreService := testMock.NewMockService(ctrl)
 	coreService.EXPECT().ProfileID().Return("").AnyTimes()
+	coreService.EXPECT().GetWorkspaceIdForObject(gomock.Any()).AnyTimes()
 
 	source := mockSource.NewMockSource(ctrl)
 	source.EXPECT().Type().AnyTimes().Return(model.SmartBlockType_Page)

core/block/source/anytypeprofile.go

@@ -86,3 +86,7 @@ func (s *anytypeProfile) GetFileKeysSnapshot() []*pb.ChangeFileKeys {
 func (s *anytypeProfile) PushChange(params PushChangeParams) (id string, err error) {
 	return
 }
+
+func (s *anytypeProfile) GetCreationInfo() (creator string, createdDate int64, err error) {
+	return addr.AnytypeProfileId, 0, nil
+}

core/block/source/bundledobjecttype.go

@@ -3,6 +3,7 @@ package source
 import (
 	"context"
 
+	"github.com/anyproto/anytype-heart/pkg/lib/localstore/addr"
 	"github.com/gogo/protobuf/types"
 
 	"github.com/anyproto/anytype-heart/core/block/editor/state"
@@ -90,3 +91,7 @@ func (v *bundledObjectType) Heads() []string {
 func (s *bundledObjectType) GetFileKeysSnapshot() []*pb.ChangeFileKeys {
 	return nil
 }
+
+func (s *bundledObjectType) GetCreationInfo() (creator string, createdDate int64, err error) {
+	return addr.AnytypeProfileId, 0, nil
+}

core/block/source/bundledrelation.go

@@ -97,3 +97,7 @@ func (v *bundledRelation) Heads() []string {
 func (s *bundledRelation) GetFileKeysSnapshot() []*pb.ChangeFileKeys {
 	return nil
 }
+
+func (s *bundledRelation) GetCreationInfo() (creator string, createdDate int64, err error) {
+	return addr.AnytypeProfileId, 0, nil
+}

core/block/source/date.go

@@ -114,3 +114,7 @@ func (v *date) Heads() []string {
 func (s *date) GetFileKeysSnapshot() []*pb.ChangeFileKeys {
 	return nil
 }
+
+func (s *date) GetCreationInfo() (creator string, createdDate int64, err error) {
+	return s.coreService.ProfileID(), 0, nil
+}

pkg/lib/localstore/objectstore/update.go

@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 
+	"github.com/anyproto/anytype-heart/util/debug"
 	"github.com/dgraph-io/badger/v3"
 	"github.com/gogo/protobuf/proto"
 	"github.com/gogo/protobuf/types"
@@ -212,6 +213,10 @@ func (s *dsObjectStore) updateDetails(txn noctxds.Txn, id string, oldDetails *mo
 		return err
 	}
 
+	if pbtypes.GetString(newDetails.Details, bundle.RelationKeyWorkspaceId.String()) == "" {
+		log.With("objectID", id).With("stack", debug.StackCompact(false)).Warnf("workspaceId erased")
+	}
+	
 	if oldDetails.GetDetails().Equal(newDetails.GetDetails()) {
 		return ErrDetailsNotChanged
 	}

util/debug/debug.go

@@ -0,0 +1,29 @@
+package debug
+
+import (
+	"bytes"
+	"compress/gzip"
+	"encoding/base64"
+	"runtime"
+)
+
+func Stack(allGoroutines bool) []byte {
+	buf := make([]byte, 1024)
+	for {
+		n := runtime.Stack(buf, allGoroutines)
+		if n < len(buf) {
+			return buf[:n]
+		}
+		buf = make([]byte, 2*len(buf))
+	}
+}
+
+// StackCompact returns base64 of gzipped stack
+func StackCompact(allGoroutines bool) string {
+	var buf bytes.Buffer
+	gz := gzip.NewWriter(&buf)
+	_, _ = gz.Write(Stack(allGoroutines))
+	_ = gz.Close()
+
+	return base64.StdEncoding.EncodeToString(buf.Bytes())
+}