Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get deep links working #18

Open
loliver opened this issue Aug 16, 2018 · 2 comments
Open

Get deep links working #18

loliver opened this issue Aug 16, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@loliver
Copy link
Member

loliver commented Aug 16, 2018

Describe the bug
GitHub pages doesn't like deep links within SPAs.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://anz-bank.github.io/anz-codebreakers/easy
  2. You will see a 404

Expected behavior
The easy game should load

Resources
https://github.com/rafrex/spa-github-pages

@loliver loliver added the bug Something isn't working label Aug 16, 2018
@loliver loliver added this to the Better code milestone Aug 16, 2018
@loliver loliver self-assigned this Aug 16, 2018
@juliaogris
Copy link

Shot in the blue, cause I came across something similar recently: %PUBLIC_URL%, homepage https://stackoverflow.com/questions/42686149/create-react-app-build-with-public-url

@loliver
Copy link
Member Author

loliver commented Aug 16, 2018

Oops, I forgot to actually link the library I saw that apparently hacks around this issue by forwarding 404's back to home and then using the router to go back to the requested route immediately.

https://github.com/rafrex/spa-github-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants