Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate_fee - test-only argument #3204

Open
apfitzge opened this issue Oct 17, 2024 · 1 comment · Fixed by #3211 · May be fixed by #4394
Open

calculate_fee - test-only argument #3204

apfitzge opened this issue Oct 17, 2024 · 1 comment · Fixed by #3211 · May be fixed by #4394
Assignees
@apfitzge

Comments

@apfitzge
Copy link

Problem

Proposed Solution

  • Remove this argument fix any tests that break due to fees being unexpectedly charged
@apfitzge apfitzge self-assigned this Oct 17, 2024
@apfitzge apfitzge mentioned this issue Oct 17, 2024
Merged
@apfitzge
Copy link
Author

apfitzge commented Nov 4, 2024

PR got reverted because testnet has args that were zeroing fees with the appraoch in #3211.
Need to manually adjust tests & local cluster's to either explicity set 0 fees, or handle fees being non-zero, in a different way that does not affect testnet (or any other cluster)

@apfitzge apfitzge reopened this Nov 4, 2024
@apfitzge apfitzge linked a pull request Jan 10, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apfitzge apfitzge

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@apfitzge