Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister listener in useStandardWalletAdapters doing the opposite filtering #44

Open
alex-fung opened this issue Mar 20, 2024 · 1 comment

Comments

@alex-fung
Copy link

When unregistering a wallet, it seems to remove all wallets except for the one I tried to unregister in useStandardWalletAdapters. I think the filter is filtering for only the wallet I'm trying to unregister instead filtering for all the wallets but the one I'm trying to unregister.

In particular at

wallets.some((wallet) => wallet === standardAdapter.wallet)

should it be wallets.some((wallet) => wallet !== standardAdapter.wallet)?

(Aware that this isn't supposed to be used by dApps necessarily, but wanted to use it for some in-team testing purposes)

@alex-fung
Copy link
Author

cc @jordaaash

@alex-fung alex-fung changed the title Unregister listener in useStandardWalletAdapters bug? Unregister listener in useStandardWalletAdapters doing the opposite filtering Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant