From 103b3ab48cafcd63cd2da408b5688d53a38643bb Mon Sep 17 00:00:00 2001 From: GPK Date: Fri, 3 Jan 2025 22:09:40 +0000 Subject: [PATCH] Fix missing input variables and output variable references in github workflows (#45384) --- .github/actions/prepare_all_ci_images/action.yml | 4 ---- .github/workflows/ci-image-build.yml | 2 +- .github/workflows/ci.yml | 2 ++ .github/workflows/finalize-tests.yml | 4 ++++ .github/workflows/k8s-tests.yml | 2 ++ .github/workflows/special-tests.yml | 1 + .github/workflows/task-sdk-tests.yml | 5 +++++ .github/workflows/test-provider-packages.yml | 1 + 8 files changed, 16 insertions(+), 5 deletions(-) diff --git a/.github/actions/prepare_all_ci_images/action.yml b/.github/actions/prepare_all_ci_images/action.yml index f815c27228928..d156818b9b283 100644 --- a/.github/actions/prepare_all_ci_images/action.yml +++ b/.github/actions/prepare_all_ci_images/action.yml @@ -25,10 +25,6 @@ inputs: platform: description: 'Platform for the build - linux/amd64 or linux/arm64' required: true -outputs: - host-python-version: - description: Python version used in host - value: ${{ steps.breeze.outputs.host-python-version }} runs: using: "composite" steps: diff --git a/.github/workflows/ci-image-build.yml b/.github/workflows/ci-image-build.yml index fb44503be0502..83710d4bc7bb1 100644 --- a/.github/workflows/ci-image-build.yml +++ b/.github/workflows/ci-image-build.yml @@ -133,7 +133,7 @@ jobs: uses: ./.github/actions/breeze with: use-uv: ${{ inputs.use-uv }} - - name: "Restore ${{ inputs.image-type }} cache mount image ${{ inputs.platform }}:${{ inputs.python }}" + - name: "Restore ci-cache mount image ${{ inputs.platform }}:${{ env.PYTHON_MAJOR_MINOR_VERSION }}" uses: apache/infrastructure-actions/stash/restore@c94b890bbedc2fc61466d28e6bd9966bc6c6643c with: key: "ci-cache-mount-save-v2-${{ inputs.platform }}-${{ env.PYTHON_MAJOR_MINOR_VERSION }}" diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d68376749796e..1cc97067fd47e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -610,6 +610,7 @@ jobs: python-versions: ${{ needs.build-info.outputs.python-versions }} run-task-sdk-tests: ${{ needs.build-info.outputs.run-task-sdk-tests }} use-uv: ${{ needs.build-info.outputs.use-uv }} + canary-run: ${{ needs.build-info.outputs.canary-run }} if: > ( needs.build-info.outputs.run-task-sdk-tests == 'true' || needs.build-info.outputs.run-tests == 'true' && @@ -646,6 +647,7 @@ jobs: disable-airflow-repo-cache: ${{ needs.build-info.outputs.disable-airflow-repo-cache }} canary-run: ${{ needs.build-info.outputs.canary-run }} use-uv: ${{ needs.build-info.outputs.use-uv }} + debug-resources: ${{ needs.build-info.outputs.debug-resources }} notify-slack-failure: name: "Notify Slack on Failure" diff --git a/.github/workflows/finalize-tests.yml b/.github/workflows/finalize-tests.yml index 5116eb9c2bff0..1d0ac8a600c1d 100644 --- a/.github/workflows/finalize-tests.yml +++ b/.github/workflows/finalize-tests.yml @@ -72,6 +72,10 @@ on: # yamllint disable-line rule:truthy description: "Whether to use uv to build the image (true/false)" required: true type: string + debug-resources: + description: "Whether to debug resources or not (true/false)" + required: true + type: string jobs: update-constraints: runs-on: ${{ fromJSON(inputs.runs-on-as-json-public) }} diff --git a/.github/workflows/k8s-tests.yml b/.github/workflows/k8s-tests.yml index ca7519a5f36fd..9333d1a0d8dab 100644 --- a/.github/workflows/k8s-tests.yml +++ b/.github/workflows/k8s-tests.yml @@ -79,6 +79,8 @@ jobs: uses: actions/checkout@v4 with: persist-credentials: false + # env.PYTHON_MAJOR_MINOR_VERSION, env.KUBERNETES_VERSION are set in the previous + # step id: prepare-versions - name: "Prepare breeze & PROD image: ${{ env.PYTHON_MAJOR_MINOR_VERSION }}" uses: ./.github/actions/prepare_breeze_and_image with: diff --git a/.github/workflows/special-tests.yml b/.github/workflows/special-tests.yml index cca54524b7dca..36ccbf871cca9 100644 --- a/.github/workflows/special-tests.yml +++ b/.github/workflows/special-tests.yml @@ -205,6 +205,7 @@ jobs: use-uv: ${{ inputs.use-uv }} if: ${{ inputs.default-branch == 'main' }} + # matrix.test-group comes from run-unit-tests.yml tests-system: name: "System test: ${{ matrix.test-group }}" uses: ./.github/workflows/run-unit-tests.yml diff --git a/.github/workflows/task-sdk-tests.yml b/.github/workflows/task-sdk-tests.yml index 61b9ba75b5bee..4c6be2acb444a 100644 --- a/.github/workflows/task-sdk-tests.yml +++ b/.github/workflows/task-sdk-tests.yml @@ -40,6 +40,11 @@ on: # yamllint disable-line rule:truthy description: "Whether to use uv to build the image (true/false)" required: true type: string + canary-run: + description: "Whether this is a canary run (true/false)" + required: true + type: string + jobs: task-sdk-tests: timeout-minutes: 80 diff --git a/.github/workflows/test-provider-packages.yml b/.github/workflows/test-provider-packages.yml index 3d79c6896b8aa..9543444f3ade5 100644 --- a/.github/workflows/test-provider-packages.yml +++ b/.github/workflows/test-provider-packages.yml @@ -149,6 +149,7 @@ jobs: --run-in-parallel if: matrix.package-format == 'sdist' + # All matrix parameters are passed as JSON string in the input variable providers-compatibility-tests-matrix providers-compatibility-tests-matrix: timeout-minutes: 80 name: Compat ${{ matrix.airflow-version }}:P${{ matrix.python-version }} providers test