Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Integrate the log records of debug, info, and error into one file #2955

Closed
2 of 3 tasks
xleoken opened this issue Jun 21, 2024 · 3 comments
Closed
2 of 3 tasks

Comments

@xleoken
Copy link
Member

xleoken commented Jun 21, 2024

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

It is not a good practice to record the log records of debug, info, and error separately in different files, and there is a contextual linking relationship between them.

[dcadmin@dcadmin-work logs]$  ll
total 179988
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 amoro-metrics.log
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 ams-debug.log
-rw-rw-r-- 1 dcadmin dcadmin  35377462 Jun 21 17:51 ams-error.log
-rw-rw-r-- 1 dcadmin dcadmin 148887752 Jun 21 17:51 ams-info.log
-rw-rw-r-- 1 dcadmin dcadmin         0 Jun 21 16:31 app.log.err
-rw-rw-r-- 1 dcadmin dcadmin     25485 Jun 21 17:51 gc.log.0.current

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@daragu
Copy link
Contributor

daragu commented Jun 25, 2024

i can take this :)

@zhoujinsong
Copy link
Contributor

As far as I know, the ams-info.log file now also includes warning and error logs. Similarly, the ams-debug.log file contains all logs(disable by default).

@xleoken
Copy link
Member Author

xleoken commented Jun 26, 2024

@daragu thanks for taking this, but we are still discussing this issue.

@xleoken xleoken closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants