Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: need call cancelRenew when release a Renewableblocker #3410

Open
3 tasks done
Aireed opened this issue Jan 20, 2025 · 0 comments · May be fixed by #3421
Open
3 tasks done

[Improvement]: need call cancelRenew when release a Renewableblocker #3410

Aireed opened this issue Jan 20, 2025 · 0 comments · May be fixed by #3421
Assignees

Comments

@Aireed
Copy link
Contributor

Aireed commented Jan 20, 2025

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When we execute a simple Spark insert SQL, the AMS side reported this error.

Image

2025-01-20 18:01:40,998 ERROR [thrift-server-table-metastore-11] [org.apache.amoro.server.TableManagementService] [] - Thrift service:TableManagementService.renewBlocker execute failed
org.apache.amoro.server.exception.ObjectNotExistsException: Blocker 181 of hive_catalog.amoro_v7.block_test(tableId=874643) not exists
        at org.apache.amoro.server.table.TableRuntime.renew(TableRuntime.java:621) ~[amoro-ams-server-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at org.apache.amoro.server.table.DefaultTableService.renewBlocker(DefaultTableService.java:278) ~[amoro-ams-server-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at org.apache.amoro.server.TableManagementService.renewBlocker(TableManagementService.java:153) ~[amoro-ams-server-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_152]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_152]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_152]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_152]
        at org.apache.amoro.server.utils.ThriftServiceProxy.invoke(ThriftServiceProxy.java:56) [amoro-ams-server-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at com.sun.proxy.$Proxy47.renewBlocker(Unknown Source) [?:?]
        at org.apache.amoro.api.AmoroTableMetastore$Processor$renewBlocker.getResult(AmoroTableMetastore.java:1635) [amoro-core-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at org.apache.amoro.api.AmoroTableMetastore$Processor$renewBlocker.getResult(AmoroTableMetastore.java:1611) [amoro-core-0.7.0.1-SNAPSHOT.jar:0.7.0.1-SNAPSHOT]
        at org.apache.amoro.shade.thrift.org.apache.thrift.ProcessFunction.process(ProcessFunction.java:40) [amoro-shade-thrift-0.20.0-0.7-SNAPSHOT.jar:0.20.0-0.7-SNAPSHOT]
        at org.apache.amoro.shade.thrift.org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:40) [amoro-shade-thrift-0.20.0-0.7-SNAPSHOT.jar:0.20.0-0.7-SNAPSHOT]
        at org.apache.amoro.shade.thrift.org.apache.thrift.TMultiplexedProcessor.process(TMultiplexedProcessor.java:147) [amoro-shade-thrift-0.20.0-0.7-SNAPSHOT.jar:0.20.0-0.7-SNAPSHOT]
        at org.apache.amoro.shade.thrift.org.apache.thrift.server.AbstractNonblockingServer$FrameBuffer.invoke(AbstractNonblockingServer.java:492) [amoro-shade-thrift-0.20.0-0.7-SNAPSHOT.jar:0.20.0-0.7-SNAPSHOT]
        at org.apache.amoro.shade.thrift.org.apache.thrift.server.Invocation.run(Invocation.java:19) [amoro-shade-thrift-0.20.0-0.7-SNAPSHOT.jar:0.20.0-0.7-SNAPSHOT]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_152]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_152]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_152]

How should we improve?

when we release the Renewableblocker, we should check whether we need to cancelRenew

Image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@Aireed Aireed self-assigned this Jan 20, 2025
@Aireed Aireed linked a pull request Jan 23, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant