-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal]: refactor link checker #1055
Comments
@navendu-pottekkat The checker will check for links in other repositories. (Although it was not written by me) But the question you ask is actually very complicated. When you add links to our other repositories like in one of the articles, you need to determine the format of the links you use:
The first type will undoubtedly be treated as an internal file, and the checker will check if the file exists. The second type will be treated as an external link and checked for existence by means of a ping. (This can cause problems and should be avoided if the article being cited is new) (The actual processing is a bit more complicated, and I don't fully understand how the current link checker works.)
Maybe I expressed it wrong, what I wanted to say is that we can check on the website repository, but still need to modify the failed links in other repositories than the website repository. |
Got it. If the checker reports a broken link in the website repo, and if the broken link is in a file from another repo, we have to fix the link in the other repo.
Which type of linking do you suggest we follow? Should we follow one type/format of linking? |
@navendu-pottekkat
The relative paths, which are officially recommended by docusaurus.
Yes, we should. But we may need to test further to determine if it works as we expect. |
I'm having some problems and may need to delay until May 15th. |
This issue is used to summarize the previous issues and to propose a plan.
Background
From the response of the community in recent times there is a great need for a link checker that works well enough. (But we do have one, not none 🙃):
However, the current link checker has encountered a number of problems, you can see some in #1050.
But I had difficulty maintaining the original link checker due to obscure regular expressions and the lack of comments. And after trying some existing link checkers, I found that they all lacked maintenance or had more or less problems, so I decided to build a new link checker to meet the needs of this repository.
Scheme
The new link checker will be based on remarkjs and will try to provide clearer and easier to use report files.
It is still in the early stages, still exploring better ways to implement, so no PR has been submitted yet.
Time Period
5.25 - 5.15
Other
If you have any suggestions or questions, please reply here
The text was updated successfully, but these errors were encountered: