-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Usability: Apisix versions are easy mistaken #1469
Comments
We are preparing to modify this part. I have had no time recently, but I will help to modify this part as soon as possible. @juzhiyuan @guoqqqi Maybe you have time to help improve this? |
No, there have a lot of TODOs... Just added good first issue |
I would like to work on this issue |
@RajVarsani 😸 Great! If there are any problems, please feel free to @ any of us. (Hope you won't be dissuaded by the old ugly code. 🥲) |
Sure |
@SkyeYoung Can we use the same versions for sub components? |
@anhldbk Could you please give me an example? I'm not sure if I'm thinking what you're talking about. 🤔 |
@SkyeYoung AFAIK Apisix comprises of various sub components with differrent versions in releases. Multiple versions lead to this issue and other compatibility issues like this one. My question is: can we use the same version for each component? Vertx uses this approach. |
@SkyeYoung, I set up the codebase in my locally. I have encountered a couple of issues. I'm using this command: |
For the end-of-line symbol problem, I think you can fix it by clicking For the question about hot reloading, it's not really supposed to have this problem ... I need to try it out. But I don't use Windows directly for any development work, including installing docker-desktop on it, so it will take a bit of time and I may be able to tell you tomorrow |
Update: I've discarded all previous changes and updated vs code prefs, so the LF-CRLF issue seems to be resolved. Thanks, @SkyeYoung, Lmk if you find any update on the reloading issue. |
🤔 cc @juzhiyuan |
There has no plan to release packages with the same version numbers. But I suggest adding some notes on each project's documentation: which version is compatible? A better way is let each component to auto detect version 🤔 |
@RajVarsani Sorry for too late. I tried it, but it doesn't seem to reproduce the thermal reloading problem. I tried searching and found this https://stackoverflow.com/questions/65445600/hot-reload-is-not-working-in-my-react-app. I don't know if it will help you... |
I'll check and update here ✅ |
@SkyeYoung @anhldbk Hello, can I work on this issue? |
Hey, I'm new to open source and would like to work on this so can you please assign me this issue. |
@Mackenzie-OO7 @kondapalli19 Hi, I think you can try to collaborate and work together to complete it. Alternatively, you can try dividing the work among yourselves and each person can complete their own part. This will require you to collaborate and communicate with each other. 😸 |
@SkyeYoung T component-selector block you want to put that at the top of the version selector block or something else |
@Mackenzie-OO7 Hi! Thank you for the suggestions. I think dividing the work among ourselves and communicating with each other would be a good approach. Let's discuss how we can divide the work and make sure we're on the same page. Looking forward to working together on this! 😊 |
Hey @anhldbk, is this still available? |
@rukundob451 make a PR fast pls |
Can I be assigned this issue? |
Hi , Can I work on this issue? |
Current State
Description of the current state/issue:
I like the modern design system of our website.
I think there's an issue with our web usability: the version block and the component one are too far from each other.
Users may mistakenly think this is the version of apisix instead.
Link to the page:
Any doc page, for example: https://apisix.apache.org/docs/apisix/getting-started/
Desired State
Description of the change you are proposing:
We can move the component-selector block to the sidebar at the top-right corner
Would you like to fix this issue?
No. Please assign another contributor
The text was updated successfully, but these errors were encountered: