Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45510: [CI][C++] Fix LLVM APT repository preparation on Debian #45511

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kou
Copy link
Member

@kou kou commented Feb 12, 2025

Rationale for this change

The existing LLVM APT repository preparation is broken. For example, it uses unavailable ${available_llvm}.

What changes are included in this PR?

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
Copy link
Member Author

kou commented Feb 12, 2025

@github-actions crossbow submit test-debian-12-*

Copy link

⚠️ GitHub issue #45510 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Feb 12, 2025
Copy link

Revision: 23cac6e

Submitted crossbow builds: ursacomputing/crossbow @ actions-81ac5f56f9

Task Status
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-debian-12-docs GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure on debian-12-docs doesn't seem related to this change:

2025-02-12T08:43:06.1451336Z -- Unable to find cuda_runtime.h in "/usr/lib/include" for CUDAToolkit_INCLUDE_DIR.
2025-02-12T08:43:06.1452770Z -- Unable to find cublas_v2.h in either "" or "/math_libs/include"
2025-02-12T08:43:06.1476771Z CMake Error at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
2025-02-12T08:43:06.1477685Z   Could NOT find CUDAToolkit (missing: CUDAToolkit_INCLUDE_DIR) (found
2025-02-12T08:43:06.1478231Z   version "11.8.89")
2025-02-12T08:43:06.1478583Z Call Stack (most recent call first):
2025-02-12T08:43:06.1479324Z   /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
2025-02-12T08:43:06.1480405Z   /usr/share/cmake-3.25/Modules/FindCUDAToolkit.cmake:869 (find_package_handle_standard_args)
2025-02-12T08:43:06.1481189Z   src/arrow/gpu/CMakeLists.txt:44 (find_package)

I can see nvidia-cuda-toolkit being installed successfully. We probably want to open that as a separate issue and merge this.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Feb 12, 2025
@kou
Copy link
Member Author

kou commented Feb 12, 2025

It makes sense. Let's do it.

@raulcd
Copy link
Member

raulcd commented Feb 12, 2025

ok, I've opened the issue mentioned above. I am merging this.
Thanks @kou

@raulcd raulcd merged commit c2432af into apache:main Feb 12, 2025
32 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Feb 12, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c2432af.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them.

@kou kou deleted the ci-debian-12 branch February 13, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants