[Dataflow Streaming] Fix nullness supression in StreamingModeExecutionContext by arunpandianp · Pull Request #38842 · apache/beam

arunpandianp · 2026-06-08T07:57:55Z

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…nContext

gemini-code-assist · 2026-06-08T07:58:07Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the null safety of the StreamingModeExecutionContext class by replacing broad nullness suppression with explicit nullability annotations and robust validation. These changes ensure that potential null states are handled safely, reducing the risk of runtime errors and improving the overall maintainability of the streaming execution logic.

Highlights

Null Safety Improvements: Removed the broad @SuppressWarnings("nullness") annotation and introduced explicit @nullable annotations across the StreamingModeExecutionContext class to improve type safety.
Defensive Programming: Replaced generic checkNotNull calls with checkStateNotNull and added explicit null checks to handle potentially uninitialized state components, preventing runtime null pointer exceptions.
Refactoring and Initialization: Streamlined the initialization of operational limits and tag encoding, and improved the handling of optional state families within the StepContext.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request improves null safety in StreamingModeExecutionContext.java by removing the 'nullness' warning suppression, adding @nullable annotations, and replacing checkNotNull with checkStateNotNull. It also refactors StepContext to eagerly initialize several collections and clear them on start, and wraps state/timer initialization with a null check on stateFamily. The review feedback suggests further optimizing getNextFiredTimer and getNextFiredUserTimer by returning early if stateFamily is null, which prevents unnecessary processing and potential NullPointerExceptions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-06-08T07:59:36Z

+    public <W extends BoundedWindow> @Nullable TimerData getNextFiredTimer(Coder<W> windowCoder) {
+      Iterator<TimerData> firedSystemTimers = cachedFiredSystemTimers;


For stateless steps, stateFamily is null. To avoid unnecessary processing and potential NullPointerExceptions when filtering timers, we can return null immediately if stateFamily is null.

public <W extends BoundedWindow> @Nullable TimerData getNextFiredTimer(Coder<W> windowCoder) { if (stateFamily == null) { return null; } Iterator<TimerData> firedSystemTimers = cachedFiredSystemTimers;

do it? seems like will reduce allocations in common case, even if null exception isn't a concern

gemini-code-assist · 2026-06-08T07:59:36Z

+    public <W extends BoundedWindow> @Nullable TimerData getNextFiredUserTimer(
+        Coder<W> windowCoder) {
+      PeekingIterator<TimerData> firedUserTimers = cachedFiredUserTimers;


Similar to getNextFiredTimer, we can return null immediately if stateFamily is null to avoid unnecessary processing and safely guarantee that userTimerInternals is non-null for subsequent operations.

public <W extends BoundedWindow> @Nullable TimerData getNextFiredUserTimer( Coder<W> windowCoder) { if (stateFamily == null) { return null; } PeekingIterator<TimerData> firedUserTimers = cachedFiredUserTimers;

arunpandianp · 2026-06-08T07:59:40Z

R: @scwhittle

github-actions · 2026-06-08T08:00:56Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

scwhittle

[edited] missed one commit

scwhittle · 2026-06-08T08:29:45Z

+    public <W extends BoundedWindow> @Nullable TimerData getNextFiredTimer(Coder<W> windowCoder) {
+      Iterator<TimerData> firedSystemTimers = cachedFiredSystemTimers;


do it? seems like will reduce allocations in common case, even if null exception isn't a concern

scwhittle · 2026-06-08T08:29:57Z

+    public <W extends BoundedWindow> @Nullable TimerData getNextFiredUserTimer(
+        Coder<W> windowCoder) {
+      PeekingIterator<TimerData> firedUserTimers = cachedFiredUserTimers;


scwhittle · 2026-06-08T08:31:02Z

scwhittle · 2026-06-08T08:38:54Z

-    private WindmillStateInternals<Object> stateInternals;
-    private WindmillTimerInternals systemTimerInternals;
-    private WindmillTimerInternals userTimerInternals;
+    private @Nullable WindmillStateInternals<Object> stateInternals;


MonotonicNonNull might help reduce necessary annotations within functions for some of these,

Marked them as MonotonicNonNull, not sure if there are any checks that can be removed though.

[Dataflow Streaming] Fix nullness supression in StreamingModeExecutio…

3dceab0

…nContext

github-actions Bot added runners dataflow labels Jun 8, 2026

gemini-code-assist Bot reviewed Jun 8, 2026

View reviewed changes

arunpandianp mentioned this pull request Jun 8, 2026

[Dataflow Streaming] [Multi Key] Prepare StreamingModeExecutionContext and StreamingWorkScheduler for multi-key execution. #38814

Open

make windmillTagEncoding final

e199438

scwhittle requested changes Jun 8, 2026

View reviewed changes

address comments

700dfbc

arunpandianp requested a review from scwhittle June 8, 2026 09:01

arunpandianp added 2 commits June 8, 2026 09:43

fix test

0398b06

fix test

fdeca45

scwhittle approved these changes Jun 8, 2026

View reviewed changes

		public <W extends BoundedWindow> @Nullable TimerData getNextFiredTimer(Coder<W> windowCoder) {
		Iterator<TimerData> firedSystemTimers = cachedFiredSystemTimers;

Conversation

arunpandianp commented Jun 8, 2026

GitHub Actions Tests Status (on master branch)

Uh oh!

gemini-code-assist Bot commented Jun 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arunpandianp commented Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

scwhittle left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

scwhittle left a comment •

edited

Loading