-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With the 3.0.2 version, the turn orientation change for iOS on landscape mode #56
Comments
As I understand the PR this was actually a bug on iOS before (vs. how it should work and how it works on other platforms) that has been fixed there. Do you disagree? |
Well, as i understand, there was a bug when in landscape mode, doing screen.orientation.lock(landscape);, it flips to the opposite landscape For my app, the PR solve no problem ,but add this issue |
Can you visualize this with screenshots or even better a repro app? I am not sure I fully understand what is going on. |
Sorry for the poor screenshot edited in paint quality, but here is the problem Our ionic application is fixed in portrait in config.xml
The only time we switch to landcape is when clicking on the arrow (in red in my beautiful screenshot). typescript code is
(we are using ionic-native adaptation of the plugin : https://ionicframework.com/docs/native/screen-orientation/ ) With 3.0.1 plugin, both android and iphone were rotating in the same direction (top one on screenshot), so counter clockwise |
Thank you! And I though the bugfix in 3.0.2 would actually fix this to be correct... Can you create a new project with some minimal pages that reproduces this problem? I need to look at it myself. (Ionic is fine in this case - but if you want to do it in plain Cordova you of course get bonus points) |
@Stephane84 - Just try once from here, Seems it will work for you. |
Bug Report
Problem
With the 3.0.2 version, the turn orientation change for iOS on landscape mode
What is expected to happen?
I have an ionic3 app in portrait mode, fixed in config.xml :
in 3.0.1, when using ionic native : this.screenOrientation.lock(this.screenOrientation.ORIENTATIONS.LANDSCAPE);
the app turn right, and we turn the device on left to have the top of the device on left
I use this orientation on a specific page, not on all
What does actually happen?
in 3.0.2 :
the app turn left, and we turn the device on right to have the top of the device on right
Information
Seems to be this PR who include the bug : #25
Command or Code
this.screenOrientation.lock(this.screenOrientation.ORIENTATIONS.LANDSCAPE);
Environment, Platform, Device
on iOS only, android still work well
Version information
"@ionic-native/screen-orientation": "4.7.0",
"ionic-angular": "3.9.2",
"cordova-plugin-screen-orientation": "3.0.2",
Checklist
The text was updated successfully, but these errors were encountered: