address_review_comments

Author: coderfender

native/spark-expr/src/static_invoke/char_varchar_utils/read_side_padding.rs

@@ -83,34 +83,13 @@ fn spark_read_side_padding2(
                 DataType::Utf8 => spark_read_side_padding_internal::<i32>(
                     array,
                     truncate,
-                    ColumnarValue::Array(Arc::<dyn arrow::array::Array>::clone(array_int)),
+                    ColumnarValue::Array(Arc::<dyn Array>::clone(array_int)),
                 ),
                 DataType::LargeUtf8 => spark_read_side_padding_internal::<i64>(
                     array,
                     truncate,
-                    ColumnarValue::Array(Arc::<dyn arrow::array::Array>::clone(array_int)),
+                    ColumnarValue::Array(Arc::<dyn Array>::clone(array_int)),
                 ),
-                // Dictionary support required for SPARK-48498
-                DataType::Dictionary(_, value_type) => {
-                    let dict = as_dictionary_array::<Int32Type>(array);
-                    let col = if value_type.as_ref() == &DataType::Utf8 {
-                        spark_read_side_padding_internal::<i32>(
-                            dict.values(),
-                            truncate,
-                            ColumnarValue::Array(Arc::<dyn arrow::array::Array>::clone(array_int)),
-                        )?
-                    } else {
-                        spark_read_side_padding_internal::<i64>(
-                            dict.values(),
-                            truncate,
-                            ColumnarValue::Array(Arc::<dyn arrow::array::Array>::clone(array_int)),
-                        )?
-                    };
-                    // col consists of an array, so arg of to_array() is not used. Can be anything
-                    let values = col.to_array(0)?;
-                    let result = DictionaryArray::try_new(dict.keys().clone(), values)?;
-                    Ok(ColumnarValue::Array(make_array(result.into())))
-                }
                 other => Err(DataFusionError::Internal(format!(
                     "Unsupported data type {other:?} for function rpad/read_side_padding",
                 ))),

spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala

@@ -322,7 +322,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {
       checkSparkAnswer("SELECT try_add(_1, _2) FROM tbl")
     }
   }
-  test("fix_rpad") {
+  test("Verify rpad expr support for second arg instead of just literal") {
     withTable("t1") {
       val value = "IfIWasARoadIWouldBeBent"
       sql("create table t1(c1 varchar(100), c2 int) using parquet")