Skip to content

Commit 8db9865

Browse files
committed
Drop redundant/unused values (in tests)
1 parent b467528 commit 8db9865

File tree

4 files changed

+12
-41
lines changed

4 files changed

+12
-41
lines changed

tests/sqlparser_common.rs

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ use sqlparser::dialect::{
3939
};
4040
use sqlparser::keywords::{Keyword, ALL_KEYWORDS};
4141
use sqlparser::parser::{Parser, ParserError, ParserOptions};
42-
use sqlparser::tokenizer::{Location, Span, TokenWithSpan};
43-
use sqlparser::tokenizer::{Token, Tokenizer};
42+
use sqlparser::tokenizer::{Location, Span};
43+
use sqlparser::tokenizer::Tokenizer;
4444
use test_utils::{
4545
all_dialects, all_dialects_where, all_dialects_with_options, alter_table_op, assert_eq_vec,
4646
call, expr_from_projection, join, number, only, table, table_alias, table_from_name,
@@ -440,10 +440,7 @@ fn parse_update_set_from() {
440440
assert_eq!(
441441
stmt,
442442
Statement::Update(Update {
443-
update_token: AttachedToken(TokenWithSpan {
444-
token: Token::make_keyword("UPDATE"),
445-
span: Span::new((1, 1).into(), (1, 7).into()),
446-
}),
443+
update_token: AttachedToken::empty(),
447444
table: TableWithJoins {
448445
relation: table_from_name(ObjectName::from(vec![Ident::new("t1")])),
449446
joins: vec![],
@@ -539,7 +536,7 @@ fn parse_update_with_table_alias() {
539536
returning,
540537
or: None,
541538
limit: None,
542-
update_token,
539+
update_token: _,
543540
}) => {
544541
assert_eq!(
545542
TableWithJoins {
@@ -588,13 +585,6 @@ fn parse_update_with_table_alias() {
588585
selection
589586
);
590587
assert_eq!(None, returning);
591-
assert_eq!(
592-
AttachedToken(TokenWithSpan {
593-
token: Token::make_keyword("UPDATE"),
594-
span: Span::new((1, 1).into(), (1, 7).into()),
595-
}),
596-
update_token
597-
);
598588
}
599589
_ => unreachable!(),
600590
}

tests/sqlparser_mysql.rs

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use sqlparser::ast::*;
2727
use sqlparser::dialect::{GenericDialect, MySqlDialect};
2828
use sqlparser::parser::{ParserError, ParserOptions};
2929
use sqlparser::tokenizer::Token;
30-
use sqlparser::tokenizer::{Span, TokenWithSpan};
30+
use sqlparser::tokenizer::Span;
3131
use test_utils::*;
3232

3333
#[macro_use]
@@ -2623,7 +2623,7 @@ fn parse_update_with_joins() {
26232623
returning,
26242624
or: None,
26252625
limit: None,
2626-
update_token,
2626+
update_token: _,
26272627
}) => {
26282628
assert_eq!(
26292629
TableWithJoins {
@@ -2698,13 +2698,6 @@ fn parse_update_with_joins() {
26982698
selection
26992699
);
27002700
assert_eq!(None, returning);
2701-
assert_eq!(
2702-
AttachedToken(TokenWithSpan {
2703-
token: Token::make_keyword("UPDATE"),
2704-
span: Span::new((1, 1).into(), (1, 7).into()),
2705-
}),
2706-
update_token
2707-
);
27082701
}
27092702
_ => unreachable!(),
27102703
}

tests/sqlparser_postgres.rs

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
mod test_utils;
2424

2525
use helpers::attached_token::AttachedToken;
26-
use sqlparser::tokenizer::{Span, Token, TokenWithSpan};
26+
use sqlparser::tokenizer::Span;
2727
use test_utils::*;
2828

2929
use sqlparser::ast::*;
@@ -5140,10 +5140,7 @@ fn test_simple_postgres_insert_with_alias() {
51405140
assert_eq!(
51415141
statement,
51425142
Statement::Insert(Insert {
5143-
insert_token: AttachedToken(TokenWithSpan {
5144-
token: Token::make_keyword("INSERT"),
5145-
span: Span::new((1, 1).into(), (1, 7).into()),
5146-
}),
5143+
insert_token: AttachedToken::empty(),
51475144
or: None,
51485145
ignore: false,
51495146
into: true,
@@ -5213,10 +5210,7 @@ fn test_simple_postgres_insert_with_alias() {
52135210
assert_eq!(
52145211
statement,
52155212
Statement::Insert(Insert {
5216-
insert_token: AttachedToken(TokenWithSpan {
5217-
token: Token::make_keyword("INSERT"),
5218-
span: Span::new((1, 1).into(), (1, 7).into()),
5219-
}),
5213+
insert_token: AttachedToken::empty(),
52205214
or: None,
52215215
ignore: false,
52225216
into: true,
@@ -5288,10 +5282,7 @@ fn test_simple_insert_with_quoted_alias() {
52885282
assert_eq!(
52895283
statement,
52905284
Statement::Insert(Insert {
5291-
insert_token: AttachedToken(TokenWithSpan {
5292-
token: Token::make_keyword("INSERT"),
5293-
span: Span::new((1, 1).into(), (1, 7).into()),
5294-
}),
5285+
insert_token: AttachedToken::empty(),
52955286
or: None,
52965287
ignore: false,
52975288
into: true,

tests/sqlparser_sqlite.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ use sqlparser::ast::Value::Placeholder;
3131
use sqlparser::ast::*;
3232
use sqlparser::dialect::{GenericDialect, SQLiteDialect};
3333
use sqlparser::parser::{ParserError, ParserOptions};
34-
use sqlparser::tokenizer::{Span, Token, TokenWithSpan};
34+
use sqlparser::tokenizer::Token;
3535

3636
#[test]
3737
fn pragma_no_value() {
@@ -496,10 +496,7 @@ fn parse_update_tuple_row_values() {
496496
from: None,
497497
returning: None,
498498
limit: None,
499-
update_token: AttachedToken(TokenWithSpan {
500-
token: Token::make_keyword("UPDATE"),
501-
span: Span::new((1, 1).into(), (1, 7).into())
502-
})
499+
update_token: AttachedToken::empty()
503500
})
504501
);
505502
}

0 commit comments

Comments
 (0)