[refactor](pipeline) refactor local merge sort operator #48360
+524
−657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 31593 ms |
TPC-DS: Total hot run time: 190768 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.38 s |
|
run buildall |
TPC-H: Total hot run time: 31714 ms |
TPC-DS: Total hot run time: 191251 ms |
ClickBench: Total hot run time: 31.05 s |
|
TeamCity be ut coverage result: |
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
force-pushed
the
Refactor-local-merge
branch
from
e0b3ac6 to
16ed064
Compare
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Mryange
force-pushed
the
Refactor-local-merge
branch
from
16ed064 to
6f4744a
Compare
|
run buildall |
Mryange
force-pushed
the
Refactor-local-merge
branch
from
6f4744a to
4b06182
Compare
|
run buildall |
TPC-H: Total hot run time: 31740 ms |
TPC-DS: Total hot run time: 185244 ms |
ClickBench: Total hot run time: 30.44 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
16 tasks
Mryange
force-pushed
the
Refactor-local-merge
branch
from
4b06182 to
5cee9b1
Compare
|
run buildall |
TPC-H: Total hot run time: 31740 ms |
TPC-DS: Total hot run time: 189707 ms |
ClickBench: Total hot run time: 31.29 s |
Mryange
force-pushed
the
Refactor-local-merge
branch
from
5cee9b1 to
fd64cf9
Compare
Mryange
changed the title
|
run buildall |
TPC-H: Total hot run time: 31729 ms |
TPC-DS: Total hot run time: 183949 ms |
ClickBench: Total hot run time: 30.9 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
Gabriel39
reviewed
Mar 4, 2025
| RETURN_IF_ERROR(_vsort_exec_exprs.prepare(state, _child->row_desc(), _row_descriptor)); | ||
| RETURN_IF_ERROR(_vsort_exec_exprs.open(state)); | ||
| for (int i = 1; i < _parallel_tasks; ++i) { | ||
| auto dep = Dependency::create_shared(operator_id(), node_id(), |
There was a problem hiding this comment.
Attach each instance ID to the dep's name
| } | ||
| return deps; | ||
| } else { | ||
| return {_dependency}; |
There was a problem hiding this comment.
Why we still need a dependency for other tasks?
| auto& local_state = get_local_state(state); | ||
| DCHECK(_other_source_deps.contains(local_state._task_idx)); | ||
| _sorters[local_state._task_idx] = local_state._shared_state->sorter; | ||
| _other_source_deps[local_state._task_idx]->set_ready(); |
There was a problem hiding this comment.
Why need to set ready here?
| @@ -1513,8 +1493,12 @@ Status PipelineFragmentContext::_create_operator(ObjectPool* pool, const TPlanNo | |||
| case TPlanNodeType::SORT_NODE: { | |||
| const auto should_spill = _runtime_state->enable_spill() && | |||
| tnode.sort_node.algorithm == TSortAlgorithm::FULL_SORT; | |||
| const bool use_local_merge = | |||
| tnode.sort_node.merge_by_exchange && _runtime_state->enable_local_merge_sort(); | |||
There was a problem hiding this comment.
Set tnode.sort_node.merge_by_exchange if enable_local_merge_sort is true by FE. Here we just need to decide whether to use local merge by tnode.sort_node.merge_by_exchange
Mryange
force-pushed
the
Refactor-local-merge
branch
from
fc0ebec to
3fe9c17
Compare
|
run buildall |
TPC-H: Total hot run time: 32524 ms |
TPC-DS: Total hot run time: 191432 ms |
ClickBench: Total hot run time: 31.06 s |
|
run buildall |
TPC-H: Total hot run time: 32413 ms |
TPC-DS: Total hot run time: 184265 ms |
ClickBench: Total hot run time: 30.68 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run external |
|
run buildall |
TPC-H: Total hot run time: 32558 ms |
TPC-DS: Total hot run time: 185332 ms |
ClickBench: Total hot run time: 31.05 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)