Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow modules to extend Dubbo application configuration #14308

Open
4 tasks done
walklown opened this issue Jun 11, 2024 · 2 comments
Open
4 tasks done

[Feature] Allow modules to extend Dubbo application configuration #14308

walklown opened this issue Jun 11, 2024 · 2 comments
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@walklown
Copy link

walklown commented Jun 11, 2024

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Allow modules to extend Dubbo application configuration to support custom configuration in other modules.
For example, I expect to define MetricsConfig in the dubbo-metrics module and PromethusConfig in the dubbo-metrics-promethus module. And in the future, I expect to define OtlpConfig in dubbo-metrics-export-otlp.

Related issues

Separate the code for indicator monitoring
Refector Metric export

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@walklown walklown added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Jun 11, 2024
@walklown
Copy link
Author

walklown commented Jun 11, 2024

Example :
walklown@043561f

Question :

  1. AbstractConfig can be removed so that the Config class will be more generic . Is this improvement necessary? I hope to get some suggestions
  2. Is SPI a good way to implement extended configuration classes? Any better suggestions?

@AlbumenJ
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants