From e750702966ed3e17b8eed4300ad75f40d19a3383 Mon Sep 17 00:00:00 2001
From: Lambert Rao <101875596+Lambert-Rao@users.noreply.github.com>
Date: Tue, 19 Mar 2024 15:46:27 +0800
Subject: [PATCH] [ISSUE #67] Fix HealthCheckResultMapper which leads to
 application error

---
 .../mapper/health/HealthCheckResultMapper.java  | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/mapper/health/HealthCheckResultMapper.java b/eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/mapper/health/HealthCheckResultMapper.java
index 01930c5b..519605ba 100644
--- a/eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/mapper/health/HealthCheckResultMapper.java
+++ b/eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/mapper/health/HealthCheckResultMapper.java
@@ -58,11 +58,18 @@ List<HealthCheckResultEntity> selectByClusterIdAndCreateTimeRange(@Param("cluste
 
     @Insert({
         "<script>",
-        "   INSERT INTO health_check_result(type, type_id, cluster_id, state, result_desc) VALUES ",
-        "   <foreach collection='list' item='healthCheckResultEntity' index='index' separator=','>",
-        "       (#{healthCheckResultEntity.type}, #{healthCheckResultEntity.typeId}, #{healthCheckResultEntity.clusterId},",
-        "       #{healthCheckResultEntity.state}, #{healthCheckResultEntity.resultDesc})",
-        "   </foreach>",
+        "   <choose>",
+        "   <when test='list.size() > 0'>",
+        "       INSERT INTO health_check_result(type, type_id, cluster_id, state, result_desc) VALUES ",
+        "       <foreach collection='list' item='healthCheckResultEntity' index='index' separator=','>",
+        "           (#{healthCheckResultEntity.type}, #{healthCheckResultEntity.typeId}, #{healthCheckResultEntity.clusterId},",
+        "           #{healthCheckResultEntity.state}, #{healthCheckResultEntity.resultDesc})",
+        "       </foreach>",
+        "   </when>",
+        "   <otherwise>",
+        "       SELECT 1 FROM DUAL WHERE FALSE",
+        "   </otherwise>",
+        "   </choose>",
         "</script>"
     })
     void batchInsert(List<HealthCheckResultEntity> healthCheckResultEntityList);