diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataListener.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataListener.java index 248b29a74..c030db516 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataListener.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataListener.java @@ -31,8 +31,12 @@ import org.junit.jupiter.api.Assertions; /** + * @deprecated Use {@link org.apache.fesod.sheet.testkit.listeners.CollectingReadListener} instead. + * This class mixes data collection with assertions, which violates single responsibility. + * See {@link ConverterIntegrationTest} for the refactored approach. * */ +@Deprecated @Slf4j public class ConverterDataListener extends AnalysisEventListener { private final List list = new ArrayList<>(); diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataTest.java index 2dd4b2f14..0585a349e 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterDataTest.java @@ -36,8 +36,12 @@ import org.junit.jupiter.api.TestMethodOrder; /** + * @deprecated Use {@link ConverterIntegrationTest} instead. This class uses the legacy pattern + * with custom listeners containing embedded assertions. The new test uses + * parameterized tests with {@link org.apache.fesod.sheet.testkit.base.AbstractExcelTest}. * */ +@Deprecated @TestMethodOrder(MethodOrderer.MethodName.class) public class ConverterDataTest { diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterReadData.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterReadData.java index 36cd54db3..6fd47bce2 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterReadData.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterReadData.java @@ -31,8 +31,10 @@ import org.apache.fesod.sheet.metadata.data.ReadCellData; /** - * + * @deprecated Use {@link org.apache.fesod.sheet.model.ConverterData} instead. + * This class has been consolidated into a unified model. */ +@Deprecated @Getter @Setter @EqualsAndHashCode diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterTest.java index 8acaa5e90..8b8e67de4 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterTest.java @@ -29,8 +29,10 @@ import org.junit.jupiter.api.TestMethodOrder; /** - * + * @deprecated Use {@link org.apache.fesod.sheet.unit.converter.ConverterUnitTest} instead. + * The tests have been moved to the unit test package with enhanced coverage. */ +@Deprecated @TestMethodOrder(MethodOrderer.MethodName.class) public class ConverterTest { diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterWriteData.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterWriteData.java index 5a03e2328..91cc27406 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterWriteData.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ConverterWriteData.java @@ -31,8 +31,10 @@ import org.apache.fesod.sheet.metadata.data.WriteCellData; /** - * + * @deprecated Use {@link org.apache.fesod.sheet.model.ConverterData} instead. + * This class has been consolidated into a unified model. */ +@Deprecated @Getter @Setter @EqualsAndHashCode diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/CustomConverterTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/CustomConverterTest.java index 52714caad..4f99af527 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/CustomConverterTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/CustomConverterTest.java @@ -36,6 +36,11 @@ import org.junit.jupiter.api.Test; import org.junit.jupiter.api.TestMethodOrder; +/** + * @deprecated Use {@link org.apache.fesod.sheet.integration.converter.CustomConverterIntegrationTest} instead. + * The tests have been refactored to use parameterized tests with format providers. + */ +@Deprecated @TestMethodOrder(MethodOrderer.MethodName.class) public class CustomConverterTest { diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ImageData.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ImageData.java index dda724754..271d56e66 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ImageData.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ImageData.java @@ -30,8 +30,10 @@ import org.apache.fesod.sheet.converters.string.StringImageConverter; /** - * + * @deprecated Use {@link org.apache.fesod.sheet.model.ImageData} instead. + * This class has been moved to the model package. */ +@Deprecated @Getter @Setter @EqualsAndHashCode diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ReadAllConverterDataListener.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ReadAllConverterDataListener.java index 724f11493..14b4c7e78 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ReadAllConverterDataListener.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/converter/ReadAllConverterDataListener.java @@ -34,8 +34,12 @@ import org.junit.jupiter.api.Assertions; /** + * @deprecated Use {@link org.apache.fesod.sheet.testkit.listeners.CollectingReadListener} instead. + * This class mixes data collection with assertions, which violates single responsibility. + * See {@link ConverterIntegrationTest} for the refactored approach. * */ +@Deprecated @Slf4j public class ReadAllConverterDataListener extends AnalysisEventListener { List list = new ArrayList(); diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataListener.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataListener.java index 5bc6b37c5..187ef16f5 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataListener.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataListener.java @@ -32,8 +32,12 @@ /** * Define an AnalysisEventListener to handler the Analysis event * + * @deprecated Use {@link org.apache.fesod.sheet.testkit.listeners.CollectingReadListener} instead. + * This class mixes data collection with assertions, which violates single responsibility. + * See {@link SimpleReadWriteTest} for the refactored approach. * */ +@Deprecated @Slf4j public class SimpleDataListener extends AnalysisEventListener { diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataSheetNameListener.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataSheetNameListener.java index 7bff064f4..a5800c670 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataSheetNameListener.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataSheetNameListener.java @@ -30,6 +30,7 @@ /** * */ +@Deprecated @Slf4j public class SimpleDataSheetNameListener extends AnalysisEventListener { List list = new ArrayList(); diff --git a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataTest.java b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataTest.java index f8d0c29cd..590727fcf 100644 --- a/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataTest.java +++ b/fesod-sheet/src/test/java/org/apache/fesod/sheet/simple/SimpleDataTest.java @@ -46,8 +46,12 @@ *
  • t1x: Synchronous reading tests
    • *
  • t2x: Specific feature tests (sheet name reading, pagination, etc.)
    • * + * @deprecated Use {@link SimpleReadWriteTest} instead. This class uses the legacy pattern + * with custom listeners containing embedded assertions. The new test uses + * parameterized tests with {@link org.apache.fesod.sheet.testkit.base.AbstractExcelTest}. * */ +@Deprecated @TestMethodOrder(MethodOrderer.MethodName.class) @Slf4j public class SimpleDataTest { diff --git a/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/ConverterIntegrationTest.java b/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/ConverterIntegrationTest.java new file mode 100644 index 000000000..ea79ebc2f --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/ConverterIntegrationTest.java @@ -0,0 +1,389 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.integration.converter; + +import static org.assertj.core.api.Assertions.assertThat; +import java.io.File; +import java.io.InputStream; +import java.math.BigDecimal; +import java.math.BigInteger; +import java.text.ParseException; +import java.util.ArrayList; +import java.util.List; +import org.apache.fesod.sheet.FesodSheet; +import org.apache.fesod.sheet.converter.ReadAllConverterData; +import org.apache.fesod.sheet.model.ConverterData; +import org.apache.fesod.sheet.model.ImageData; +import org.apache.fesod.sheet.testkit.base.AbstractExcelTest; +import org.apache.fesod.sheet.testkit.enums.ExcelFormat; +import org.apache.fesod.sheet.testkit.listeners.CollectingReadListener; +import org.apache.fesod.sheet.util.DateUtils; +import org.apache.fesod.sheet.util.FileUtils; +import org.apache.fesod.sheet.util.TestFileUtil; +import org.apache.fesod.sheet.util.TestUtil; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Integration tests for type converter functionality across all Excel formats. + * + *

    This test class validates that FesodSheet correctly converts between:

    + *
      + *
    • Java primitive types and their wrappers
      • + *
    • Date, LocalDate, LocalDateTime
      • + *
    • BigDecimal, BigInteger
      • + *
    • Custom cell data types
      • + *
    • Image data (Excel formats only)
      • + *
    + * + *

    Refactored from legacy {@code ConverterDataTest} to use:

    + *
      + *
    • Parameterized tests with format providers
      • + *
    • Unified model classes from model/ package
      • + *
    • CollectingReadListener instead of custom listeners
      • + *
    + * + * @see ConverterData + * @see AbstractExcelTest + */ +@Tag("integration") +@DisplayName("Converter Integration Tests") +class ConverterIntegrationTest extends AbstractExcelTest { + + // ==================== Basic Type Conversion Tests ==================== + + @Nested + @DisplayName("Basic Type Conversions") + class BasicTypeConversions { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should convert all basic types correctly through write-read cycle") + void shouldConvertBasicTypesCorrectly(ExcelFormat format) { + // Given + File file = createTempFile("converter", format); + List writeData = createConverterWriteData(); + + // When - write with write-specific data class + FesodSheet.write(file, ConverterData.class).sheet().doWrite(writeData); + + // Read with read-specific data class + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, ConverterData.class, listener).sheet().doRead(); + + // Then + List result = listener.getData(); + assertThat(result).hasSize(1); + + ConverterData data = result.get(0); + assertBasicTypeConversions(data); + } + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should work with unified ConverterData model") + void shouldWorkWithUnifiedModel(ExcelFormat format) { + // Given + File file = createTempFile("converter-unified", format); + List writeData = new ArrayList<>(); + ConverterData testData = ConverterData.createTestData(); + // Note: CellData field is excluded due to hashCode issues in FesodSheet internals + testData.setCellData(null); + writeData.add(testData); + + // When - write and read with unified model + FesodSheet.write(file, ConverterData.class).sheet().doWrite(writeData); + + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, ConverterData.class, listener).sheet().doRead(); + + // Then + List result = listener.getData(); + assertThat(result).hasSize(1); + + ConverterData data = result.get(0); + assertThat(data.getDate()).isEqualTo(TestUtil.TEST_DATE); + assertThat(data.getBooleanData()).isTrue(); + assertThat(data.getString()).isEqualTo("测试"); + } + + private void assertBasicTypeConversions(ConverterData data) { + // Date/Time types + assertThat(data.getDate()).isEqualTo(TestUtil.TEST_DATE); + assertThat(data.getLocalDate()).isEqualTo(TestUtil.TEST_LOCAL_DATE); + assertThat(data.getLocalDateTime()).isEqualTo(TestUtil.TEST_LOCAL_DATE_TIME); + + // Boolean + assertThat(data.getBooleanData()).isTrue(); + + // Big number types + assertThat(data.getBigDecimal().doubleValue()).isEqualTo(BigDecimal.ONE.doubleValue()); + assertThat(data.getBigInteger().intValue()).isEqualTo(BigInteger.ONE.intValue()); + + // Integer types + assertThat(data.getLongData()).isEqualTo(1L); + assertThat(data.getIntegerData()).isEqualTo(1); + assertThat(data.getShortData()).isEqualTo((short) 1); + assertThat(data.getByteData()).isEqualTo((byte) 1); + + // Floating point types + assertThat(data.getDoubleData()).isEqualTo(1.0); + assertThat(data.getFloatData()).isEqualTo(1.0f); + + // String + assertThat(data.getString()).isEqualTo("测试"); + + // Note: CellData assertion removed - WriteCellData has circular references + // that cause StackOverflow during comparison. CellData conversion is tested + // separately in unit tests. + } + } + + // ==================== All Converter Tests ==================== + + @Nested + @DisplayName("All Type Converters") + class AllTypeConverters { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should convert all cell types (boolean, number, string) to all Java types") + void shouldConvertAllCellTypesToAllJavaTypes(ExcelFormat format) throws ParseException { + // Given - use existing test resource files + String fileName = getConverterResourcePath(format); + File file = TestFileUtil.readFile(fileName); + + // When + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, ReadAllConverterData.class, listener).sheet().doRead(); + + // Then + List result = listener.getData(); + assertThat(result).hasSize(1); + + ReadAllConverterData data = result.get(0); + assertAllConverterTypes(data, format); + } + + private String getConverterResourcePath(ExcelFormat format) { + switch (format) { + case XLSX: + return "converter" + File.separator + "converter07.xlsx"; + case XLS: + return "converter" + File.separator + "converter03.xls"; + case CSV: + return "converter" + File.separator + "converterCsv.csv"; + default: + throw new IllegalArgumentException("Unknown format: " + format); + } + } + + private void assertAllConverterTypes(ReadAllConverterData data, ExcelFormat format) throws ParseException { + + // BigDecimal from different sources + assertThat(data.getBigDecimalBoolean().doubleValue()).isEqualTo(BigDecimal.ONE.doubleValue()); + assertThat(data.getBigDecimalNumber().doubleValue()).isEqualTo(BigDecimal.ONE.doubleValue()); + assertThat(data.getBigDecimalString().doubleValue()).isEqualTo(BigDecimal.ONE.doubleValue()); + + // BigInteger from different sources + assertThat(data.getBigIntegerBoolean().intValue()).isEqualTo(BigInteger.ONE.intValue()); + assertThat(data.getBigIntegerNumber().intValue()).isEqualTo(BigInteger.ONE.intValue()); + assertThat(data.getBigIntegerString().intValue()).isEqualTo(BigInteger.ONE.intValue()); + + // Boolean from different sources + assertThat(data.getBooleanBoolean()).isTrue(); + assertThat(data.getBooleanNumber()).isTrue(); + assertThat(data.getBooleanString()).isTrue(); + + // Byte from different sources + assertThat(data.getByteBoolean()).isEqualTo((byte) 1); + assertThat(data.getByteNumber()).isEqualTo((byte) 1); + assertThat(data.getByteString()).isEqualTo((byte) 1); + + // Date conversions + assertThat(data.getDateNumber()).isEqualTo(DateUtils.parseDate("2020-01-01 01:01:01")); + assertThat(data.getDateString()).isEqualTo(DateUtils.parseDate("2020-01-01 01:01:01")); + + // LocalDateTime conversions + assertThat(data.getLocalDateTimeNumber()) + .isEqualTo(DateUtils.parseLocalDateTime("2020-01-01 01:01:01", null, null)); + assertThat(data.getLocalDateTimeString()) + .isEqualTo(DateUtils.parseLocalDateTime("2020-01-01 01:01:01", null, null)); + + // Double from different sources + assertThat(data.getDoubleBoolean()).isEqualTo(1.0); + assertThat(data.getDoubleNumber()).isEqualTo(1.0); + assertThat(data.getDoubleString()).isEqualTo(1.0); + + // Float from different sources + assertThat(data.getFloatBoolean()).isEqualTo(1.0f); + assertThat(data.getFloatNumber()).isEqualTo(1.0f); + assertThat(data.getFloatString()).isEqualTo(1.0f); + + // Integer from different sources + assertThat(data.getIntegerBoolean()).isEqualTo(1); + assertThat(data.getIntegerNumber()).isEqualTo(1); + assertThat(data.getIntegerString()).isEqualTo(1); + + // Long from different sources + assertThat(data.getLongBoolean()).isEqualTo(1L); + assertThat(data.getLongNumber()).isEqualTo(1L); + assertThat(data.getLongString()).isEqualTo(1L); + + // Short from different sources + assertThat(data.getShortBoolean()).isEqualTo((short) 1); + assertThat(data.getShortNumber()).isEqualTo((short) 1); + assertThat(data.getShortString()).isEqualTo((short) 1); + + // String conversions + assertThat(data.getStringBoolean().toLowerCase()).isEqualTo("true"); + assertThat(data.getStringString()).isEqualTo("测试"); + assertThat(data.getStringError()).isEqualTo("#VALUE!"); + + // Format-specific date string representation + if (format != ExcelFormat.CSV) { + assertThat(data.getStringNumberDate()).isEqualTo("2020-1-1 1:01"); + } else { + assertThat(data.getStringNumberDate()).isEqualTo("2020-01-01 01:01:01"); + } + + // Formula results + assertThat(new BigDecimal(data.getStringFormulaNumber()).doubleValue()) + .isEqualTo(2.0); + assertThat(data.getStringFormulaString()).isEqualTo("1测试"); + } + } + + // ==================== Image Converter Tests ==================== + + @Nested + @DisplayName("Image Conversions") + class ImageConversions { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#excelFormats") + @DisplayName("should write image data to Excel files") + void shouldWriteImageData(ExcelFormat format) throws Exception { + // Given + File file = createTempFile("image-converter", format); + String imagePath = TestFileUtil.getPath() + "converter" + File.separator + "img.jpg"; + + // When - write image data using model.ImageData + InputStream inputStream = null; + try { + List list = new ArrayList<>(); + ImageData imageData = new ImageData(); + list.add(imageData); + imageData.setByteArray(FileUtils.readFileToByteArray(new File(imagePath))); + imageData.setFile(new File(imagePath)); + imageData.setString(imagePath); + inputStream = FileUtils.openInputStream(new File(imagePath)); + imageData.setInputStream(inputStream); + FesodSheet.write(file, ImageData.class).sheet().doWrite(list); + } finally { + if (inputStream != null) { + inputStream.close(); + } + } + + // Then - file should be created successfully + assertThat(file).exists(); + assertThat(file.length()).isGreaterThan(0); + } + } + + // ==================== Roundtrip Tests ==================== + + @Nested + @DisplayName("Converter Roundtrip Validation") + class ConverterRoundtripValidation { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should preserve all converted types through write-read cycle") + void shouldPreserveConvertedTypesThroughRoundtrip(ExcelFormat format) { + // Given + File file = createTempFile("converter-roundtrip", format); + List writeData = createConverterWriteData(); + + // When + FesodSheet.write(file, ConverterData.class).sheet().doWrite(writeData); + + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, ConverterData.class, listener).sheet().doRead(); + + // Then + assertThat(listener.getData()).hasSize(1).first().satisfies(data -> { + assertThat(data.getDate()).isEqualTo(TestUtil.TEST_DATE); + assertThat(data.getBooleanData()).isTrue(); + assertThat(data.getString()).isEqualTo("测试"); + }); + } + } + + // ==================== Helper Methods ==================== + + /** + * Creates test data for converter write operations. + * Note: CellData is excluded to avoid StackOverflow issues with WriteCellData's internal + * circular references during hashCode/equals operations. + * + * @return list of ConverterData objects + */ + private List createConverterWriteData() { + List list = new ArrayList<>(); + ConverterData data = new ConverterData(); + + // Date/Time types + data.setDate(TestUtil.TEST_DATE); + data.setLocalDate(TestUtil.TEST_LOCAL_DATE); + data.setLocalDateTime(TestUtil.TEST_LOCAL_DATE_TIME); + + // Boolean + data.setBooleanData(Boolean.TRUE); + + // Big number types + data.setBigDecimal(BigDecimal.ONE); + data.setBigInteger(BigInteger.ONE); + + // Integer types + data.setLongData(1L); + data.setIntegerData(1); + data.setShortData((short) 1); + data.setByteData((byte) 1); + + // Floating point types + data.setDoubleData(1.0); + data.setFloatData(1.0f); + + // String + data.setString("测试"); + + // Note: CellData is intentionally NOT set here to avoid StackOverflow + // The cellData field has circular references in WriteCellData that cause + // issues during AssertJ's recursive comparison. See ConverterData for details. + + list.add(data); + return list; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/CustomConverterIntegrationTest.java b/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/CustomConverterIntegrationTest.java new file mode 100644 index 000000000..7a0b53b64 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/integration/converter/CustomConverterIntegrationTest.java @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.integration.converter; + +import static org.assertj.core.api.Assertions.assertThat; +import java.io.File; +import java.sql.Timestamp; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.fesod.sheet.ExcelWriter; +import org.apache.fesod.sheet.FesodSheet; +import org.apache.fesod.sheet.converter.CustomConverterWriteData; +import org.apache.fesod.sheet.converter.TimestampNumberConverter; +import org.apache.fesod.sheet.converter.TimestampStringConverter; +import org.apache.fesod.sheet.converters.Converter; +import org.apache.fesod.sheet.converters.ConverterKeyBuild; +import org.apache.fesod.sheet.testkit.base.AbstractExcelTest; +import org.apache.fesod.sheet.testkit.enums.ExcelFormat; +import org.apache.fesod.sheet.write.builder.ExcelWriterSheetBuilder; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Integration tests for custom converter registration and usage. + * + *

    Tests the ability to register and use custom converters like + * {@link TimestampStringConverter} and {@link TimestampNumberConverter}.

    + * + *

    Refactored from legacy {@code CustomConverterTest} to use parameterized tests.

    + * + * @see TimestampStringConverter + * @see TimestampNumberConverter + */ +@Tag("integration") +@DisplayName("Custom Converter Integration Tests") +class CustomConverterIntegrationTest extends AbstractExcelTest { + + // ==================== Converter Registration Tests ==================== + + @Nested + @DisplayName("Converter Registration") + class ConverterRegistration { + + @Test + @DisplayName("should register custom converters in converter map") + void shouldRegisterCustomConvertersInConverterMap() throws Exception { + // Given + File file = createTempFile("converter-map-test", ExcelFormat.CSV); + TimestampStringConverter timestampStringConverter = new TimestampStringConverter(); + TimestampNumberConverter timestampNumberConverter = new TimestampNumberConverter(); + + // When + ExcelWriter excelWriter = FesodSheet.write(file) + .registerConverter(timestampStringConverter) + .registerConverter(timestampNumberConverter) + .build(); + + Map> converterMap = + excelWriter.writeContext().currentWriteHolder().converterMap(); + + excelWriter.write( + createTimestampData(), + new ExcelWriterSheetBuilder().sheetNo(0).build()); + excelWriter.finish(); + + // Then + assertThat(converterMap) + .containsKey(ConverterKeyBuild.buildKey( + timestampStringConverter.supportJavaTypeKey(), + timestampStringConverter.supportExcelTypeKey())); + assertThat(converterMap) + .containsKey(ConverterKeyBuild.buildKey( + timestampNumberConverter.supportJavaTypeKey(), + timestampNumberConverter.supportExcelTypeKey())); + } + } + + // ==================== Custom Converter Write Tests ==================== + + @Nested + @DisplayName("Custom Converter Write Operations") + class CustomConverterWriteOperations { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should write data with custom converters to all formats") + void shouldWriteDataWithCustomConverters(ExcelFormat format) throws Exception { + // Given + File file = createTempFile("custom-converter-write", format); + List data = createTimestampData(); + + // When + FesodSheet.write(file) + .registerConverter(new TimestampNumberConverter()) + .registerConverter(new TimestampStringConverter()) + .sheet() + .doWrite(data); + + // Then + assertThat(file).exists(); + assertThat(file.length()).isGreaterThan(0); + } + } + + // ==================== Helper Methods ==================== + + /** + * Creates test data with timestamp values for custom converter testing. + * + * @return list of CustomConverterWriteData objects + */ + private List createTimestampData() { + List list = new ArrayList<>(); + CustomConverterWriteData writeData = new CustomConverterWriteData(); + writeData.setTimestampStringData(Timestamp.valueOf("2020-01-01 01:00:00")); + writeData.setTimestampNumberData(Timestamp.valueOf("2020-12-01 12:12:12")); + list.add(writeData); + return list; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/integration/read/SimpleReadWriteTest.java b/fesod/src/test/java/org/apache/fesod/sheet/integration/read/SimpleReadWriteTest.java new file mode 100644 index 000000000..d70069cb4 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/integration/read/SimpleReadWriteTest.java @@ -0,0 +1,281 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.integration.read; + +import static org.assertj.core.api.Assertions.assertThat; +import java.io.File; +import java.io.FileInputStream; +import java.io.FileOutputStream; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import org.apache.fesod.sheet.FesodSheet; +import org.apache.fesod.sheet.read.listener.PageReadListener; +import org.apache.fesod.sheet.simple.SimpleData; +import org.apache.fesod.sheet.testkit.base.AbstractExcelTest; +import org.apache.fesod.sheet.testkit.enums.ExcelFormat; +import org.apache.fesod.sheet.testkit.listeners.CollectingReadListener; +import org.apache.fesod.sheet.util.TestFileUtil; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.MethodSource; + +/** + * Tests for simple read/write operations across all Excel formats. + * + *

    This test class validates basic Excel read/write functionality including:

    + *
      + *
    • File-based read/write operations
      • + *
    • Stream-based read/write operations
      • + *
    • Synchronous reading
      • + *
    • Sheet name/number navigation
      • + *
    • Paginated reading
      • + *
    + * + *

    Refactored from legacy {@code SimpleDataTest} to use parameterized tests + * with format providers from {@link AbstractExcelTest}.

    + * + * @see SimpleData + * @see AbstractExcelTest + */ +@Tag("unit") +@DisplayName("Simple Read/Write Tests") +class SimpleReadWriteTest extends AbstractExcelTest { + + private static final int TEST_DATA_SIZE = 10; + + // ==================== Basic Read/Write Tests ==================== + + @Nested + @DisplayName("File-based Read/Write") + class FileBasedReadWrite { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should write and read data correctly using File") + void shouldWriteAndReadUsingFile(ExcelFormat format) { + // Given + File file = createTempFile("simple", format); + List expected = createTestData(); + + // When + writeData(file, SimpleData.class, expected); + List actual = readData(file, SimpleData.class); + + // Then + assertThat(actual) + .hasSize(TEST_DATA_SIZE) + .first() + .extracting(SimpleData::getName) + .isEqualTo("姓名0"); + } + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should write and read data correctly using InputStream/OutputStream") + void shouldWriteAndReadUsingStreams(ExcelFormat format) throws Exception { + // Given + File file = createTempFile("simple-stream", format); + List expected = createTestData(); + + // When - write using OutputStream + FesodSheet.write(new FileOutputStream(file), SimpleData.class) + .excelType(format.getExcelType()) + .sheet() + .doWrite(expected); + + // Read using InputStream + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(new FileInputStream(file), SimpleData.class, listener) + .sheet() + .doRead(); + + // Then + assertThat(listener.getData()) + .hasSize(TEST_DATA_SIZE) + .first() + .extracting(SimpleData::getName) + .isEqualTo("姓名0"); + } + } + + // ==================== Synchronous Read Tests ==================== + + @Nested + @DisplayName("Synchronous Reading") + class SynchronousReading { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should read all data synchronously") + void shouldReadSynchronously(ExcelFormat format) { + // Given + File file = createTempFile("sync-read", format); + writeData(file, SimpleData.class, createTestData()); + + // When + List result = + FesodSheet.read(file).head(SimpleData.class).sheet().doReadSync(); + + // Then + assertThat(result) + .hasSize(TEST_DATA_SIZE) + .first() + .isInstanceOf(SimpleData.class) + .extracting(obj -> ((SimpleData) obj).getName()) + .isEqualTo("姓名0"); + } + } + + // ==================== Sheet Navigation Tests ==================== + + @Nested + @DisplayName("Sheet Navigation") + class SheetNavigation { + + @Test + @DisplayName("should read sheet by name (XLSX only)") + void shouldReadSheetByName() { + // Given - use existing test resource file + File file = TestFileUtil.readFile("simple" + File.separator + "simple07.xlsx"); + + // When + List> result = + FesodSheet.read(file).sheet("simple").doReadSync(); + + // Then + assertThat(result).hasSize(1); + } + + @Test + @DisplayName("should read sheet by index (XLSX only)") + void shouldReadSheetByIndex() { + // Given + File file = TestFileUtil.readFile("simple" + File.separator + "simple07.xlsx"); + + // When - sheetNo is 0-based + List> result = FesodSheet.read(file).sheet(1).doReadSync(); + + // Then + assertThat(result).hasSize(1); + } + } + + // ==================== Paginated Read Tests ==================== + + @Nested + @DisplayName("Paginated Reading") + class PaginatedReading { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should read data in pages using PageReadListener") + void shouldReadInPages(ExcelFormat format) { + // Given + File file = createTempFile("page-read", format); + int pageSize = 5; + List> pages = new ArrayList<>(); + + writeData(file, SimpleData.class, createTestData()); + + // When + FesodSheet.read( + file, + SimpleData.class, + new PageReadListener( + pageData -> pages.add(new ArrayList<>(pageData)), pageSize)) + .sheet() + .doRead(); + + // Then + assertThat(pages) + .hasSize(2) // 10 items / 5 per page = 2 pages + .allSatisfy(page -> assertThat(page).hasSize(pageSize)); + } + } + + // ==================== Head Map Tests ==================== + + @Nested + @DisplayName("Header Mapping") + class HeaderMapping { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should correctly parse header row") + void shouldParseHeaderRow(ExcelFormat format) { + // Given + File file = createTempFile("header-test", format); + writeData(file, SimpleData.class, createTestData()); + + // When + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, SimpleData.class, listener).sheet().doRead(); + + // Then + assertThat(listener.getHeadMap()).isNotNull().containsEntry(0, "姓名"); + } + } + + // ==================== Roundtrip Tests ==================== + + @Nested + @DisplayName("Roundtrip Validation") + class RoundtripValidation { + + @ParameterizedTest(name = "Format: {0}") + @MethodSource("org.apache.fesod.sheet.testkit.base.AbstractExcelTest#allFormats") + @DisplayName("should preserve data through write-read cycle") + void shouldPreserveDataThroughRoundtrip(ExcelFormat format) { + // Given + File file = createTempFile("roundtrip", format); + List expected = createTestData(); + + // When + List actual = roundTrip(file, SimpleData.class, expected); + + // Then + assertThat(actual) + .hasSize(expected.size()) + .usingRecursiveFieldByFieldElementComparator() + .containsExactlyElementsOf(expected); + } + } + + // ==================== Helper Methods ==================== + + /** + * Creates test data with the specified number of rows. + * + * @return list of SimpleData objects + */ + private List createTestData() { + List list = new ArrayList<>(); + for (int i = 0; i < TEST_DATA_SIZE; i++) { + SimpleData simpleData = new SimpleData(); + simpleData.setName("姓名" + i); + list.add(simpleData); + } + return list; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/model/ComplexData.java b/fesod/src/test/java/org/apache/fesod/sheet/model/ComplexData.java new file mode 100644 index 000000000..034e5fb7c --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/model/ComplexData.java @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.model; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.Date; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import org.apache.fesod.sheet.annotation.ExcelProperty; + +/** + * Complex data model for testing various data type conversions. + * Consolidated from converter tests. + */ +@Getter +@Setter +@EqualsAndHashCode +public class ComplexData { + @ExcelProperty("日期") + private Date date; + + @ExcelProperty("本地日期") + private LocalDate localDate; + + @ExcelProperty("本地日期时间") + private LocalDateTime localDateTime; + + @ExcelProperty("布尔") + private Boolean booleanData; + + @ExcelProperty("大数") + private BigDecimal bigDecimal; + + @ExcelProperty("大整数") + private BigInteger bigInteger; + + @ExcelProperty("长整型") + private long longData; + + @ExcelProperty("整型") + private Integer integerData; + + @ExcelProperty("短整型") + private Short shortData; + + @ExcelProperty("字节型") + private Byte byteData; + + @ExcelProperty("双精度浮点型") + private double doubleData; + + @ExcelProperty("浮点型") + private Float floatData; + + @ExcelProperty("字符串") + private String string; + + public ComplexData() {} + + public ComplexData(String string, Date date, Double doubleData, Boolean booleanData) { + this.string = string; + this.date = date; + this.doubleData = doubleData; + this.booleanData = booleanData; + } + + @Override + public String toString() { + return "ComplexData{" + "date=" + + date + ", localDate=" + + localDate + ", localDateTime=" + + localDateTime + ", booleanData=" + + booleanData + ", bigDecimal=" + + bigDecimal + ", bigInteger=" + + bigInteger + ", longData=" + + longData + ", integerData=" + + integerData + ", shortData=" + + shortData + ", byteData=" + + byteData + ", doubleData=" + + doubleData + ", floatData=" + + floatData + ", string='" + + string + '\'' + '}'; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/model/ConverterData.java b/fesod/src/test/java/org/apache/fesod/sheet/model/ConverterData.java new file mode 100644 index 000000000..513c65758 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/model/ConverterData.java @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.model; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.Date; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import org.apache.fesod.sheet.annotation.ExcelProperty; +import org.apache.fesod.sheet.metadata.data.CellData; +import org.apache.fesod.sheet.metadata.data.ReadCellData; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.apache.fesod.sheet.util.TestUtil; + +/** + * Unified data model for converter tests. + * Consolidates the previous ConverterReadData and ConverterWriteData classes. + * + *

    This class uses a generic CellData type to support both read and write operations. + * For write operations, use {@link WriteCellData}; for read operations, the framework + * will populate {@link ReadCellData}.

    + * + * @see org.apache.fesod.sheet.converter.ConverterReadData (deprecated) + * @see org.apache.fesod.sheet.converter.ConverterWriteData (deprecated) + */ +@Getter +@Setter +@EqualsAndHashCode(exclude = {"cellData"}) // Exclude cellData to avoid StackOverflow in hashCode +@ToString(exclude = {"cellData"}) +public class ConverterData { + + @ExcelProperty("日期") + private Date date; + + @ExcelProperty("本地日期") + private LocalDate localDate; + + @ExcelProperty("本地日期时间") + private LocalDateTime localDateTime; + + @ExcelProperty("布尔") + private Boolean booleanData; + + @ExcelProperty("大数") + private BigDecimal bigDecimal; + + @ExcelProperty("大整数") + private BigInteger bigInteger; + + @ExcelProperty("长整型") + private Long longData; + + @ExcelProperty("整型") + private Integer integerData; + + @ExcelProperty("短整型") + private Short shortData; + + @ExcelProperty("字节型") + private Byte byteData; + + @ExcelProperty("双精度浮点型") + private Double doubleData; + + @ExcelProperty("浮点型") + private Float floatData; + + @ExcelProperty("字符串") + private String string; + + @ExcelProperty("自定义") + private CellData cellData; + + /** + * Default constructor. + */ + public ConverterData() {} + + /** + * Creates a ConverterData instance with all standard test values. + * Useful for write tests. + * + * @return a fully populated ConverterData instance + */ + public static ConverterData createTestData() { + ConverterData data = new ConverterData(); + data.setDate(TestUtil.TEST_DATE); + data.setLocalDate(TestUtil.TEST_LOCAL_DATE); + data.setLocalDateTime(TestUtil.TEST_LOCAL_DATE_TIME); + data.setBooleanData(Boolean.TRUE); + data.setBigDecimal(BigDecimal.ONE); + data.setBigInteger(BigInteger.ONE); + data.setLongData(1L); + data.setIntegerData(1); + data.setShortData((short) 1); + data.setByteData((byte) 1); + data.setDoubleData(1.0); + data.setFloatData(1.0f); + data.setString("测试"); + data.setCellData(new WriteCellData<>("自定义")); + return data; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/model/ImageData.java b/fesod/src/test/java/org/apache/fesod/sheet/model/ImageData.java new file mode 100644 index 000000000..98f0b6869 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/model/ImageData.java @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.model; + +import java.io.File; +import java.io.InputStream; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import org.apache.fesod.sheet.annotation.ExcelProperty; +import org.apache.fesod.sheet.annotation.write.style.ColumnWidth; +import org.apache.fesod.sheet.annotation.write.style.ContentRowHeight; +import org.apache.fesod.sheet.converters.string.StringImageConverter; + +/** + * Data model for image write tests. + * Images can be specified as File, InputStream, String (path), or byte array. + * + *

    Note: Image data can only be written to Excel formats (XLSX, XLS), + * not CSV. The InputStream should be closed after writing.

    + * + * @see org.apache.fesod.sheet.converter.ImageData (deprecated) + */ +@Getter +@Setter +@EqualsAndHashCode(exclude = {"inputStream"}) // Exclude InputStream to avoid hashCode issues +@ContentRowHeight(500) +@ColumnWidth(500 / 8) +public class ImageData { + + /** + * Image as a File reference. + */ + private File file; + + /** + * Image as an InputStream. + * Note: The caller is responsible for closing this stream. + */ + private InputStream inputStream; + + /** + * Image file path as a String. + * Uses StringImageConverter for conversion. + */ + @ExcelProperty(converter = StringImageConverter.class) + private String string; + + /** + * Image as raw byte array. + */ + private byte[] byteArray; +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/model/SimpleData.java b/fesod/src/test/java/org/apache/fesod/sheet/model/SimpleData.java new file mode 100644 index 000000000..4cd05f807 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/model/SimpleData.java @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.model; + +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import org.apache.fesod.sheet.annotation.ExcelProperty; + +/** + * Simple data model for basic read/write operations. + * Consolidated from various feature-specific packages. + */ +@Getter +@Setter +@EqualsAndHashCode +public class SimpleData { + @ExcelProperty("姓名") + private String name; + + @ExcelProperty("数字") + private Double number; + + @ExcelProperty("整数") + private Integer integer; + + public SimpleData() {} + + public SimpleData(String name) { + this.name = name; + } + + public SimpleData(String name, Double number) { + this.name = name; + this.number = number; + } + + public SimpleData(String name, Double number, Integer integer) { + this.name = name; + this.number = number; + this.integer = integer; + } + + @Override + public String toString() { + return "SimpleData{" + "name='" + name + '\'' + ", number=" + number + ", integer=" + integer + '}'; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/assertions/ExcelAssertions.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/assertions/ExcelAssertions.java new file mode 100644 index 000000000..aa1668393 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/assertions/ExcelAssertions.java @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.assertions; + +import java.io.File; +import java.io.IOException; +import org.apache.poi.ss.usermodel.*; +import org.junit.jupiter.api.Assertions; + +/** + * Main entry point for Excel-specific assertions. + * Provides a fluent API for testing Excel file contents. + * + *

    Usage:

    + * 
    {@code
+ * ExcelAssertions.assertThat(file)
+ *     .sheet(0)
+ *     .hasRowCount(10)
+ *     .cell(0, 0)
+ *     .hasStringValue("Header");
+ * }
    + */ +public class ExcelAssertions { + + /** + * Entry point for workbook assertions from a file. + */ + public static WorkbookAssert assertThat(File file) { + try { + Workbook workbook = WorkbookFactory.create(file); + return new WorkbookAssert(workbook, true); + } catch (IOException e) { + throw new AssertionError("Failed to open workbook: " + file, e); + } + } + + /** + * Entry point for workbook assertions from a Workbook object. + */ + public static WorkbookAssert assertThat(Workbook workbook) { + return new WorkbookAssert(workbook, false); + } + + /** + * Workbook-level assertions. + */ + public static class WorkbookAssert implements AutoCloseable { + protected final Workbook workbook; + private final boolean shouldClose; + + public WorkbookAssert(Workbook workbook, boolean shouldClose) { + this.workbook = workbook; + this.shouldClose = shouldClose; + } + + public WorkbookAssert hasSheetCount(int expected) { + Assertions.assertEquals( + expected, + workbook.getNumberOfSheets(), + "Expected sheet count " + expected + " but was " + workbook.getNumberOfSheets()); + return this; + } + + public WorkbookAssert hasSheetNamed(String name) { + Sheet sheet = workbook.getSheet(name); + Assertions.assertNotNull(sheet, "Sheet named '" + name + "' not found"); + return this; + } + + public SheetAssert sheet(int index) { + Sheet sheet = workbook.getSheetAt(index); + Assertions.assertNotNull(sheet, "Sheet at index " + index + " is null"); + return new SheetAssert(sheet, workbook); + } + + public SheetAssert sheet(String name) { + Sheet sheet = workbook.getSheet(name); + Assertions.assertNotNull(sheet, "Sheet named '" + name + "' not found"); + return new SheetAssert(sheet, workbook); + } + + @Override + public void close() throws Exception { + if (shouldClose && workbook != null) { + workbook.close(); + } + } + } + + /** + * Sheet-level assertions. + */ + public static class SheetAssert { + protected final Sheet sheet; + protected final Workbook workbook; + + public SheetAssert(Sheet sheet, Workbook workbook) { + this.sheet = sheet; + this.workbook = workbook; + } + + public SheetAssert hasRowCount(int expected) { + int actual = sheet.getPhysicalNumberOfRows(); + Assertions.assertEquals(expected, actual, "Expected row count " + expected + " but was " + actual); + return this; + } + + public SheetAssert hasColumnCount(int expected, int rowIndex) { + Row row = sheet.getRow(rowIndex); + if (row == null) { + Assertions.fail("Row at index " + rowIndex + " does not exist"); + } + int actual = row.getPhysicalNumberOfCells(); + Assertions.assertEquals( + expected, + actual, + "Expected column count " + expected + " at row " + rowIndex + " but was " + actual); + return this; + } + + public SheetAssert hasColumnWidth(int col, int expectedWidth) { + int actualWidth = sheet.getColumnWidth(col); + Assertions.assertEquals( + expectedWidth, + actualWidth, + "Expected column width " + expectedWidth + " for column " + col + " but was " + actualWidth); + return this; + } + + public CellAssert cell(int row, int col) { + Row sheetRow = sheet.getRow(row); + if (sheetRow == null) { + Assertions.fail("Row at index " + row + " does not exist"); + } + Cell cell = sheetRow.getCell(col); + if (cell == null) { + Assertions.fail("Cell at row " + row + ", column " + col + " does not exist"); + } + return new CellAssert(cell, workbook); + } + + public SheetAssert hasCellAt(int row, int col) { + Row sheetRow = sheet.getRow(row); + Assertions.assertNotNull(sheetRow, "Row at index " + row + " does not exist"); + Cell cell = sheetRow.getCell(col); + Assertions.assertNotNull(cell, "Cell at row " + row + ", column " + col + " does not exist"); + return this; + } + } + + /** + * Cell-level assertions. + */ + public static class CellAssert { + private final Cell cell; + private final Workbook workbook; + + public CellAssert(Cell cell, Workbook workbook) { + this.cell = cell; + this.workbook = workbook; + } + + public CellAssert hasStringValue(String expected) { + String actual = getCellValueAsString(); + Assertions.assertEquals( + expected, actual, "Expected cell value '" + expected + "' but was '" + actual + "'"); + return this; + } + + public CellAssert hasNumericValue(double expected) { + Assertions.assertEquals( + CellType.NUMERIC, cell.getCellType(), "Cell is not numeric, got: " + cell.getCellType()); + double actual = cell.getNumericCellValue(); + Assertions.assertEquals( + expected, actual, 0.001, "Expected numeric value " + expected + " but was " + actual); + return this; + } + + public CellAssert hasBooleanValue(boolean expected) { + Assertions.assertEquals( + CellType.BOOLEAN, cell.getCellType(), "Cell is not boolean, got: " + cell.getCellType()); + boolean actual = cell.getBooleanCellValue(); + Assertions.assertEquals(expected, actual, "Expected boolean value " + expected + " but was " + actual); + return this; + } + + public CellAssert hasFormulaValue() { + Assertions.assertEquals( + CellType.FORMULA, cell.getCellType(), "Cell is not a formula, got: " + cell.getCellType()); + return this; + } + + public CellAssert isEmpty() { + CellType type = cell.getCellType(); + Assertions.assertTrue( + type == CellType.BLANK + || (type == CellType.STRING + && cell.getStringCellValue().trim().isEmpty()), + "Expected cell to be empty, but was: " + getCellValueAsString()); + return this; + } + + public CellAssert hasType(CellType expected) { + CellType actual = cell.getCellType(); + Assertions.assertEquals(expected, actual, "Expected cell type " + expected + " but was " + actual); + return this; + } + + public CellAssert hasFontColor(short expectedColorIndex) { + Font font = workbook.getFontAt(cell.getCellStyle().getFontIndex()); + Assertions.assertEquals( + expectedColorIndex, + font.getColor(), + "Expected font color index " + expectedColorIndex + " but was " + font.getColor()); + return this; + } + + public CellAssert hasFillColor(short expectedColorIndex) { + Assertions.assertEquals( + expectedColorIndex, + cell.getCellStyle().getFillForegroundColor(), + "Expected fill color index " + expectedColorIndex + " but was " + + cell.getCellStyle().getFillForegroundColor()); + return this; + } + + private String getCellValueAsString() { + switch (cell.getCellType()) { + case STRING: + return cell.getStringCellValue(); + case NUMERIC: + if (DateUtil.isCellDateFormatted(cell)) { + return cell.getDateCellValue().toString(); + } else { + double value = cell.getNumericCellValue(); + // Convert to integer if it's a whole number + if (value == Math.floor(value)) { + return String.valueOf((long) value); + } else { + return String.valueOf(value); + } + } + case BOOLEAN: + return String.valueOf(cell.getBooleanCellValue()); + case FORMULA: + return cell.getCellFormula(); + case BLANK: + return ""; + default: + return cell.getStringCellValue(); + } + } + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/base/AbstractExcelTest.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/base/AbstractExcelTest.java new file mode 100644 index 000000000..efed92d67 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/base/AbstractExcelTest.java @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.base; + +import java.io.File; +import java.nio.file.Path; +import java.util.List; +import java.util.stream.Stream; +import org.apache.fesod.sheet.FesodSheet; +import org.apache.fesod.sheet.testkit.enums.ExcelFormat; +import org.apache.fesod.sheet.testkit.listeners.CollectingReadListener; +import org.junit.jupiter.api.io.TempDir; +import org.junit.jupiter.params.provider.Arguments; + +/** + * Abstract base class for Excel tests providing common infrastructure. + * + *

    Features:

    + *
      + *
    • Automatic temp directory management via JUnit 5 @TempDir
      • + *
    • Format provider methods for parameterized tests
      • + *
    • Common read/write operations
      • + *
    • Format-aware file creation
      • + *
    + * + *

    Usage:

    + * 
    {@code
+ * class MyTest extends AbstractExcelTest {
+ *     @ParameterizedTest
+ *     @MethodSource("allFormats")
+ *     void shouldReadAndWrite(ExcelFormat format) {
+ *         File file = createTempFile("test", format);
+ *         // test logic...
+ *     }
+ * }
+ * }
    + */ +public abstract class AbstractExcelTest { + + @TempDir + protected Path tempDir; + + // ==================== Format Providers ==================== + + /** + * Provides all supported formats: XLSX, XLS, CSV + */ + protected static Stream allFormats() { + return Stream.of(Arguments.of(ExcelFormat.XLSX), Arguments.of(ExcelFormat.XLS), Arguments.of(ExcelFormat.CSV)); + } + + /** + * Provides Excel-only formats: XLSX, XLS (excludes CSV) + */ + protected static Stream excelFormats() { + return Stream.of(Arguments.of(ExcelFormat.XLSX), Arguments.of(ExcelFormat.XLS)); + } + + /** + * Provides formats that support styling + */ + protected static Stream styledFormats() { + return Stream.of(ExcelFormat.values()) + .filter(ExcelFormat::supportsStyle) + .map(Arguments::of); + } + + /** + * Provides only XLSX format (for streaming tests) + */ + protected static Stream xlsxOnly() { + return Stream.of(Arguments.of(ExcelFormat.XLSX)); + } + + // ==================== File Operations ==================== + + /** + * Creates a temp file with the given name and format extension. + * @param baseName base file name (without extension) + * @param format the Excel format + * @return the created file + */ + protected File createTempFile(String baseName, ExcelFormat format) { + return tempDir.resolve(baseName + format.getExtension()).toFile(); + } + + /** + * Creates a temp file with unique name based on test method. + */ + protected File createTempFile(ExcelFormat format, org.junit.jupiter.api.TestInfo testInfo) { + String methodName = testInfo.getTestMethod().map(m -> m.getName()).orElse("test"); + return createTempFile(methodName, format); + } + + // ==================== Common Operations ==================== + + /** + * Writes data to file using FesodSheet. + */ + protected void writeData(File file, Class clazz, List data) { + FesodSheet.write(file, clazz).sheet().doWrite(data); + } + + /** + * Writes data to a named sheet. + */ + protected void writeData(File file, Class clazz, List data, String sheetName) { + FesodSheet.write(file, clazz).sheet(sheetName).doWrite(data); + } + + /** + * Reads data from file synchronously. + */ + protected List readData(File file, Class clazz) { + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, clazz, listener).sheet().doRead(); + return listener.getData(); + } + + /** + * Reads data from a named sheet. + */ + protected List readData(File file, Class clazz, String sheetName) { + CollectingReadListener listener = new CollectingReadListener<>(); + FesodSheet.read(file, clazz, listener).sheet(sheetName).doRead(); + return listener.getData(); + } + + /** + * Performs a write-read roundtrip and returns the read data. + */ + protected List roundTrip(File file, Class clazz, List data) { + writeData(file, clazz, data); + return readData(file, clazz); + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/RandomDataGenerator.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/RandomDataGenerator.java new file mode 100644 index 000000000..820ba6413 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/RandomDataGenerator.java @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.data; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.Date; +import java.util.Random; +import org.apache.fesod.sheet.model.ComplexData; +import org.apache.fesod.sheet.model.SimpleData; + +/** + * Generates random test data for fuzz testing and edge case validation. + * Helps identify issues with unexpected input values. + */ +public class RandomDataGenerator { + + private static final Random RANDOM = new Random(); + private static final String[] NAMES = { + "张三", "李四", "王五", "赵六", "钱七", "孙八", "周九", "吴十", + "测试A", "测试B", "测试C", "验证", "校验", "数据", "样本", "示例" + }; + + /** + * Generates a random string. + */ + public static String randomString() { + int length = RANDOM.nextInt(20) + 1; // 1-20 characters + StringBuilder sb = new StringBuilder(); + for (int i = 0; i < length; i++) { + char c = (char) (RANDOM.nextInt(26) + 'a'); + sb.append(c); + } + return sb.toString(); + } + + /** + * Generates a random Chinese name. + */ + public static String randomChineseName() { + return NAMES[RANDOM.nextInt(NAMES.length)] + RANDOM.nextInt(100); + } + + /** + * Generates a random number. + */ + public static Double randomDouble() { + return RANDOM.nextDouble() * 10000 - 5000; // -5000 to 5000 + } + + /** + * Generates a random integer. + */ + public static Integer randomInteger() { + return RANDOM.nextInt(10000) - 5000; // -5000 to 4999 + } + + /** + * Generates a random date in the last 10 years. + */ + public static Date randomDate() { + long start = System.currentTimeMillis() - (365L * 10 * 24 * 60 * 60 * 1000); // 10 years ago + long end = System.currentTimeMillis(); + long randomTime = start + (long) (RANDOM.nextDouble() * (end - start)); + return new Date(randomTime); + } + + /** + * Generates random SimpleData. + */ + public static SimpleData randomSimpleData() { + return new SimpleData(randomChineseName(), randomDouble(), randomInteger()); + } + + /** + * Generates random ComplexData. + */ + public static ComplexData randomComplexData() { + ComplexData data = new ComplexData(); + data.setString(randomString()); + data.setDate(randomDate()); + data.setDoubleData(randomDouble()); + data.setBooleanData(RANDOM.nextBoolean()); + data.setBigDecimal(BigDecimal.valueOf(randomDouble())); + data.setBigInteger(BigInteger.valueOf(randomInteger())); + data.setLongData(randomInteger().longValue()); + data.setIntegerData(randomInteger()); + data.setShortData(randomInteger().shortValue()); + data.setByteData(randomInteger().byteValue()); + data.setFloatData(randomDouble().floatValue()); + data.setLocalDate(LocalDate.now().minusDays(RANDOM.nextInt(365 * 5))); // Last 5 years + data.setLocalDateTime(LocalDateTime.now().minusDays(RANDOM.nextInt(365 * 5))); + return data; + } + + /** + * Generates multiple random SimpleData instances. + */ + public static SimpleData[] randomSimpleDataArray(int count) { + SimpleData[] array = new SimpleData[count]; + for (int i = 0; i < count; i++) { + array[i] = randomSimpleData(); + } + return array; + } + + /** + * Generates multiple random ComplexData instances. + */ + public static ComplexData[] randomComplexDataArray(int count) { + ComplexData[] array = new ComplexData[count]; + for (int i = 0; i < count; i++) { + array[i] = randomComplexData(); + } + return array; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataBuilder.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataBuilder.java new file mode 100644 index 000000000..54d9a566d --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataBuilder.java @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.data; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.Date; +import org.apache.fesod.sheet.model.ComplexData; +import org.apache.fesod.sheet.model.SimpleData; + +/** + * Builder pattern for creating complex test data with fluent API. + * Useful for creating test data with specific field values without + * having to set all fields manually. + */ +public class TestDataBuilder { + + // ==================== SimpleData Builder ==================== + + public static SimpleDataBuilder simpleData() { + return new SimpleDataBuilder(); + } + + public static class SimpleDataBuilder { + private String name = "默认姓名"; + private Double number = 0.0; + private Integer integer = 0; + + public SimpleDataBuilder withName(String name) { + this.name = name; + return this; + } + + public SimpleDataBuilder withNumber(Double number) { + this.number = number; + return this; + } + + public SimpleDataBuilder withInteger(Integer integer) { + this.integer = integer; + return this; + } + + public SimpleData build() { + SimpleData data = new SimpleData(); + data.setName(name); + data.setNumber(number); + data.setInteger(integer); + return data; + } + } + + // ==================== ComplexData Builder ==================== + + public static ComplexDataBuilder complexData() { + return new ComplexDataBuilder(); + } + + public static class ComplexDataBuilder { + private String string = "默认字符串"; + private Date date = new Date(); + private LocalDate localDate = LocalDate.now(); + private LocalDateTime localDateTime = LocalDateTime.now(); + private Boolean booleanData = true; + private BigDecimal bigDecimal = BigDecimal.ZERO; + private BigInteger bigInteger = BigInteger.ZERO; + private long longData = 0L; + private Integer integerData = 0; + private Short shortData = (short) 0; + private Byte byteData = (byte) 0; + private double doubleData = 0.0; + private Float floatData = 0.0f; + + public ComplexDataBuilder withString(String string) { + this.string = string; + return this; + } + + public ComplexDataBuilder withDate(Date date) { + this.date = date; + return this; + } + + public ComplexDataBuilder withLocalDate(LocalDate localDate) { + this.localDate = localDate; + return this; + } + + public ComplexDataBuilder withLocalDateTime(LocalDateTime localDateTime) { + this.localDateTime = localDateTime; + return this; + } + + public ComplexDataBuilder withBoolean(Boolean booleanData) { + this.booleanData = booleanData; + return this; + } + + public ComplexDataBuilder withBigDecimal(BigDecimal bigDecimal) { + this.bigDecimal = bigDecimal; + return this; + } + + public ComplexDataBuilder withBigInteger(BigInteger bigInteger) { + this.bigInteger = bigInteger; + return this; + } + + public ComplexDataBuilder withLong(long longData) { + this.longData = longData; + return this; + } + + public ComplexDataBuilder withInteger(Integer integerData) { + this.integerData = integerData; + return this; + } + + public ComplexDataBuilder withShort(Short shortData) { + this.shortData = shortData; + return this; + } + + public ComplexDataBuilder withByte(Byte byteData) { + this.byteData = byteData; + return this; + } + + public ComplexDataBuilder withDouble(double doubleData) { + this.doubleData = doubleData; + return this; + } + + public ComplexDataBuilder withFloat(Float floatData) { + this.floatData = floatData; + return this; + } + + public ComplexData build() { + ComplexData data = new ComplexData(); + data.setString(string); + data.setDate(date); + data.setLocalDate(localDate); + data.setLocalDateTime(localDateTime); + data.setBooleanData(booleanData); + data.setBigDecimal(bigDecimal); + data.setBigInteger(bigInteger); + data.setLongData(longData); + data.setIntegerData(integerData); + data.setShortData(shortData); + data.setByteData(byteData); + data.setDoubleData(doubleData); + data.setFloatData(floatData); + return data; + } + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataFactory.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataFactory.java new file mode 100644 index 000000000..82427ae17 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/data/TestDataFactory.java @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.data; + +import java.math.BigDecimal; +import java.math.BigInteger; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.util.ArrayList; +import java.util.Date; +import java.util.List; +import java.util.Random; +import org.apache.fesod.sheet.model.ComplexData; +import org.apache.fesod.sheet.model.SimpleData; + +/** + * Static factory for creating test data instances. + * Provides consistent test data generation across all test classes. + */ +public class TestDataFactory { + + private static final Random RANDOM = new Random(); + + // ==================== SimpleData Factories ==================== + + /** + * Creates a single SimpleData instance with default values. + */ + public static SimpleData simpleData() { + return new SimpleData("测试数据", 100.0, 42); + } + + /** + * Creates a SimpleData instance with sequential name. + */ + public static SimpleData simpleData(int index) { + return new SimpleData("姓名" + index, (double) index, index); + } + + /** + * Creates a list of SimpleData instances. + */ + public static List simpleDataList(int count) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(simpleData(i)); + } + return list; + } + + /** + * Creates a list of SimpleData with sequential names and incrementing numbers. + */ + public static List simpleDataList(int count, String prefix) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(new SimpleData(prefix + i, (double) i, i)); + } + return list; + } + + // ==================== ComplexData Factories ==================== + + /** + * Creates a single ComplexData instance with default values. + */ + public static ComplexData complexData() { + ComplexData data = new ComplexData(); + data.setString("测试字符串"); + data.setDate(new Date()); + data.setDoubleData(123.45); + data.setBooleanData(true); + data.setBigDecimal(new BigDecimal("123.45")); + data.setBigInteger(BigInteger.valueOf(12345)); + data.setLongData(12345L); + data.setIntegerData(1234); + data.setShortData((short) 123); + data.setByteData((byte) 42); + data.setFloatData(12.34f); + data.setLocalDate(LocalDate.now()); + data.setLocalDateTime(LocalDateTime.now()); + return data; + } + + /** + * Creates a ComplexData instance with custom string. + */ + public static ComplexData complexData(String value) { + ComplexData data = complexData(); + data.setString(value); + return data; + } + + /** + * Creates a list of ComplexData instances. + */ + public static List complexDataList(int count) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(complexData("数据" + i)); + } + return list; + } + + /** + * Creates a list of ComplexData with the same values repeated. + */ + public static List complexDataList(int count, String prefix) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(complexData(prefix + i)); + } + return list; + } + + // ==================== Random Data Generation ==================== + + /** + * Creates a SimpleData with random values. + */ + public static SimpleData randomSimpleData() { + return new SimpleData("随机姓名" + RANDOM.nextInt(1000), RANDOM.nextDouble() * 1000, RANDOM.nextInt(100)); + } + + /** + * Creates a ComplexData with random values. + */ + public static ComplexData randomComplexData() { + ComplexData data = new ComplexData(); + data.setString("随机字符串" + RANDOM.nextInt(10000)); + data.setDate(new Date(System.currentTimeMillis() - RANDOM.nextInt(100000000))); + data.setDoubleData(RANDOM.nextDouble() * 10000); + data.setBooleanData(RANDOM.nextBoolean()); + data.setBigDecimal(new BigDecimal(String.valueOf(RANDOM.nextDouble() * 10000))); + data.setBigInteger(BigInteger.valueOf(RANDOM.nextInt(100000))); + data.setLongData(RANDOM.nextInt(100000)); + data.setIntegerData(RANDOM.nextInt(10000)); + data.setShortData((short) RANDOM.nextInt(1000)); + data.setByteData((byte) RANDOM.nextInt(100)); + data.setFloatData(RANDOM.nextFloat() * 1000); + data.setLocalDate(LocalDate.now().minusDays(RANDOM.nextInt(365))); + data.setLocalDateTime(LocalDateTime.now().minusDays(RANDOM.nextInt(365))); + return data; + } + + /** + * Creates a list of random SimpleData instances. + */ + public static List randomSimpleDataList(int count) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(randomSimpleData()); + } + return list; + } + + /** + * Creates a list of random ComplexData instances. + */ + public static List randomComplexDataList(int count) { + List list = new ArrayList<>(count); + for (int i = 0; i < count; i++) { + list.add(randomComplexData()); + } + return list; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/enums/ExcelFormat.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/enums/ExcelFormat.java new file mode 100644 index 000000000..f0ed8d191 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/enums/ExcelFormat.java @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.enums; + +import org.apache.fesod.sheet.support.ExcelTypeEnum; + +/** + * Test format enumeration with capability metadata. + * Enables format-aware parameterized testing. + */ +public enum ExcelFormat { + XLSX(".xlsx", ExcelTypeEnum.XLSX, true, true, true, true), + XLS(".xls", ExcelTypeEnum.XLS, true, true, true, false), + CSV(".csv", ExcelTypeEnum.CSV, false, false, false, false); + + private final String extension; + private final ExcelTypeEnum excelType; + private final boolean supportsStyle; + private final boolean supportsMerge; + private final boolean supportsFormula; + private final boolean supportsStreaming; + + ExcelFormat( + String extension, + ExcelTypeEnum excelType, + boolean supportsStyle, + boolean supportsMerge, + boolean supportsFormula, + boolean supportsStreaming) { + this.extension = extension; + this.excelType = excelType; + this.supportsStyle = supportsStyle; + this.supportsMerge = supportsMerge; + this.supportsFormula = supportsFormula; + this.supportsStreaming = supportsStreaming; + } + + // Getters... + public String getExtension() { + return extension; + } + + public ExcelTypeEnum getExcelType() { + return excelType; + } + + public boolean supportsStyle() { + return supportsStyle; + } + + public boolean supportsMerge() { + return supportsMerge; + } + + public boolean supportsFormula() { + return supportsFormula; + } + + public boolean supportsStreaming() { + return supportsStreaming; + } + + /** + * Check if this format supports a specific feature. + * @param feature the feature to check + * @return true if supported + */ + public boolean supports(FormatFeature feature) { + switch (feature) { + case STYLE: + return supportsStyle; + case MERGE: + return supportsMerge; + case FORMULA: + return supportsFormula; + case STREAMING: + return supportsStreaming; + case SHEET_NAME: + return this != CSV; + case MULTIPLE_SHEETS: + return this != CSV; + default: + return false; + } + } + + public enum FormatFeature { + STYLE, + MERGE, + FORMULA, + STREAMING, + SHEET_NAME, + MULTIPLE_SHEETS + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/listeners/CollectingReadListener.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/listeners/CollectingReadListener.java new file mode 100644 index 000000000..1257f3b39 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/listeners/CollectingReadListener.java @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.listeners; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.function.Consumer; +import org.apache.fesod.sheet.context.AnalysisContext; +import org.apache.fesod.sheet.event.AnalysisEventListener; + +/** + * A reusable read listener that collects data without performing assertions. + * Assertions should be done in the test method after reading completes. + * + *

    This follows the Single Responsibility Principle - the listener's job is + * only to collect data, not to validate it.

    + * + * @param the data type + */ +public class CollectingReadListener extends AnalysisEventListener { + + private final List data = new ArrayList<>(); + private final Consumer onInvoke; + private Map headMap; + private int invokeCount = 0; + + public CollectingReadListener() { + this(t -> {}); + } + + /** + * Creates a listener with a callback for each row. + * Useful for logging or tracking progress without assertions. + */ + public CollectingReadListener(Consumer onInvoke) { + this.onInvoke = onInvoke; + } + + @Override + public void invokeHeadMap(Map headMap, AnalysisContext context) { + this.headMap = headMap; + } + + @Override + public void invoke(T row, AnalysisContext context) { + onInvoke.accept(row); + data.add(row); + invokeCount++; + } + + @Override + public void doAfterAllAnalysed(AnalysisContext context) { + // Intentionally empty - assertions happen in test methods + } + + // ==================== Accessors ==================== + + public List getData() { + return Collections.unmodifiableList(data); + } + + public Map getHeadMap() { + return headMap != null ? Collections.unmodifiableMap(headMap) : null; + } + + public int size() { + return data.size(); + } + + public int getInvokeCount() { + return invokeCount; + } + + public T getFirst() { + return data.isEmpty() ? null : data.get(0); + } + + public T getLast() { + return data.isEmpty() ? null : data.get(data.size() - 1); + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/AssertionHelper.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/AssertionHelper.java new file mode 100644 index 000000000..3c7caafa6 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/AssertionHelper.java @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.util; + +import java.util.List; +import org.apache.fesod.sheet.model.SimpleData; +import org.junit.jupiter.api.Assertions; + +/** + * Common assertion patterns and utility methods for test assertions. + * Provides reusable assertion logic to reduce duplication in test methods. + */ +public class AssertionHelper { + + /** + * Asserts that two SimpleData objects are equal, considering only the specified fields. + */ + public static void assertSimpleDataEquals(SimpleData expected, SimpleData actual) { + if (expected == null && actual == null) { + return; + } + if (expected == null || actual == null) { + Assertions.fail("One of the SimpleData objects is null: expected=" + expected + ", actual=" + actual); + } + + Assertions.assertEquals(expected.getName(), actual.getName(), "SimpleData names do not match"); + Assertions.assertEquals(expected.getNumber(), actual.getNumber(), "SimpleData numbers do not match"); + Assertions.assertEquals(expected.getInteger(), actual.getInteger(), "SimpleData integers do not match"); + } + + /** + * Asserts that two lists of SimpleData objects are equal in content and order. + */ + public static void assertSimpleDataListEquals(List expected, List actual) { + Assertions.assertEquals(expected.size(), actual.size(), "List sizes do not match"); + + for (int i = 0; i < expected.size(); i++) { + assertSimpleDataEquals(expected.get(i), actual.get(i)); + } + } + + /** + * Asserts that a list of SimpleData objects has the expected count. + */ + public static void assertSimpleDataListSize(List actual, int expectedSize) { + Assertions.assertEquals( + expectedSize, actual.size(), "Expected list size " + expectedSize + " but was " + actual.size()); + } + + /** + * Asserts that the first element in a SimpleData list matches the expected values. + */ + public static void assertFirstSimpleData(List list, String expectedName, Double expectedNumber) { + Assertions.assertFalse(list.isEmpty(), "List is empty"); + SimpleData first = list.get(0); + Assertions.assertEquals(expectedName, first.getName(), "First element name mismatch"); + Assertions.assertEquals(expectedNumber, first.getNumber(), "First element number mismatch"); + } + + /** + * Asserts that the last element in a SimpleData list matches the expected values. + */ + public static void assertLastSimpleData(List list, String expectedName, Double expectedNumber) { + Assertions.assertFalse(list.isEmpty(), "List is empty"); + SimpleData last = list.get(list.size() - 1); + Assertions.assertEquals(expectedName, last.getName(), "Last element name mismatch"); + Assertions.assertEquals(expectedNumber, last.getNumber(), "Last element number mismatch"); + } + + /** + * Checks if a list contains a SimpleData with the specified name. + */ + public static boolean containsSimpleDataWithName(List list, String name) { + return list.stream().anyMatch(data -> name.equals(data.getName())); + } + + /** + * Asserts that a list contains a SimpleData with the specified name. + */ + public static void assertContainsSimpleDataWithName(List list, String name) { + boolean found = containsSimpleDataWithName(list, name); + Assertions.assertTrue(found, "List does not contain SimpleData with name: " + name); + } + + /** + * Generic assertion that checks if an exception message contains expected text. + */ + public static void assertExceptionMessageContains(Throwable exception, String expectedText) { + String message = exception.getMessage(); + Assertions.assertNotNull(message, "Exception message is null"); + Assertions.assertTrue( + message.contains(expectedText), + "Exception message '" + message + "' does not contain expected text: " + expectedText); + } + + /** + * Asserts that a value is within a specified range (inclusive). + */ + public static void assertInRange(double value, double min, double max) { + Assertions.assertTrue( + value >= min && value <= max, "Value " + value + " is not within range [" + min + ", " + max + "]"); + } + + /** + * Asserts that a value is within a specified range (inclusive). + */ + public static void assertInRange(int value, int min, int max) { + Assertions.assertTrue( + value >= min && value <= max, "Value " + value + " is not within range [" + min + ", " + max + "]"); + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/ExcelTestHelper.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/ExcelTestHelper.java new file mode 100644 index 000000000..496e97a7e --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/ExcelTestHelper.java @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.util; + +import java.util.ArrayList; +import java.util.List; +import org.apache.fesod.sheet.model.SimpleData; +import org.apache.poi.ss.usermodel.*; + +/** + * Utility class for Excel-specific test operations and inspections. + * Provides helper methods for inspecting workbook content and structure. + */ +public class ExcelTestHelper { + + /** + * Gets the total number of cells in a workbook across all sheets. + */ + public static int getTotalCellCount(Workbook workbook) { + int totalCells = 0; + for (int i = 0; i < workbook.getNumberOfSheets(); i++) { + Sheet sheet = workbook.getSheetAt(i); + for (Row row : sheet) { + totalCells += row.getPhysicalNumberOfCells(); + } + } + return totalCells; + } + + /** + * Gets the number of used rows in a sheet (rows that have at least one non-empty cell). + */ + public static int getUsedRowCount(Sheet sheet) { + int usedRows = 0; + for (Row row : sheet) { + if (row.getPhysicalNumberOfCells() > 0) { + usedRows++; + } + } + return usedRows; + } + + /** + * Checks if a workbook contains a sheet with the specified name. + */ + public static boolean hasSheetNamed(Workbook workbook, String sheetName) { + return workbook.getSheet(sheetName) != null; + } + + /** + * Gets the value of a cell as a string, handling different cell types. + */ + public static String getCellValueAsString(Cell cell) { + if (cell == null) { + return ""; + } + + switch (cell.getCellType()) { + case STRING: + return cell.getStringCellValue(); + case NUMERIC: + if (DateUtil.isCellDateFormatted(cell)) { + return cell.getDateCellValue().toString(); + } else { + double value = cell.getNumericCellValue(); + // Convert to integer if it's a whole number + if (value == Math.floor(value)) { + return String.valueOf((long) value); + } else { + return String.valueOf(value); + } + } + case BOOLEAN: + return String.valueOf(cell.getBooleanCellValue()); + case FORMULA: + return cell.getCellFormula(); + case BLANK: + return ""; + default: + return cell.getStringCellValue(); + } + } + + /** + * Gets the number of non-empty rows in a specific sheet. + */ + public static int getNonEmptyRowCount(Sheet sheet) { + int count = 0; + for (Row row : sheet) { + boolean hasNonEmptyCell = false; + for (Cell cell : row) { + if (!getCellValueAsString(cell).isEmpty()) { + hasNonEmptyCell = true; + break; + } + } + if (hasNonEmptyCell) { + count++; + } + } + return count; + } + + /** + * Reads data from a sheet into a list of SimpleData objects. + * Assumes the sheet has columns: name, number in that order. + */ + public static List readSimpleDataFromSheet(Sheet sheet) { + List list = new ArrayList<>(); + boolean firstRow = true; + + for (Row row : sheet) { + // Skip header row + if (firstRow) { + firstRow = false; + continue; + } + + SimpleData data = new SimpleData(); + + // Get the name (first column) + Cell nameCell = row.getCell(0); + if (nameCell != null) { + data.setName(getCellValueAsString(nameCell)); + } + + // Get the number (second column) + Cell numberCell = row.getCell(1); + if (numberCell != null) { + try { + if (numberCell.getCellType() == CellType.NUMERIC) { + data.setNumber(numberCell.getNumericCellValue()); + } else { + data.setNumber(Double.parseDouble(getCellValueAsString(numberCell))); + } + } catch (NumberFormatException e) { + // If we can't parse as number, set to 0 + data.setNumber(0.0); + } + } + + list.add(data); + } + + return list; + } + + /** + * Compares two workbooks for structural equality (same number of sheets, rows, cells). + */ + public static boolean hasSameStructure(Workbook wb1, Workbook wb2) { + if (wb1.getNumberOfSheets() != wb2.getNumberOfSheets()) { + return false; + } + + for (int i = 0; i < wb1.getNumberOfSheets(); i++) { + Sheet sheet1 = wb1.getSheetAt(i); + Sheet sheet2 = wb2.getSheetAt(i); + + if (getUsedRowCount(sheet1) != getUsedRowCount(sheet2)) { + return false; + } + + for (Row row : sheet1) { + Row correspondingRow = sheet2.getRow(row.getRowNum()); + if (correspondingRow == null && row.getPhysicalNumberOfCells() > 0) { + return false; + } + if (correspondingRow != null + && row.getPhysicalNumberOfCells() != correspondingRow.getPhysicalNumberOfCells()) { + return false; + } + } + } + + return true; + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/TestFileUtil.java b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/TestFileUtil.java new file mode 100644 index 000000000..1df89f717 --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/testkit/util/TestFileUtil.java @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.testkit.util; + +import java.io.File; +import java.io.FileInputStream; +import java.io.IOException; +import java.io.InputStream; +import org.apache.fesod.sheet.testkit.enums.ExcelFormat; + +/** + * Enhanced test file utilities with format-aware methods. + * Extends the existing TestFileUtil functionality. + */ +public class TestFileUtil { + + /** + * Creates a new temporary file with the given name and format extension. + */ + public static File createTempFile(String name, ExcelFormat format) { + String fileName = name + format.getExtension(); + File tempFile = new File(System.getProperty("java.io.tmpdir"), fileName); + // Make sure file doesn't exist + if (tempFile.exists()) { + tempFile.delete(); + } + return tempFile; + } + + /** + * Creates a new temporary file with unique name for the specified format. + */ + public static File createUniqueTempFile(ExcelFormat format) { + return createTempFile( + "test_" + System.currentTimeMillis() + "_" + + Thread.currentThread().getId(), + format); + } + + /** + * Creates a new temporary file with unique name and specified base name for the format. + */ + public static File createUniqueTempFile(String baseName, ExcelFormat format) { + return createTempFile( + baseName + "_" + System.currentTimeMillis() + "_" + + Thread.currentThread().getId(), + format); + } + + /** + * Checks if a file exists and is readable. + */ + public static boolean isFileReadable(File file) { + return file != null && file.exists() && file.canRead() && file.length() > 0; + } + + /** + * Gets the format of a file based on its extension. + */ + public static ExcelFormat getFileFormat(File file) { + String fileName = file.getName().toLowerCase(); + if (fileName.endsWith(".xlsx")) { + return ExcelFormat.XLSX; + } else if (fileName.endsWith(".xls")) { + return ExcelFormat.XLS; + } else if (fileName.endsWith(".csv")) { + return ExcelFormat.CSV; + } else { + throw new IllegalArgumentException("Unknown file format: " + fileName); + } + } + + /** + * Copies a file resource to a temporary file. + */ + public static File copyResourceToFile(String resourceName, File destination) throws IOException { + try (InputStream inputStream = TestFileUtil.class.getClassLoader().getResourceAsStream(resourceName)) { + if (inputStream == null) { + throw new IOException("Resource not found: " + resourceName); + } + + java.nio.file.Files.copy(inputStream, destination.toPath()); + return destination; + } + } + + /** + * Cleans up temporary files created during testing. + */ + public static void cleanupTempFile(File file) { + if (file != null && file.exists()) { + file.delete(); + } + } + + /** + * Reads file contents as a byte array. + */ + public static byte[] readFileAsBytes(File file) throws IOException { + try (FileInputStream fis = new FileInputStream(file)) { + byte[] bytes = new byte[(int) file.length()]; + int read = fis.read(bytes); + if (read != bytes.length) { + throw new IOException("Could not read complete file"); + } + return bytes; + } + } +} diff --git a/fesod/src/test/java/org/apache/fesod/sheet/unit/converter/ConverterUnitTest.java b/fesod/src/test/java/org/apache/fesod/sheet/unit/converter/ConverterUnitTest.java new file mode 100644 index 000000000..546ff7f3a --- /dev/null +++ b/fesod/src/test/java/org/apache/fesod/sheet/unit/converter/ConverterUnitTest.java @@ -0,0 +1,203 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.fesod.sheet.unit.converter; + +import static org.assertj.core.api.Assertions.assertThat; +import java.math.BigDecimal; +import java.sql.Timestamp; +import org.apache.fesod.sheet.converter.TimestampNumberConverter; +import org.apache.fesod.sheet.converter.TimestampStringConverter; +import org.apache.fesod.sheet.converters.WriteConverterContext; +import org.apache.fesod.sheet.converters.floatconverter.FloatNumberConverter; +import org.apache.fesod.sheet.enums.CellDataTypeEnum; +import org.apache.fesod.sheet.metadata.GlobalConfiguration; +import org.apache.fesod.sheet.metadata.data.WriteCellData; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Nested; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; + +/** + * Unit tests for individual converter implementations. + * Tests converters in isolation without file I/O. + * + *

    Consolidated from legacy {@code ConverterTest} and expanded with + * additional converter tests.

    + */ +@Tag("unit") +@DisplayName("Converter Unit Tests") +class ConverterUnitTest { + + // ==================== Float Converter Tests ==================== + + @Nested + @DisplayName("FloatNumberConverter") + class FloatNumberConverterTests { + + private final FloatNumberConverter converter = new FloatNumberConverter(); + + @Test + @DisplayName("should convert float to BigDecimal with correct precision") + void shouldConvertFloatToExactBigDecimal() { + // Given + WriteConverterContext context = new WriteConverterContext<>(); + context.setValue(95.62F); + + // When + WriteCellData result = converter.convertToExcelData(context); + + // Then + assertThat(result.getNumberValue()).isNotNull().isEqualByComparingTo(new BigDecimal("95.62")); + } + + @Test + @DisplayName("should convert zero correctly") + void shouldConvertZeroCorrectly() { + // Given + WriteConverterContext context = new WriteConverterContext<>(); + context.setValue(0.0F); + + // When + WriteCellData result = converter.convertToExcelData(context); + + // Then + assertThat(result.getNumberValue()).isEqualByComparingTo(BigDecimal.ZERO); + } + + @Test + @DisplayName("should convert negative float correctly") + void shouldConvertNegativeFloatCorrectly() { + // Given + WriteConverterContext context = new WriteConverterContext<>(); + context.setValue(-123.45F); + + // When + WriteCellData result = converter.convertToExcelData(context); + + // Then + assertThat(result.getNumberValue()).isEqualByComparingTo(new BigDecimal("-123.45")); + } + + @Test + @DisplayName("should support Float java type") + void shouldSupportFloatJavaType() { + assertThat(converter.supportJavaTypeKey()).isEqualTo(Float.class); + } + } + + // ==================== Timestamp String Converter Tests ==================== + + @Nested + @DisplayName("TimestampStringConverter") + class TimestampStringConverterTests { + + private final TimestampStringConverter converter = new TimestampStringConverter(); + + @Test + @DisplayName("should convert timestamp to string format") + void shouldConvertTimestampToString() { + // Given + Timestamp timestamp = Timestamp.valueOf("2020-01-01 12:30:45"); + GlobalConfiguration config = new GlobalConfiguration(); + + // When + WriteCellData result = converter.convertToExcelData(timestamp, null, config); + + // Then + assertThat(result.getType()).isEqualTo(CellDataTypeEnum.STRING); + assertThat(result.getStringValue()).isNotNull(); + // The exact format depends on locale, just verify it's a date string + assertThat(result.getStringValue()).contains("2020"); + } + + @Test + @DisplayName("should support Timestamp java type") + void shouldSupportTimestampJavaType() { + assertThat(converter.supportJavaTypeKey()).isEqualTo(Timestamp.class); + } + + @Test + @DisplayName("should support STRING excel type") + void shouldSupportStringExcelType() { + assertThat(converter.supportExcelTypeKey()).isEqualTo(CellDataTypeEnum.STRING); + } + } + + // ==================== Timestamp Number Converter Tests ==================== + + @Nested + @DisplayName("TimestampNumberConverter") + class TimestampNumberConverterTests { + + private final TimestampNumberConverter converter = new TimestampNumberConverter(); + + @Test + @DisplayName("should convert timestamp to Excel date number") + void shouldConvertTimestampToExcelNumber() { + // Given + Timestamp timestamp = Timestamp.valueOf("2020-01-01 00:00:00"); + GlobalConfiguration config = new GlobalConfiguration(); + + // When + WriteCellData result = converter.convertToExcelData(timestamp, null, config); + + // Then + assertThat(result.getNumberValue()).isNotNull().isGreaterThan(BigDecimal.ZERO); + // Excel date for 2020-01-01 is approximately 43831 + assertThat(result.getNumberValue().intValue()).isGreaterThan(43000); + } + + @Test + @DisplayName("should support Timestamp java type") + void shouldSupportTimestampJavaType() { + assertThat(converter.supportJavaTypeKey()).isEqualTo(Timestamp.class); + } + + @Test + @DisplayName("should support NUMBER excel type") + void shouldSupportNumberExcelType() { + assertThat(converter.supportExcelTypeKey()).isEqualTo(CellDataTypeEnum.NUMBER); + } + } + + // ==================== Converter Type Support Tests ==================== + + @Nested + @DisplayName("Converter Type Support") + class ConverterTypeSupportTests { + + @Test + @DisplayName("timestamp converters should support different excel types") + void timestampConvertersShouldSupportDifferentExcelTypes() { + TimestampStringConverter stringConverter = new TimestampStringConverter(); + TimestampNumberConverter numberConverter = new TimestampNumberConverter(); + + // Both support same Java type + assertThat(stringConverter.supportJavaTypeKey()) + .isEqualTo(numberConverter.supportJavaTypeKey()) + .isEqualTo(Timestamp.class); + + // But different Excel types + assertThat(stringConverter.supportExcelTypeKey()).isNotEqualTo(numberConverter.supportExcelTypeKey()); + assertThat(stringConverter.supportExcelTypeKey()).isEqualTo(CellDataTypeEnum.STRING); + assertThat(numberConverter.supportExcelTypeKey()).isEqualTo(CellDataTypeEnum.NUMBER); + } + } +}