Skip to content

Commit adff910

Browse files
junmuzymuzammil
authored andcommitted
FLINK-38785: Fixes the quotes issue with variable concatenation
1 parent 7ba9741 commit adff910

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

flink-dist/src/main/flink-bin/bin/config.sh

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -276,15 +276,18 @@ fi
276276

277277
if [ -z "${FLINK_ENV_JAVA_OPTS}" ]; then
278278
FLINK_ENV_JAVA_DEFAULT_OPTS=$(readFromConfig ${KEY_ENV_JAVA_DEFAULT_OPTS} "" "${YAML_CONF}")
279+
# Remove leading and ending double quotes (if present) of value
280+
FLINK_ENV_JAVA_DEFAULT_OPTS="$( echo "${FLINK_ENV_JAVA_DEFAULT_OPTS}" | sed -e 's/^"//' -e 's/"$//' )"
281+
279282
FLINK_ENV_JAVA_OPTS=$(readFromConfig ${KEY_ENV_JAVA_OPTS} "" "${YAML_CONF}")
280283
if [ -z "${FLINK_ENV_JAVA_OPTS}" ]; then
281284
# try deprecated key
282285
FLINK_ENV_JAVA_OPTS=$(readFromConfig "env.java.opts" "${DEFAULT_ENV_JAVA_OPTS}" "${YAML_CONF}")
283286
fi
284-
FLINK_ENV_JAVA_OPTS="${FLINK_ENV_JAVA_DEFAULT_OPTS} ${FLINK_ENV_JAVA_OPTS}"
285-
286287
# Remove leading and ending double quotes (if present) of value
287-
FLINK_ENV_JAVA_OPTS="-XX:+IgnoreUnrecognizedVMOptions $( echo "${FLINK_ENV_JAVA_OPTS}" | sed -e 's/^"//' -e 's/"$//' )"
288+
FLINK_ENV_JAVA_OPTS="$( echo "${FLINK_ENV_JAVA_OPTS}" | sed -e 's/^"//' -e 's/"$//' )"
289+
FLINK_ENV_JAVA_OPTS="-XX:+IgnoreUnrecognizedVMOptions ${FLINK_ENV_JAVA_DEFAULT_OPTS} ${FLINK_ENV_JAVA_OPTS}"
290+
288291

289292
JAVA_SPEC_VERSION=`"${JAVA_RUN}" -XshowSettings:properties 2>&1 | grep "java.specification.version" | cut -d "=" -f 2 | tr -d '[:space:]' | rev | cut -d "." -f 1 | rev`
290293
if [[ $(( $JAVA_SPEC_VERSION > 17 )) == 1 ]]; then
@@ -295,18 +298,26 @@ fi
295298

296299
if [ -z "${FLINK_ENV_JAVA_OPTS_JM}" ]; then
297300
FLINK_ENV_JAVA_DEFAULT_OPTS_JM=$(readFromConfig ${KEY_ENV_JAVA_DEFAULT_OPTS_JM} "" "${YAML_CONF}")
301+
# Remove leading and ending double quotes (if present) of value
302+
FLINK_ENV_JAVA_DEFAULT_OPTS_JM="$( echo "${FLINK_ENV_JAVA_DEFAULT_OPTS_JM}" | sed -e 's/^"//' -e 's/"$//' )"
303+
298304
FLINK_ENV_JAVA_OPTS_JM=$(readFromConfig ${KEY_ENV_JAVA_OPTS_JM} "${DEFAULT_ENV_JAVA_OPTS_JM}" "${YAML_CONF}")
299-
FLINK_ENV_JAVA_OPTS_JM="${FLINK_ENV_JAVA_DEFAULT_OPTS_JM} ${FLINK_ENV_JAVA_OPTS_JM}"
300305
# Remove leading and ending double quotes (if present) of value
301306
FLINK_ENV_JAVA_OPTS_JM="$( echo "${FLINK_ENV_JAVA_OPTS_JM}" | sed -e 's/^"//' -e 's/"$//' )"
307+
308+
FLINK_ENV_JAVA_OPTS_JM="${FLINK_ENV_JAVA_DEFAULT_OPTS_JM} ${FLINK_ENV_JAVA_OPTS_JM}"
302309
fi
303310

304311
if [ -z "${FLINK_ENV_JAVA_OPTS_TM}" ]; then
305312
FLINK_ENV_JAVA_DEFAULT_OPTS_TM=$(readFromConfig ${KEY_ENV_JAVA_DEFAULT_OPTS_TM} "" "${YAML_CONF}")
313+
# Remove leading and ending double quotes (if present) of value
314+
FLINK_ENV_JAVA_DEFAULT_OPTS_TM="$( echo "${FLINK_ENV_JAVA_DEFAULT_OPTS_TM}" | sed -e 's/^"//' -e 's/"$//' )"
315+
306316
FLINK_ENV_JAVA_OPTS_TM=$(readFromConfig ${KEY_ENV_JAVA_OPTS_TM} "${DEFAULT_ENV_JAVA_OPTS_TM}" "${YAML_CONF}")
307-
FLINK_ENV_JAVA_OPTS_TM="${FLINK_ENV_JAVA_DEFAULT_OPTS_TM} ${FLINK_ENV_JAVA_OPTS_TM}"
308317
# Remove leading and ending double quotes (if present) of value
309318
FLINK_ENV_JAVA_OPTS_TM="$( echo "${FLINK_ENV_JAVA_OPTS_TM}" | sed -e 's/^"//' -e 's/"$//' )"
319+
320+
FLINK_ENV_JAVA_OPTS_TM="${FLINK_ENV_JAVA_DEFAULT_OPTS_TM} ${FLINK_ENV_JAVA_OPTS_TM}"
310321
fi
311322

312323
if [ -z "${FLINK_ENV_JAVA_OPTS_HS}" ]; then

0 commit comments

Comments
 (0)