review comments handling

Author: vikramahuja1001

common/src/java/org/apache/hadoop/hive/conf/HiveConf.java

@@ -5607,16 +5607,11 @@ public static enum ConfVars {
     HIVE_MM_AVOID_GLOBSTATUS_ON_S3("hive.mm.avoid.s3.globstatus", true,
         "Whether to use listFiles (optimized on S3) instead of globStatus when on S3."),
 
-    HIVE_IGNORE_REMOVED_CONFIGS_LIST("hive.ignore.removed.configs.list",
-            "",
-            "Comma separated list of configuration options which are removed from hive code. Silently ignore if the user tries to set them"),
-
     // If a parameter is added to the restricted list, add a test in TestRestrictedList.Java
     HIVE_CONF_RESTRICTED_LIST("hive.conf.restricted.list",
         "hive.security.authenticator.manager,hive.security.authorization.manager," +
         "hive.security.metastore.authorization.manager,hive.security.metastore.authenticator.manager," +
         "hive.users.in.admin.role,hive.server2.xsrf.filter.enabled,hive.server2.csrf.filter.enabled,hive.security.authorization.enabled," +
-            "hive.ignore.removed.configs.list," +
             "hive.distcp.privileged.doAs," +
             "hive.server2.authentication.ldap.baseDN," +
             "hive.server2.authentication.ldap.url," +

ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java

@@ -67,7 +67,11 @@ public class SetProcessor implements CommandProcessor {
           "hive.metastore.initial.metadata.count.enabled",
           "hive.cli.pretty.output.num.cols",
           "hive.debug.localtask",
-          "hive.timedout.txn.reaper.start"
+          "hive.timedout.txn.reaper.start",
+          "hive.repl.dumpdir.ttl",
+          "hive.repl.dumpdir.clean.freq",
+          "hive.llap.io.vrb.queue.limit.base",
+          "hive.llap.external.splits.order.by.force.single.split"
           );
   // Allow the user to set the ORC properties without getting an error.
   private static final Set<String> allowOrcConfigs = new HashSet<>();
@@ -241,14 +245,6 @@ static String setConf(SessionState ss, String varName, String key, String varVal
     String result = null;
     HiveConf conf = ss.getConf();
 
-    String removedHiveConfigsList = conf.getVar(HiveConf.ConfVars.HIVE_IGNORE_REMOVED_CONFIGS_LIST);
-    if (removedHiveConfigsList != null && !removedHiveConfigsList.isEmpty()) {
-      for (String entry : removedHiveConfigsList.split(",")) {
-        if (!removedHiveConfigs.contains(entry.trim())) {
-          removedHiveConfigs.add(entry.trim());
-        }
-      }
-    }
     if (removedHiveConfigs.contains(key)) {
       // do not do anything. do not throw any error, just silently return
       result = HiveConf.generateRemovedWarning();