refactor: replace lsof port preflight with ss/netstat #85
Workflow file for this run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | |
| # Licensed to the Apache Software Foundation (ASF) under one or more | |
| # contributor license agreements. See the NOTICE file distributed with | |
| # this work for additional information regarding copyright ownership. | |
| # The ASF licenses this file to You under the Apache License, Version 2.0 | |
| # (the "License"); you may not use this file except in compliance with | |
| # the License. You may obtain a copy of the License at | |
| # | |
| # http://www.apache.org/licenses/LICENSE-2.0 | |
| # | |
| # Unless required by applicable law or agreed to in writing, software | |
| # distributed under the License is distributed on an "AS IS" BASIS, | |
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| # See the License for the specific language governing permissions and | |
| # limitations under the License. | |
| # | |
| name: "Docker Build CI" | |
| on: | |
| push: | |
| branches: | |
| - master | |
| - 'release-*' | |
| pull_request: | |
| paths: | |
| - '**/Dockerfile*' | |
| - '.dockerignore' | |
| - 'hugegraph-server/hugegraph-dist/src/assembly/static/bin/util.sh' | |
| jobs: | |
| docker-build: | |
| runs-on: ubuntu-24.04 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| dockerfile: | |
| - hugegraph-pd/Dockerfile | |
| - hugegraph-store/Dockerfile | |
| - hugegraph-server/Dockerfile | |
| - hugegraph-server/Dockerfile-hstore | |
| steps: | |
| - name: Checkout | |
| uses: actions/checkout@v4 | |
| - name: Build ${{ matrix.dockerfile }} | |
| run: | | |
| IMAGE_ID=$(docker build -q -f ${{ matrix.dockerfile }} .) | |
| echo "Built: $IMAGE_ID" | |
| echo "IMAGE_ID=$IMAGE_ID" >> "$GITHUB_ENV" | |
| HC=$(docker inspect --format='{{json .Config.Healthcheck}}' "$IMAGE_ID") | |
| echo "Healthcheck: $HC" | |
| [[ "$HC" != "null" ]] || { echo "ERROR: HEALTHCHECK missing in ${{ matrix.dockerfile }}"; exit 1; } | |
| # The startup preflight needs a socket-table tool, and the base image | |
| # ships none of its own. Without one every start reports "unknown" and | |
| # a duplicate start is no longer refused, so assert the image can | |
| # actually answer. Only the server images run check_port. | |
| # TODO(docker-ci): this pins the probe dependency, not the behaviour it | |
| # protects. A full duplicate-start/stop check needs a booted server with | |
| # a backend, which belongs with the e2e job rather than the image build. | |
| - name: Port preflight can answer inside ${{ matrix.dockerfile }} | |
| if: ${{ startsWith(matrix.dockerfile, 'hugegraph-server/') }} | |
| run: | | |
| STATE=$(docker run --rm "$IMAGE_ID" bash -c \ | |
| 'source /hugegraph-server/bin/util.sh && port_listen_state 8080') | |
| echo "port_listen_state 8080 -> $STATE" | |
| # Assert a positive answer rather than "not unknown": an empty $STATE | |
| # would otherwise satisfy the check. The step's default `bash -e` | |
| # already aborts on a failed `docker run`, so this only states intent. | |
| [[ "$STATE" == "free" || "$STATE" == "busy" ]] || { | |
| echo "ERROR: no usable socket-table tool (ss/netstat) in ${{ matrix.dockerfile }}" | |
| exit 1 | |
| } |