fix(toplingdb): harden RocksDB provider fallback

Author: WaterWhisperer

hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/config/PDConfig.java

@@ -58,7 +58,7 @@ public class PDConfig {
     @Value("${grpc.host}")
     private String host;
 
-    @Value("${rocksdb.option-path: ''}")
+    @Value("${rocksdb.option-path:}")
     private String optionPath;
     @Value("${rocksdb.open-http:false}")
     private Boolean openHttp;

hugegraph-rocksdb-provider/src/main/java/org/apache/hugegraph/rocksdb/provider/RocksDBProviderLoader.java

@@ -41,7 +41,6 @@ public class RocksDBProviderLoader {
 
     private final Map<String, RocksDBProvider> providerCache = new ConcurrentHashMap<>();
     private volatile boolean loaded = false;
-    private volatile RocksDBProvider bestProvider = null;
 
     private RocksDBProviderLoader() {
         // Private constructor for singleton
@@ -65,7 +64,7 @@ public synchronized void loadProviders() {
 
         for (RocksDBProvider provider : serviceLoader) {
             try {
-                if (provider.isAvailable()) {
+                if (isProviderAvailable(provider)) {
                     providerCache.put(provider.getProviderName(), provider);
                     LOG.info("Loaded RocksDB provider: {} (priority: {})",
                              provider.getProviderName(), provider.getPriority());
@@ -114,40 +113,28 @@ public RocksDBProvider getBestProvider() {
             loadProviders();
         }
 
-        RocksDBProvider cached = this.bestProvider;
-        if (cached != null) {
-            return cached;
-        }
-
         if (providerCache.isEmpty()) {
             throw new RuntimeException("No RocksDB providers available");
         }
 
-        synchronized (this) {
-            if (this.bestProvider != null) {
-                return this.bestProvider;
-            }
-
-            // Find provider with highest priority
-            RocksDBProvider selected = null;
-            int highestPriority = Integer.MIN_VALUE;
-
-            for (RocksDBProvider provider : providerCache.values()) {
-                if (provider.isAvailable() && provider.getPriority() > highestPriority) {
-                    selected = provider;
-                    highestPriority = provider.getPriority();
-                }
-            }
+        // Find provider with highest priority
+        RocksDBProvider bestProvider = null;
+        int highestPriority = Integer.MIN_VALUE;
 
-            if (selected == null) {
-                throw new RuntimeException("No available RocksDB providers found");
+        for (RocksDBProvider provider : providerCache.values()) {
+            if (isProviderAvailable(provider) && provider.getPriority() > highestPriority) {
+                bestProvider = provider;
+                highestPriority = provider.getPriority();
             }
+        }
 
-            this.bestProvider = selected;
-            LOG.info("Auto-selected RocksDB provider: {} (priority: {})",
-                     selected.getProviderName(), selected.getPriority());
-            return selected;
+        if (bestProvider == null) {
+            throw new RuntimeException("No available RocksDB providers found");
         }
+
+        LOG.info("Auto-selected RocksDB provider: {} (priority: {})",
+                 bestProvider.getProviderName(), bestProvider.getPriority());
+        return bestProvider;
     }
 
     /**
@@ -188,7 +175,7 @@ public boolean isProviderAvailable(String providerName) {
         }
 
         RocksDBProvider provider = providerCache.get(providerName);
-        return provider != null && provider.isAvailable();
+        return provider != null && isProviderAvailable(provider);
     }
 
     /**
@@ -197,10 +184,19 @@ public boolean isProviderAvailable(String providerName) {
     public synchronized void reload() {
         loaded = false;
         providerCache.clear();
-        bestProvider = null;
         loadProviders();
     }
 
+    private boolean isProviderAvailable(RocksDBProvider provider) {
+        try {
+            return provider.isAvailable();
+        } catch (RuntimeException | LinkageError e) {
+            LOG.warn("Failed to check RocksDB provider availability: {}",
+                     provider.getClass().getName(), e);
+            return false;
+        }
+    }
+
     // Static convenience methods
 
     /**

hugegraph-rocksdb-provider/src/main/java/org/apache/hugegraph/rocksdb/provider/ToplingRocksDBProvider.java

@@ -207,7 +207,7 @@ private RocksDB openWithToplingFeaturesAndCF(DBOptions dbOptions, String dataPat
             // Prepare column family names for JSON
             List<String> cfNames = new java.util.ArrayList<>();
             for (ColumnFamilyDescriptor cfDescriptor : cfDescriptors) {
-                cfNames.add(new String(cfDescriptor.getName()));
+                cfNames.add(new String(cfDescriptor.getName(), StandardCharsets.UTF_8));
             }
 
             // Open database with column families