You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cli: consumer-offset set always says consumer for group kinds #4459
iggy consumer-offset set always says "consumer", also when -k consumer-group or -k external-group is used. The text is hard-coded in explain, the error context and the success message (core/cli/src/commands/binary_consumer_offsets/set_consumer_offset.rs:60, :71, :77).
consumer-offset get already gets this right with get_consumer_info (core/cli/src/commands/binary_consumer_offsets/get_consumer_offset.rs:52).
Proposal
Use the same wording as get_consumer_info in all three places in set_consumer_offset.rs, either by moving it to a shared helper or by adding the same method to SetConsumerOffsetCmd.
Acceptance
consumer-offset set -k consumer-group ... prints "consumer group with ID: ...", and -k external-group prints "external group with ID: ...".
-k consumer (the default) prints the same text as today.
core/integration/tests/cli/consumer_offset/test_consumer_offset_set_command.rs covers the consumer and external group kinds and passes.
Hi @SunilKumarPradhan, are you still working on this? It’s been about two weeks since it was assigned. If you’re busy, I’m happy to pick it up. @justinmclean, could you reassign it if Sunil’s no longer on it?
Activity
SunilKumarPradhan commentedon Oct 8, 2026
Hi @justinmclean I would like to work on this issue , could you please assign it to me.
justinmclean commentedon Oct 8, 2026
All yours
VedantShuklaaa commentedon Oct 20, 2026
Hi @SunilKumarPradhan, are you still working on this? It’s been about two weeks since it was assigned. If you’re busy, I’m happy to pick it up. @justinmclean, could you reassign it if Sunil’s no longer on it?
SunilKumarPradhan commentedon Oct 21, 2026
Hi @VedantShuklaaa , I am still working on it will raise PR today. I was midway through implementation, but I got occupied with something else.