Skip to content

cli: consumer-offset set always says consumer for group kinds #4459

Open

Description

@justinmclean

Split from #4450.

Problem

iggy consumer-offset set always says "consumer", also when -k consumer-group or -k external-group is used. The text is hard-coded in explain, the error context and the success message (core/cli/src/commands/binary_consumer_offsets/set_consumer_offset.rs:60, :71, :77).

consumer-offset get already gets this right with get_consumer_info (core/cli/src/commands/binary_consumer_offsets/get_consumer_offset.rs:52).

Proposal

Use the same wording as get_consumer_info in all three places in set_consumer_offset.rs, either by moving it to a shared helper or by adding the same method to SetConsumerOffsetCmd.

Acceptance

  • consumer-offset set -k consumer-group ... prints "consumer group with ID: ...", and -k external-group prints "external group with ID: ...".
  • -k consumer (the default) prints the same text as today.
  • core/integration/tests/cli/consumer_offset/test_consumer_offset_set_command.rs covers the consumer and external group kinds and passes.

Activity

  1. added
    enhancementA change that improves our (or users) QoL
    tuiCommand line interface (iggy-cmd/iggy-cli) related change
    on Oct 8, 2026
  2. SunilKumarPradhan commented on Oct 8, 2026

    @SunilKumarPradhan

    Hi @justinmclean I would like to work on this issue , could you please assign it to me.

  3. justinmclean commented on Oct 8, 2026

    @justinmclean
    MemberAuthor

    All yours

  4. VedantShuklaaa commented on Oct 20, 2026

    @VedantShuklaaa

    Hi @SunilKumarPradhan, are you still working on this? It’s been about two weeks since it was assigned. If you’re busy, I’m happy to pick it up. @justinmclean, could you reassign it if Sunil’s no longer on it?

  5. SunilKumarPradhan commented on Oct 21, 2026

    @SunilKumarPradhan

    Hi @VedantShuklaaa , I am still working on it will raise PR today. I was midway through implementation, but I got occupied with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

enhancementA change that improves our (or users) QoLgood first issueGood for newcomerstuiCommand line interface (iggy-cmd/iggy-cli) related change

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions