-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a highlighter #22
Comments
Additionally, this might help inform things the browsers need to change/tweak/add about how the DOM itself works and interacts. |
Many years ago, there was http://xpointerlib.mozdev.org a Firefox add-on used for Annotea, that would insert into DOM elements to highlight annotations, while marking those nodes to be ignored in further operations, such that multiple annotations would still more or less anchor. See |
Worth taking inspiration from https://github.com/nickstenning/marks too |
Nice part about inserting |
I take that back. I would rather not commit to any tag choice at all right now and just spend some time mulling over what problem(s) really need solving. Here are some more formed thoughts that have come up for me in the past: Q: How to denote things added by the annotation layer Q: How to visualize style / modify the DOM Q: How do we iterate over all the text nodes? I think we need to sketch a couple highlighter implementations and play with them. |
Done in PR 59: #59 |
This does eek into the realm of UX, so I want to proceed cautiously here. However, juggling the "mixed tree" environment discussed in #21 is likely to be a near everyday occurrence for folks building annotation tools.
If we can collectively solve that issue well, we'll all win. 😁
The text was updated successfully, but these errors were encountered: