Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c++): use nested namespace to distinguish different level reader/writer #619

Open
acezen opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@acezen
Copy link
Contributor

acezen commented Sep 4, 2024

Describe the enhancement requested

Currently GraphAr c++ library use the class name to distinguish different level reader/writer like
VertexPropertyChunkInfoReader as info level vertex property reader and VertexPropertyArrowChunkReader as arrow vertex property reader. This makes the name too long and not concise.

Maybe we can use nested namespace to replace the naming like:
VertexPropertyChunkInfoReader -> graphar::VertexChunkReader
VertexPropertyArrowChunkReader -> graphar::arrow::VertexChunkReader
AdjListChunkInfoReader -> graphar:AdjListChunkReader
AdjListArrowChunkReader -> graphar::arrow::AdjListChunkReader
AdjListOffsetChunkInfoReader -> graphar::OffsetChunkReader
AdjListPropertyChunkInfoReader -> graphar::EdgePropertyChunkReader
AdjListOffsetArrowChunkReader -> graphar::arrow::OffsetChunkReader
AdjListPropertyArrowChunkReader -> graphar::arrow::EdgePropertyChunkReader

VertexChunkInfoWriter -> graphar::VertexChunkWriter
VertexChunkArrowWriter -> graphar::arrow::VertexChunkWriter
EdgeChunkInfoWriter -> graphar::EdgeChunkWriter
EdgeChunkArrowWriter -> graphar::arrow::EdgeChunkWriter

Component(s)

C++

@acezen acezen added the enhancement New feature or request label Sep 4, 2024
@acezen acezen self-assigned this Sep 4, 2024
@acezen
Copy link
Contributor Author

acezen commented Sep 4, 2024

cc/ @Elssky @lixueclaire @yecol

I want to get some feedback about this issue, please leave your comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant