Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Optaplanner build reproducible #846

Closed
Tracked by #837
lucamolteni opened this issue Jan 22, 2024 · 8 comments · Fixed by apache/incubator-kie-optaplanner#3059
Closed
Tracked by #837

Make Optaplanner build reproducible #846

lucamolteni opened this issue Jan 22, 2024 · 8 comments · Fixed by apache/incubator-kie-optaplanner#3059
Labels
apache:migration Related to Apache Migration

Comments

@lucamolteni
Copy link

See #820, but for Optaplanner

@yesamer yesamer mentioned this issue Jan 22, 2024
5 tasks
@eduardocerqueira eduardocerqueira added the apache:migration Related to Apache Migration label Jan 23, 2024
@hboutemy
Copy link
Member

@yurloc did you find any issue with jaxb2 output?

@yurloc
Copy link

yurloc commented Jan 24, 2024

@yurloc did you find any issue with jaxb2 output?

I didn't. Our manual reproducibility check according to this guide fails in the mvn artifact:check-buildplan step. But when I skip that and just run

mvn clean install 
mvn clean verify artifact:compare

no difference is detected in modules that use the jaxb2 plugin (we use the schemagen goal).

If I understand the situation correctly, in our case jaxb2-maven-plugin:3.1.0:schemagen does not make the build non-reproducible.

@yurloc
Copy link

yurloc commented Jan 24, 2024

@hboutemy I've just read your comment in 296 and I agree that we don't have an issue with the jaxb2 plugin, other than failing the check-buildplan step. In case this is an optional check, then we're OK. It's just a bit misleading to someone who's new to the reproducible builds because it's not clear how important check-buildplan is.

@hboutemy
Copy link
Member

other than failing the check-buildplan step. In case this is an optional check

yes, artifact:check-buildplan is just a helper tool to ease discovering and fixing easy/basic issues: if you see how to improve the wording on https://maven.apache.org/guides/mini/guide-reproducible-builds.html (or anywhere else), please help

FYI, I dropped jaxb2-maven-plugin because it's not really helping currently but more creating complexity

@lucamolteni
Copy link
Author

please help

Check this please

apache/maven-site#489

@yurloc
Copy link

yurloc commented Jan 26, 2024

Second part of the Quarkus timestamps issue:

When we upgrade to a Quarkus version that contains both fixes, we no longer need a workaround.

@lucamolteni
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache:migration Related to Apache Migration
Projects
Status: 🎯 Done
Development

Successfully merging a pull request may close this issue.

4 participants