Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the implementation of the beforeImage and afterImage in the undo log #751

Open
Code-Fight opened this issue Dec 22, 2024 · 0 comments

Comments

@Code-Fight
Copy link
Contributor

Code-Fight commented Dec 22, 2024

What would you like to be added:

  1. Abstract beforeImage and afterImage, define them as interfaces, and implement their capabilities for MySQL.
  2. Replace the definitions in the executor with the new implementations mentioned above.
  3. Deprecate the implementation in the undo/builder package.

Why is this needed:

  1. Currently, there are two separate implementations for constructing undo log images, located in the exec package and the undo/builder package.
  2. The implementation in the undo/builder package is not being utilized.
  3. To better support different types of databases in the future, the implementation within the executor needs to be redefined and abstracted.
image image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant