Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Avoid copying direct memory when flushing data. #2092

Open
3 tasks done
zhengchenyu opened this issue Sep 2, 2024 · 3 comments
Open
3 tasks done

[Improvement] Avoid copying direct memory when flushing data. #2092

zhengchenyu opened this issue Sep 2, 2024 · 3 comments
Assignees

Comments

@zhengchenyu
Copy link
Collaborator

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

When flush data to local disk, will copy data. See code below:

dataWriter.writeData(ByteBufUtils.readBytes(block.getData()));

In fact, we can direct write ByteBuffer to file channel. For netty mode, the ByteBuffer is DirectByteBuffer, will avoid copy the memory.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zhengchenyu zhengchenyu self-assigned this Sep 2, 2024
@xianjingfeng
Copy link
Member

Similar issue: #1613

@zhengchenyu
Copy link
Collaborator Author

Similar issue: #1613

I do not notice that pr. I will try to test and check to see if the problem described in #1613 occurs

@maobaolong
Copy link
Member

@zhengchenyu Have you reproduced that issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants