Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2148] improvement(server): Rename ShuffleBufferWithLinkedList to DefaultShuffleBuffer #2149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#2148] improvement(server): Rename ShuffleBufferWithLinkedList to DefaultShuffleBuffer #2149

wants to merge 1 commit into from

Conversation

zuston
Copy link
Member

@zuston zuston commented Sep 26, 2024

What changes were proposed in this pull request?

Rename ShuffleBufferWithLinkedList to DefaultShuffleBuffer

Why are the changes needed?

Fix: #2148

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Needn't

@zuston
Copy link
Member Author

zuston commented Sep 26, 2024

cc @maobaolong

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

Test Results

 2 342 files  ±0   2 342 suites  ±0   2h 16m 33s ⏱️ +9s
   901 tests ±0     900 ✅ ±0   1 💤 ±0  0 ❌ ±0 
11 625 runs  ±0  11 610 ✅ ±0  15 💤 ±0  0 ❌ ±0 

Results for commit d6759d4. ± Comparison against base commit a364f2a.

This pull request removes 6 and adds 6 tests. Note that renamed tests count towards both. 
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ appendMultiBlocksTest
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ appendTest
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ getShuffleDataTest
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ getShuffleDataWithExpectedTaskIdsFilterTest
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ getShuffleDataWithLocalOrderTest
org.apache.uniffle.server.buffer.ShuffleBufferWithLinkedListTest ‑ toFlushEventTest

org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ appendMultiBlocksTest
org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ appendTest
org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ getShuffleDataTest
org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ getShuffleDataWithExpectedTaskIdsFilterTest
org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ getShuffleDataWithLocalOrderTest
org.apache.uniffle.server.buffer.DefaultShuffleBufferTest ‑ toFlushEventTest

♻️ This comment has been updated with latest results.

maobaolong
maobaolong approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@maobaolong maobaolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this PR.

@maobaolong
Copy link
Member

@zuston Would you like to solve this conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maobaolong maobaolong maobaolong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Rename the ShuffleBufferWithLinkedList to DefaultShuffleBuffer
2 participants
@zuston @maobaolong