New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Remove the ShuffleBlockInfo used in the communication between client and server via handleSendShuffleDataRequest. #2201

Open

3 tasks done

lwllvyb opened this issue Oct 18, 2024 · 0 comments

Contributor

lwllvyb commented Oct 18, 2024 •

edited

Loading

Code of Conduct

I agree to follow this project's Code of Conduct

Search before asking

I have searched in the issues and found no similar issues.

What would you like to be improved?

Remove the ShuffleBlockInfo used in the communication between client and server via handleSendShuffleDataRequest.
The code byteBuf.writeInt(shuffleBlockInfo.getLength()); in encodeShuffleBlockInfo is redundant, because the block data length has been encoded in shuffleBlockInfo.copyDataTo(byteBuf)

Related PR: #2181

How should we improve?

No response

Are you willing to submit PR?

Yes I am willing to submit a PR!

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment