Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] Throw an awaitility.core.ConditionTimeoutException #2376

Closed
2 of 3 tasks
summaryzb opened this issue Mar 4, 2025 · 1 comment · Fixed by #2377
Closed
2 of 3 tasks

[Flaky Test] Throw an awaitility.core.ConditionTimeoutException #2376

summaryzb opened this issue Mar 4, 2025 · 1 comment · Fixed by #2377

Comments

@summaryzb
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the flaky test

Condition with lambda expression in org.apache.uniffle.coordinator.SimpleClusterManagerTest that uses org.apache.uniffle.coordinator.SimpleClusterManager, org.apache.uniffle.coordinator.SimpleClusterManagerjava.util.Set was not fulfilled within 1 seconds.
org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in org.apache.uniffle.coordinator.SimpleClusterManagerTest that uses org.apache.uniffle.coordinator.SimpleClusterManager, org.apache.uniffle.coordinator.SimpleClusterManagerjava.util.Set was not fulfilled within 1 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:954)
at org.apache.uniffle.coordinator.SimpleClusterManagerTest.getUnhealthyServerList(SimpleClusterManagerTest.java:208)

Actions URL

https://github.com/apache/incubator-uniffle/actions/runs/13648223037/job/38150934061?pr=2375

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
summaryzb added a commit to summaryzb/incubator-uniffle that referenced this issue Mar 4, 2025
@summaryzb
[apache#2376] test(coordinator): set more rss.coordinator.server.hear…
76833e6 
…tbeat.timeout to pass flaky test
@summaryzb summaryzb mentioned this issue Mar 4, 2025
Merged
@summaryzb
Copy link
Contributor Author

SimpleClusterManager.nodesCheck happens before the first execution of await condition, since the default poll time of the org.awaitility.Awaitility.await is 100ms.
Set rss.coordinator.server.heartbeat.timeout to 600, this can ensure SimpleClusterManager.nodesCheck happens 200ms later.

summaryzb added a commit to summaryzb/incubator-uniffle that referenced this issue Mar 4, 2025
@summaryzb
[apache#2376] test(coordinator): set more rss.coordinator.server.hear…
3c0108a 
…tbeat.timeout to pass flaky test
LuciferYang pushed a commit that referenced this issue Mar 5, 2025
@summaryzb
test(coordinator): The interval of SimpleClusterManager.nodesCheck sh…
8ad0f8d 
…ould be bigger than that of org.awaitility.Awaitility.await (#2377)

### What changes were proposed in this pull request?
The initial an interval execution time of `SimpleClusterManager.nodesCheck` changed from 100ms to 200ms, this can make condition verify of unit test execute before and after `nodesCheck`

### Why are the changes needed?
    - Pass the flaky test
    - set bigger rss.coordinator.server.heartbeat.timeout to avoid `SimpleClusterManager.nodesCheck` happens before the first execution of await condition, since the default poll time of the `org.awaitility.Awaitility.await` is 100ms

Fix: #2376

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Flaky test can be fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@summaryzb