[PoC] Add error-prone.picnic.tech featuring RedundantStringConversion

Author: Vincent Potucek

.github/workflows/build.yml

@@ -172,6 +172,8 @@ jobs:
           fi
       - name: Verify license file
         run: python committer-tools/verify_license.py --skip-build
+      - name: rewriteDryRun
+        run: ./gradlew --build-cache rewriteDryRun
 
   test:
     needs: [configure, validate, load-catalog]

build.gradle

@@ -40,7 +40,14 @@ plugins {
   id "com.github.spotbugs" version '6.2.3' apply false
   id 'org.scoverage' version '8.0.3' apply false
   id 'com.gradleup.shadow' version '8.3.6' apply false
-  id 'com.diffplug.spotless' version "6.25.0"
+  id 'com.diffplug.spotless' version "8.0.0"
+  id 'org.openrewrite.rewrite' version '7.17.0' apply false
+  id 'net.ltgt.errorprone' version '4.3.0' apply false
+}
+
+apply from: rootProject.file('gradle/rewrite.gradle')
+allprojects {
+    apply from: rootProject.file('gradle/error-prone.gradle')
 }
 
 ext {
@@ -855,6 +862,7 @@ subprojects {
       targetExclude('**/generated/**/*.java','**/generated-test/**/*.java')
       importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java', 'javax', '', '\\#')
       removeUnusedImports()
+      // forbidWildcardImports()
     }
   }
 }

clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java

@@ -387,7 +387,7 @@ private boolean isSticky() {
                 if (hasCycles(topicMovementPairs)) {
                     log.error("Stickiness is violated for topic {}"
                         + "\nPartition movements for this topic occurred among the following consumer pairs:"
-                        + "\n{}", topicMovements.getKey(), topicMovements.getValue().toString());
+                        + "\n{}", topicMovements.getKey(), topicMovements.getValue());
                     return false;
                 }
             }

clients/src/main/java/org/apache/kafka/clients/producer/RecordMetadata.java

@@ -119,6 +119,6 @@ public int partition() {
 
     @Override
     public String toString() {
-        return topicPartition.toString() + "@" + offset;
+        return topicPartition + "@" + offset;
     }
 }

clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java

@@ -661,7 +661,7 @@ public MetricName metricInstance(MetricNameTemplate template, Map<String, String
 
         if (!runtimeTagKeys.equals(templateTagKeys)) {
             throw new IllegalArgumentException("For '" + template.name() + "', runtime-defined metric tags do not match the tags in the template. "
-                    + "Runtime = " + runtimeTagKeys + " Template = " + templateTagKeys.toString());
+                    + "Runtime = " + runtimeTagKeys + " Template = " + templateTagKeys);
         }
 
         return this.metricName(template.name(), template.group(), template.description(), tags);

clients/src/main/java/org/apache/kafka/common/metrics/internals/IntGaugeSuite.java

@@ -167,7 +167,7 @@ public void increment(K key) {
         synchronized (this) {
             if (closed) {
                 log.warn("{}: Attempted to increment {}, but the GaugeSuite was closed.",
-                    suiteName, key.toString());
+                    suiteName, key);
                 return;
             }
             StoredIntGauge gauge = gauges.get(key);
@@ -181,7 +181,7 @@ public void increment(K key) {
             if (gauges.size() == maxEntries) {
                 if (removable.isEmpty()) {
                     log.debug("{}: Attempted to increment {}, but there are already {} entries.",
-                        suiteName, key.toString(), maxEntries);
+                        suiteName, key, maxEntries);
                     return;
                 }
                 Iterator<K> iter = removable.iterator();
@@ -191,13 +191,13 @@ public void increment(K key) {
                 gauges.remove(keyToRemove);
                 pending.push(new PendingMetricsChange(metricNameToRemove, null));
                 log.trace("{}: Removing the metric {}, which has a value of 0.",
-                    suiteName, keyToRemove.toString());
+                    suiteName, keyToRemove);
             }
             MetricName metricNameToAdd = metricNameCalculator.apply(key);
             gauge = new StoredIntGauge(metricNameToAdd);
             gauges.put(key, gauge);
             pending.push(new PendingMetricsChange(metricNameToAdd, gauge));
-            log.trace("{}: Adding a new metric {}.", suiteName, key.toString());
+            log.trace("{}: Adding a new metric {}.", suiteName, key);
         }
         // Drop the object monitor and perform any pending metrics additions or removals.
         performPendingMetricsOperations();
@@ -236,17 +236,17 @@ private void performPendingMetricsOperations() {
     public synchronized void decrement(K key) {
         if (closed) {
             log.warn("{}: Attempted to decrement {}, but the gauge suite was closed.",
-                suiteName, key.toString());
+                suiteName, key);
             return;
         }
         StoredIntGauge gauge = gauges.get(key);
         if (gauge == null) {
             log.debug("{}: Attempted to decrement {}, but no such metric was registered.",
-                suiteName, key.toString());
+                suiteName, key);
         } else {
             int cur = gauge.decrement();
             log.trace("{}: Removed a reference to {}.  {} reference(s) remaining.",
-                suiteName, key.toString(), cur);
+                suiteName, key, cur);
             if (cur <= 0) {
                 removable.add(key);
             }

clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java

@@ -57,7 +57,7 @@ public static String deepToString(Iterator<?> iter) {
         while (iter.hasNext()) {
             Object object = iter.next();
             bld.append(prefix);
-            bld.append(object.toString());
+            bld.append(object);
             prefix = ", ";
         }
         bld.append("]");

clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java

@@ -181,7 +181,7 @@ public String toString() {
         StringBuilder b = new StringBuilder();
         b.append('{');
         for (int i = 0; i < this.fields.length; i++) {
-            b.append(this.fields[i].toString());
+            b.append(this.fields[i]);
             if (i < this.fields.length - 1)
                 b.append(',');
         }

clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java

@@ -138,7 +138,7 @@ public String toString() {
         for (Map.Entry<Integer, Field> field : fields.entrySet()) {
             bld.append(prefix);
             prefix = ", ";
-            bld.append(field.getKey()).append(" -> ").append(field.getValue().toString());
+            bld.append(field.getKey()).append(" -> ").append(field.getValue());
         }
         bld.append(")");
         return bld.toString();

clients/src/main/java/org/apache/kafka/common/security/plain/internals/PlainSaslServer.java

@@ -182,7 +182,7 @@ public SaslServer createSaslServer(String mechanism, String protocol, String ser
             throws SaslException {
 
             if (!PLAIN_MECHANISM.equals(mechanism))
-                throw new SaslException(String.format("Mechanism \'%s\' is not supported. Only PLAIN is supported.", mechanism));
+                throw new SaslException(String.format("Mechanism '%s' is not supported. Only PLAIN is supported.", mechanism));
 
             return new PlainSaslServer(cbh);
         }