Add error-prone.picnic.tech featuring RedundantStringConversion

Author: Vincent Potucek

build.gradle

@@ -41,6 +41,11 @@ plugins {
   id 'org.scoverage' version '8.0.3' apply false
   id 'com.gradleup.shadow' version '8.3.9' apply false
   id 'com.diffplug.spotless' version "7.2.1"
+  id 'net.ltgt.errorprone' version '4.3.0' apply false
+}
+
+allprojects {
+    apply from: rootProject.file('gradle/error-prone.gradle')
 }
 
 ext {
@@ -76,7 +81,7 @@ ext {
     // until version can be upgraded: https://github.com/spotbugs/spotbugs/issues/3564
     project.gradle.startParameter.excludedTaskNames.add("spotbugsMain")
     project.gradle.startParameter.excludedTaskNames.add("spotbugsTest")
-  }    
+  }
 
   maxTestForks = project.hasProperty('maxParallelForks') ? maxParallelForks.toInteger() : Runtime.runtime.availableProcessors()
   maxScalacThreads = project.hasProperty('maxScalacThreads') ? maxScalacThreads.toInteger() :

clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java

@@ -387,7 +387,7 @@ private boolean isSticky() {
                 if (hasCycles(topicMovementPairs)) {
                     log.error("Stickiness is violated for topic {}"
                         + "\nPartition movements for this topic occurred among the following consumer pairs:"
-                        + "\n{}", topicMovements.getKey(), topicMovements.getValue().toString());
+                        + "\n{}", topicMovements.getKey(), topicMovements.getValue());
                     return false;
                 }
             }

clients/src/main/java/org/apache/kafka/clients/producer/RecordMetadata.java

@@ -119,6 +119,6 @@ public int partition() {
 
     @Override
     public String toString() {
-        return topicPartition.toString() + "@" + offset;
+        return topicPartition + "@" + offset;
     }
 }

clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java

@@ -661,7 +661,7 @@ public MetricName metricInstance(MetricNameTemplate template, Map<String, String
 
         if (!runtimeTagKeys.equals(templateTagKeys)) {
             throw new IllegalArgumentException("For '" + template.name() + "', runtime-defined metric tags do not match the tags in the template. "
-                    + "Runtime = " + runtimeTagKeys + " Template = " + templateTagKeys.toString());
+                    + "Runtime = " + runtimeTagKeys + " Template = " + templateTagKeys);
         }
 
         return this.metricName(template.name(), template.group(), template.description(), tags);

clients/src/main/java/org/apache/kafka/common/metrics/internals/IntGaugeSuite.java

@@ -167,7 +167,7 @@ public void increment(K key) {
         synchronized (this) {
             if (closed) {
                 log.warn("{}: Attempted to increment {}, but the GaugeSuite was closed.",
-                    suiteName, key.toString());
+                    suiteName, key);
                 return;
             }
             StoredIntGauge gauge = gauges.get(key);
@@ -181,7 +181,7 @@ public void increment(K key) {
             if (gauges.size() == maxEntries) {
                 if (removable.isEmpty()) {
                     log.debug("{}: Attempted to increment {}, but there are already {} entries.",
-                        suiteName, key.toString(), maxEntries);
+                        suiteName, key, maxEntries);
                     return;
                 }
                 Iterator<K> iter = removable.iterator();
@@ -191,13 +191,13 @@ public void increment(K key) {
                 gauges.remove(keyToRemove);
                 pending.push(new PendingMetricsChange(metricNameToRemove, null));
                 log.trace("{}: Removing the metric {}, which has a value of 0.",
-                    suiteName, keyToRemove.toString());
+                    suiteName, keyToRemove);
             }
             MetricName metricNameToAdd = metricNameCalculator.apply(key);
             gauge = new StoredIntGauge(metricNameToAdd);
             gauges.put(key, gauge);
             pending.push(new PendingMetricsChange(metricNameToAdd, gauge));
-            log.trace("{}: Adding a new metric {}.", suiteName, key.toString());
+            log.trace("{}: Adding a new metric {}.", suiteName, key);
         }
         // Drop the object monitor and perform any pending metrics additions or removals.
         performPendingMetricsOperations();
@@ -236,17 +236,17 @@ private void performPendingMetricsOperations() {
     public synchronized void decrement(K key) {
         if (closed) {
             log.warn("{}: Attempted to decrement {}, but the gauge suite was closed.",
-                suiteName, key.toString());
+                suiteName, key);
             return;
         }
         StoredIntGauge gauge = gauges.get(key);
         if (gauge == null) {
             log.debug("{}: Attempted to decrement {}, but no such metric was registered.",
-                suiteName, key.toString());
+                suiteName, key);
         } else {
             int cur = gauge.decrement();
             log.trace("{}: Removed a reference to {}.  {} reference(s) remaining.",
-                suiteName, key.toString(), cur);
+                suiteName, key, cur);
             if (cur <= 0) {
                 removable.add(key);
             }

clients/src/main/java/org/apache/kafka/common/protocol/MessageUtil.java

@@ -57,7 +57,7 @@ public static String deepToString(Iterator<?> iter) {
         while (iter.hasNext()) {
             Object object = iter.next();
             bld.append(prefix);
-            bld.append(object.toString());
+            bld.append(object);
             prefix = ", ";
         }
         bld.append("]");

clients/src/main/java/org/apache/kafka/common/protocol/types/Schema.java

@@ -181,7 +181,7 @@ public String toString() {
         StringBuilder b = new StringBuilder();
         b.append('{');
         for (int i = 0; i < this.fields.length; i++) {
-            b.append(this.fields[i].toString());
+            b.append(this.fields[i]);
             if (i < this.fields.length - 1)
                 b.append(',');
         }

clients/src/main/java/org/apache/kafka/common/protocol/types/TaggedFields.java

@@ -138,7 +138,7 @@ public String toString() {
         for (Map.Entry<Integer, Field> field : fields.entrySet()) {
             bld.append(prefix);
             prefix = ", ";
-            bld.append(field.getKey()).append(" -> ").append(field.getValue().toString());
+            bld.append(field.getKey()).append(" -> ").append(field.getValue());
         }
         bld.append(")");
         return bld.toString();

clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java

@@ -892,7 +892,7 @@ private KafkaMetric getMetric(String name, Map<String, String> tags) throws Exce
                 entry.getKey().name().equals(name) && entry.getKey().tags().equals(tags))
             .findFirst();
         if (metric.isEmpty())
-            throw new Exception(String.format("Could not find metric called %s with tags %s", name, tags.toString()));
+            throw new Exception(String.format("Could not find metric called %s with tags %s", name, tags));
 
         return metric.get().getValue();
     }

connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java

@@ -226,12 +226,12 @@ public void awaitStop() {
 
     private void checkHerder(SourceAndTarget sourceAndTarget) {
         if (!herders.containsKey(sourceAndTarget)) {
-            throw new IllegalArgumentException("No herder for " + sourceAndTarget.toString());
+            throw new IllegalArgumentException("No herder for " + sourceAndTarget);
         }
     }
 
     private void addHerder(SourceAndTarget sourceAndTarget) {
-        log.info("creating herder for {}", sourceAndTarget.toString());
+        log.info("creating herder for {}", sourceAndTarget);
         Map<String, String> workerProps = config.workerConfig(sourceAndTarget);
         DistributedConfig distributedConfig = new DistributedConfig(workerProps);
         String encodedSource = encodePath(sourceAndTarget.source());
@@ -289,13 +289,13 @@ private static String encodePath(String rawPath) {
 
     private String generateWorkerId(SourceAndTarget sourceAndTarget) {
         if (config.enableInternalRest()) {
-            return advertisedUrl.getHost() + ":" + advertisedUrl.getPort() + "/" + sourceAndTarget.toString();
+            return advertisedUrl.getHost() + ":" + advertisedUrl.getPort() + "/" + sourceAndTarget;
         }
         try {
             //UUID to make sure it is unique even if multiple workers running on the same host
-            return InetAddress.getLocalHost().getCanonicalHostName() + "/" + sourceAndTarget.toString() + "/" + UUID.randomUUID();
+            return InetAddress.getLocalHost().getCanonicalHostName() + "/" + sourceAndTarget + "/" + UUID.randomUUID();
         } catch (UnknownHostException e) {
-            return sourceAndTarget.toString() + "/" + UUID.randomUUID();
+            return sourceAndTarget + "/" + UUID.randomUUID();
         }
     }