KAFKA-19984 Throttle-related dynamic configurations should not have the isReadOnly flag
#21131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
# Conflicts: # core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
m1a2st
changed the title
isReadOnly flag [WIP]isReadOnly flag
Collaborator
|
Could you please resolve the conflicts? |
DL1231
reviewed
Dec 19, 2025
Collaborator
DL1231
left a comment
DL1231
left a comment
There was a problem hiding this comment.
Overall LGTM, a small comment left.
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java
Outdated
Show resolved
Hide resolved
Member
|
@m1a2st please fix the conflicts |
# Conflicts: # core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
Member
|
@m1a2st please fix the conflicts 😢 |
# Conflicts: # server/src/test/java/org/apache/kafka/server/BootstrapControllersIntegrationTest.java
chia7712
reviewed
Jan 14, 2026
| } | ||
|
|
||
| public static Set<String> brokerQuotaConfigsNames() { | ||
| return Set.of( |
Member
There was a problem hiding this comment.
How about using brokerQuotaConfigs?
public static Set<String> brokerQuotaConfigsNames() {
return Set.copyOf(brokerQuotaConfigs().names());
}
Collaborator
Author
There was a problem hiding this comment.
Thanks, addressed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following configs are weird because those values are definitely not
READONLY
Add them into the
DynamicBrokerConfigto ensure when we query it's notREADONLY