Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Networking HAVE_PFINET_SOCKETS always undefined #14777

Closed
1 task done
liamHowatt opened this issue Nov 14, 2024 · 4 comments · Fixed by #14886
Closed
1 task done

[BUG] Networking HAVE_PFINET_SOCKETS always undefined #14777

liamHowatt opened this issue Nov 14, 2024 · 4 comments · Fixed by #14886
Labels
Arch: x86_64 Issues related to the x86_64 architecture Area: Networking Effects networking subsystem OS: Linux Issues related to Linux (building system, etc) Type: Bug Something isn't working

Comments

@liamHowatt
Copy link
Contributor

liamHowatt commented Nov 14, 2024

Description / Steps to reproduce the issue

Defconfig sim:userfs

nsh> userfs
ERROR: userfs_run() returned: -97

Address family not supported by protocol error from net_sockif of net_sockif.c due to HAVE_PFINET_SOCKETS being wrongly undefined. The necessary NET_UDP_HAVE_STACK and NET_TCP_HAVE_STACK are not being included by netconfig.h. NET_UDP_HAVE_STACK and NET_TCP_HAVE_STACK are defined in nuttx/net/udp/udp.h and nuttx/net/tcp/tcp.h.

A chain of partial fixes to very similar issues ended with this PR #14650

On which OS does this issue occur?

[OS: Linux]

What is the version of your OS?

Ubuntu 20.04

NuttX Version

master

Issue Architecture

[Arch: x86_64]

Issue Area

[Area: Networking]

Verification

  • I have verified before submitting the report.
@liamHowatt liamHowatt added the Type: Bug Something isn't working label Nov 14, 2024
@github-actions github-actions bot added Arch: x86_64 Issues related to the x86_64 architecture Area: Networking Effects networking subsystem OS: Linux Issues related to Linux (building system, etc) labels Nov 14, 2024
@xiaoxiang781216
Copy link
Contributor

@PetervdPerk-NXP could you look at this issue?

@wengzhe
Copy link
Contributor

wengzhe commented Nov 21, 2024

Hi @liamHowatt , we've also encountered this bug and tried to post a fix, would you like to have a try? #14886

@xiaoxiang781216 xiaoxiang781216 linked a pull request Nov 21, 2024 that will close this issue
@liamHowatt
Copy link
Contributor Author

Thanks for addressing it @wengzhe 🙏 I will take a look in ~20 hours and reply in your PR.

@liamHowatt
Copy link
Contributor Author

Glad to see it was merged. Working again in master. Thank you. The solution makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: x86_64 Issues related to the x86_64 architecture Area: Networking Effects networking subsystem OS: Linux Issues related to Linux (building system, etc) Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants