Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/doreleasenotes #13582

Merged
merged 1 commit into from
Sep 24, 2024
Merged

tools/doreleasenotes #13582

merged 1 commit into from
Sep 24, 2024

Conversation

jerpelea
Copy link
Contributor

Summary

Simple tool to generate the NuttX release notes

tested on Python-3.8.9

Requirements
pip install PyGithub
pip install PyInquirer
pip install tqdm

The following arguments are required for generating a release: release_version, gh_token

Inspired by https://github.com/btashton/nxutils

Impact

release notes

Testing

generated notes for last 3 releases

@jerpelea jerpelea requested a review from btashton September 23, 2024 11:57
@github-actions github-actions bot added Area: Tooling Size: M The size of the change in this PR is medium labels Sep 23, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 23, 2024

[Experimental Bot, please feedback here]

While this summary provides a high-level overview, it lacks the specificity required by the NuttX PR requirements. Here's a breakdown of what's missing and how to improve it:

Summary:

  • Why is this change necessary? Instead of just stating it's a tool, explain the problem it solves. Is the current release note generation process manual, error-prone, or time-consuming? Does it lack specific features this tool provides?
  • What functional part of the code is being changed? Since this seems like a new tool, mention where it lives within the repository (a new directory/script?).
  • How does the change exactly work? Provide a brief description of the tool's workflow. Does it scrape data from somewhere? What inputs does it take? What format are the release notes generated in?

Impact:

  • Is new feature added? Yes, explicitly state this is a new tool.
  • Impact on the user? Who are the intended users of this tool (developers, maintainers)? How will it change their workflow? Will it be part of the standard release process?
  • Impact on build? Does this tool need to be integrated into the build system or CI/CD?
  • Impact on documentation? This tool likely needs its own documentation explaining how to use it. Mention if you've added this.

Testing:

  • Be specific about your testing environment: Instead of just "Python-3.8.9," specify the OS as well.
  • Provide more details on the target releases: Which releases did you generate notes for? Were there any issues?
  • Instead of full logs, summarize your findings: Did the generated release notes match expectations? Did the tool encounter any errors?

Additional Considerations:

  • Code Style: Ensure the code adheres to NuttX's coding style guidelines.
  • Error Handling: Implement robust error handling in the tool.
  • User Input Validation: If the tool takes user input, validate it to prevent unexpected behavior.

In short, your PR summary needs to be more comprehensive and address all the points outlined in the NuttX requirements.

@xiaoxiang781216
Copy link
Contributor

please.fix.lint.error

@jerpelea jerpelea force-pushed the releasenotes branch 2 times, most recently from a69f5ac to cdd4e61 Compare September 24, 2024 14:23
Simple tool to generate the NuttX release notes

tested on Python-3.8.9

Requirements
pip install PyGithub
pip install PyInquirer
pip install tqdm

The following arguments are required for generating a release: release_version, gh_token

Inspired by https://github.com/btashton/nxutils

Signed-off-by: Alin Jerpelea <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit 9fa35a7 into apache:master Sep 24, 2024
29 checks passed
@jerpelea jerpelea deleted the releasenotes branch September 25, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tooling Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants