Rpmsg virtio: update rpmsg virtio and add sim config to verify rpmsg virtio #14077

CV-Bowen · 2024-10-11T04:35:20Z

Summary

sim:rpserver_virtio and rpproxy_virtio: add rpmsg_virtio config for sim

add rpserver_virtio and rproxy_virtio to verify the rpmsg virtio transport

rpmsg_virtio: move notify_wait_cb to struct rpmsg_virtio_device

notify_wait_cb has been moved to struct rpmsg_virtio_device, so
change rpmsg_virtio.c transport too.

rpmsg/virtio: fix compile issue, feature uint32_t to uint64_t

Has change the virtio feature bit to 64bit, so rpmsg virtio need
change to 64bit too.

rpmsg/rpmsg_virtio.h: include <openamp/remoteproc.h> to fix compile error

/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:176:28: error: field ‘rsc_tbl_hdr’ has incomplete type
  176 |   struct resource_table    rsc_tbl_hdr;
      |                            ^~~~~~~~~~~
/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:178:28: error: field ‘log_trace’ has incomplete type
  178 |   struct fw_rsc_trace      log_trace;
      |                            ^~~~~~~~~
/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:179:28: error: field ‘rpmsg_vdev’ has incomplete type
  179 |   struct fw_rsc_vdev       rpmsg_vdev;
      |                            ^~~~~~~~~~
/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:180:28: error: field ‘rpmsg_vring0’ has incomplete type
  180 |   struct fw_rsc_vdev_vring rpmsg_vring0;
      |                            ^~~~~~~~~~~~
/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:181:28: error: field ‘rpmsg_vring1’ has incomplete type
  181 |   struct fw_rsc_vdev_vring rpmsg_vring1;
      |                            ^~~~~~~~~~~~
/data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:182:28: error: field ‘config’ has incomplete type
  182 |   struct fw_rsc_config     config;

fix the MacOS warning

CC:  clk/clk_fixed_rate.c clk/clk_divider.c:177:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(rate - now) < abs(rate - best);
             ^
clk/clk_divider.c:177:14: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(rate - now) < abs(rate - best);
             ^~~
clk/clk_divider.c:177:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(rate - now) < abs(rate - best);
                               ^
clk/clk_divider.c:177:32: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(rate - now) < abs(rate - best);
                               ^~~
CC:  mm_heap/mm_initialize.c 2 warnings generated.
clk/clk.c:1324:11: warning: variable 'irqflags' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
      if (clk->parents == NULL)
          ^~~~~~~~~~~~~~~~~~~~
clk/clk.c:1341:19: note: uninitialized use occurs here
  clk_list_unlock(irqflags);
                  ^~~~~~~~
clk/clk.c:1324:7: note: remove the 'if' if its condition is always false
      if (clk->parents == NULL)
      ^~~~~~~~~~~~~~~~~~~~~~~~~
clk/clk.c:1255:22: note: initialize the variable 'irqflags' to silence this warning
  irqstate_t irqflags;
                     ^
                      = 0
CC:  clk/clk_mux.c clk/clk_multiplier.c:110:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(rate - new) < abs(rate - best);
             ^
clk/clk_multiplier.c:110:14: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(rate - new) < abs(rate - best);
             ^~~
clk/clk_multiplier.c:110:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(rate - new) < abs(rate - best);
                               ^
clk/clk_multiplier.c:110:32: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(rate - new) < abs(rate - best);
                               ^~~
clk/clk_mux.c:47:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(now - rate) < abs(best - rate);
             ^
clk/clk_mux.c:47:14: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(now - rate) < abs(best - rate);
             ^~~
clk/clk_mux.c:47:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
      return abs(now - rate) < abs(best - rate);
                               ^
clk/clk_mux.c:47:32: note: remove the call to 'abs' since unsigned values cannot be negative
      return abs(now - rate) < abs(best - rate);
                               ^~~
AS:  sim/sim_fork_x86.S 2 warnings generated.
1 warning2 warnings generated.
 generated.
iperf.c:325:14: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'unsigned long' [-Wformat]
             now_len -last_len,
             ^~~~~~~~~~~~~~~~~
iperf.c:340:14: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat]
             now_len,
             ^~~~~~~
CC:  misc/rpmsgblk_server.c 2 warnings generated.
:28: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat]
                           (uintmax_t)skip);
                           ^~~~~~~~~~~~~~~
nsh_dbgcmds.c:473:20: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat]
                   (uintmax_t)position);
                   ^~~~~~~~~~~~~~~~~~~
CC:  nsh_main.c 2 warnings generated.

              return INTMAX_MIN;
              ~~~~~~ ^~~~~~~~~~
CC:  nsh_system.c  note: expanded from macro 'INTMAX_MIN'
                            ^~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN'
                             ~~~~~~~~~~~^~~
inttypes/lib_strtoimax.c:103:37: warning: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from -9223372036854775808 to 0 [-Wconstant-conversion]
          return (accum == limit) ? INTMAX_MIN : -(intmax_t)accum;
          ~~~~~~                    ^~~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:136:29: note: expanded from macro 'INTMAX_MIN'
                            ^~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN'
                             ~~~~~~~~~~~^~~
inttypes/lib_strtoimax.c:106:17: warning: result of comparison of constant 9223372036854775807 with expression of type 'uintmax_t' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare]
      if (accum > INTMAX_MAX)
          ~~~~~ ^ ~~~~~~~~~~
inttypes/lib_strtoimax.c:109:18: warning: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from 9223372036854775807 to -1 [-Wconstant-conversion]
          return INTMAX_MAX;
          ~~~~~~ ^~~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:137:29: note: expanded from macro 'INTMAX_MAX'
                            ^~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:66:29: note: expanded from macro 'INT64_MAX'
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/vela/work/nuttx/include/arch/inttypes.h:35:23: note: expanded from macro 'INT64_C'
                      ^~~~~~~
<scratch space>:12:1: note: expanded from here
9223372036854775807ll
^~~~~~~~~~~~~~~~~~~~~
syslog/vsyslog.c:212:32: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat]
                             , (uintmax_t)ts.tv_sec
                               ^~~~~~~~~~~~~~~~~~~~
CC:  iob/iob_free.c 4 warnings generated.
1 warning generated.
CC:  mqueue/mq_msgqalloc.c inttypes/lib_strtoumax.c:91:23: warning: implicit conversion from 'unsigned long long' to 'uintmax_t' (aka 'unsigned long') changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion]
              accum = UINTMAX_MAX;
                    ~ ^~~~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:140:29: note: expanded from macro 'UINTMAX_MAX'
                            ^~~~~~~~~~
/Users/vela/work/nuttx/include/stdint.h:67:29: note: expanded from macro 'UINT64_MAX'
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/vela/work/nuttx/include/arch/inttypes.h:36:23: note: expanded from macro 'UINT64_C'
                      ^~~~~~~~
<scratch space>:8:1: note: expanded from here
18446744073709551615ull
^~~~~~~~~~~~~~~~~~~~~~~
CC:  icmp/icmp_ioctl.c 1 warning generated.
time/lib_strftime.c:584:52: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat]
               len = snprintf(dest, chleft, "%ju", (uintmax_t)mktime(&tmp));
                                             ~~~   ^~~~~~~~~~~~~~~~~~~~~~~
                                             %ju

Impact

rpmsg_virtio

Testing

sim rpserver_virtio and rpproxy_virtio

nuttxpr · 2024-10-11T04:47:29Z

[Experimental Bot, please feedback here]

NuttX PR Requirements Review

The provided summary partially meets the NuttX PR requirements. Here's a breakdown:

Strengths:

Summary: Each bullet point outlines a specific change, providing context on its purpose (fix, update, new feature).
Testing: Indicates the testing environment (sim) and the specific applications used for verification (rpserver_virtio, rpproxy_virtio).

Areas for Improvement:

Summary:
- The summary would benefit from a brief, overarching description of the changes rather than just a list of bullet points.
- More details about how the changes work are needed. For instance:
  - How is the rpmsg_virtio config used in the new sim applications?
  - What was the compile issue related to uint32_t and uint64_t?
- Related NuttX issues are missing. If this PR addresses specific issues, please link them.
Impact:
- The "Impact" section is incomplete. Provide specific answers (YES/NO) and explanations for all impact categories.
- For example:
  - Impact on user: Does this change introduce new APIs or configurations that users need to be aware of?
  - Impact on build: Are there any changes to Kconfig options, build dependencies, or the build process itself?
  - Impact on hardware: Does this impact specific architectures, boards, or drivers beyond the simulator?
  - Impact on documentation: Does this PR require documentation updates? If so, have those updates been included?
  - Security, Compatibility: Address these sections as well, even if the answer is "NO."
Testing:
- Include details about your build host environment (OS, CPU, compiler).
- While mentioning "Testing logs before change" and "Testing logs after change" is good, providing snippets of the actual logs would be more helpful for reviewers.

Recommendation:

Expand the summary, complete the "Impact" section with specific YES/NO answers and explanations, and enhance the "Testing" section with details about the build host and relevant testing logs.

CV-Bowen · 2024-10-11T06:00:51Z

Wait the rpmsg command fix PR merged: apache/nuttx-apps#2677

CV-Bowen · 2024-10-15T05:47:48Z

Rebased to fix the CI problem.

CV-Bowen · 2024-10-16T09:35:23Z

Just rebase to fix the CI problem.

CV-Bowen · 2024-10-16T11:56:26Z

CI Failed, but unrelated to this PR

100  496k  100  496k    0     0  1123k      0 --:--:-- --:--:-- --:--:-- 1123k
Error: syslog/vsyslog.c:212:32: error: format specifies type 'intmax_t' (aka 'long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Werror,-Wformat]
                             , (uintmax_t)ts.tv_sec
                               ^~~~~~~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [vsyslog.o] Error 1
make[1]: Target `libdrivers.a' not remade because of errors.
make: *** [drivers/libdrivers.a] Error 2
Error: inttypes/lib_strtoimax.c:100:22: error: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from -9223372036854775808 to 0 [-Werror,-Wconstant-conversion]
              return INTMAX_MIN;
              ~~~~~~ ^~~~~~~~~~
/Users/runner/work/nuttx/nuttx/sources/nuttx/include/stdint.h:136:29: note: expanded from macro 'INTMAX_MIN'
#  define INTMAX_MIN        INT64_MIN
                            ^~~~~~~~~
/Users/runner/work/nuttx/nuttx/sources/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN'
#  define INT64_MIN         (-INT64_MAX - 1)
                             ~~~~~~~~~~~^~~
Error: inttypes/lib_strtoimax.c:103:37: error: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from -9223372036854775808 to 0 [-Werror,-Wconstant-conversion]
          return (accum == limit) ? INTMAX_MIN : -(intmax_t)accum;
          ~~~~~~                    ^~~~~~~~~~
/Users/runner/work/nuttx/nuttx/sources/nuttx/include/stdint.h:136:29: note: expanded from macro 'INTMAX_MIN'
#  define INTMAX_MIN        INT64_MIN
                            ^~~~~~~~~
/Users/runner/work/nuttx/nuttx/sources/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN'
#  define INT64_MIN         (-INT64_MAX - 1)
                             ~~~~~~~~~~~^~~
Error: inttypes/lib_strtoimax.c:106:17: error: result of comparison of constant 9223372036854775807 with expression of type 'uintmax_t' (aka 'unsigned long') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
      if (accum > INTMAX_MAX)

CV-Bowen · 2024-10-16T11:58:48Z

Rebased to fix the CI problem.

CV-Bowen · 2024-10-16T14:50:36Z

Local compile pass, just rebase to fix the CI problem.

CV-Bowen · 2024-10-17T09:11:03Z

Updated to fix the MacOS warning, Please see the commit: fix the sim compile warning in MacOS

xiaoxiang781216 · 2024-10-17T15:23:06Z

Updated to fix the MacOS warning, Please see the commit: fix the sim compile warning in MacOS

but the same warning still exist

…rror /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:176:28: error: field ‘rsc_tbl_hdr’ has incomplete type 176 | struct resource_table rsc_tbl_hdr; | ^~~~~~~~~~~ /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:178:28: error: field ‘log_trace’ has incomplete type 178 | struct fw_rsc_trace log_trace; | ^~~~~~~~~ /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:179:28: error: field ‘rpmsg_vdev’ has incomplete type 179 | struct fw_rsc_vdev rpmsg_vdev; | ^~~~~~~~~~ /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:180:28: error: field ‘rpmsg_vring0’ has incomplete type 180 | struct fw_rsc_vdev_vring rpmsg_vring0; | ^~~~~~~~~~~~ /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:181:28: error: field ‘rpmsg_vring1’ has incomplete type 181 | struct fw_rsc_vdev_vring rpmsg_vring1; | ^~~~~~~~~~~~ /data/project/code/apache/nuttx/include/nuttx/rpmsg/rpmsg_virtio.h:182:28: error: field ‘config’ has incomplete type 182 | struct fw_rsc_config config; Signed-off-by: Bowen Wang <[email protected]>

Has change the virtio feature bit to 64bit, so rpmsg virtio need change to 64bit too. Signed-off-by: buxiasen <[email protected]>

notify_wait_cb has been moved to struct rpmsg_virtio_device, so change rpmsg_virtio.c transport too. Signed-off-by: Bowen Wang <[email protected]>

add rpserver_virtio and rproxy_virtio to verify the rpmsg virtio transport Signed-off-by: Bowen Wang <[email protected]>

include/wanring-mac

CC: clk/clk_fixed_rate.c clk/clk_divider.c:177:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(rate - now) < abs(rate - best); ^ clk/clk_divider.c:177:14: note: remove the call to 'abs' since unsigned values cannot be negative return abs(rate - now) < abs(rate - best); ^~~ clk/clk_divider.c:177:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(rate - now) < abs(rate - best); ^ clk/clk_divider.c:177:32: note: remove the call to 'abs' since unsigned values cannot be negative return abs(rate - now) < abs(rate - best); ^~~ CC: mm_heap/mm_initialize.c 2 warnings generated. clk/clk.c:1324:11: warning: variable 'irqflags' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (clk->parents == NULL) ^~~~~~~~~~~~~~~~~~~~ clk/clk.c:1341:19: note: uninitialized use occurs here clk_list_unlock(irqflags); ^~~~~~~~ clk/clk.c:1324:7: note: remove the 'if' if its condition is always false if (clk->parents == NULL) ^~~~~~~~~~~~~~~~~~~~~~~~~ clk/clk.c:1255:22: note: initialize the variable 'irqflags' to silence this warning irqstate_t irqflags; ^ = 0 CC: clk/clk_mux.c clk/clk_multiplier.c:110:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(rate - new) < abs(rate - best); ^ clk/clk_multiplier.c:110:14: note: remove the call to 'abs' since unsigned values cannot be negative return abs(rate - new) < abs(rate - best); ^~~ clk/clk_multiplier.c:110:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(rate - new) < abs(rate - best); ^ clk/clk_multiplier.c:110:32: note: remove the call to 'abs' since unsigned values cannot be negative return abs(rate - new) < abs(rate - best); ^~~ clk/clk_mux.c:47:14: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(now - rate) < abs(best - rate); ^ clk/clk_mux.c:47:14: note: remove the call to 'abs' since unsigned values cannot be negative return abs(now - rate) < abs(best - rate); ^~~ clk/clk_mux.c:47:32: warning: taking the absolute value of unsigned type 'unsigned int' has no effect [-Wabsolute-value] return abs(now - rate) < abs(best - rate); ^ clk/clk_mux.c:47:32: note: remove the call to 'abs' since unsigned values cannot be negative return abs(now - rate) < abs(best - rate); ^~~ AS: sim/sim_fork_x86.S 2 warnings generated. 1 warning2 warnings generated. generated. iperf.c:325:14: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'unsigned long' [-Wformat] now_len -last_len, ^~~~~~~~~~~~~~~~~ iperf.c:340:14: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat] now_len, ^~~~~~~ CC: misc/rpmsgblk_server.c 2 warnings generated. :28: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat] (uintmax_t)skip); ^~~~~~~~~~~~~~~ nsh_dbgcmds.c:473:20: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat] (uintmax_t)position); ^~~~~~~~~~~~~~~~~~~ CC: nsh_main.c 2 warnings generated. return INTMAX_MIN; ~~~~~~ ^~~~~~~~~~ CC: nsh_system.c note: expanded from macro 'INTMAX_MIN' ^~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN' ~~~~~~~~~~~^~~ inttypes/lib_strtoimax.c:103:37: warning: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from -9223372036854775808 to 0 [-Wconstant-conversion] return (accum == limit) ? INTMAX_MIN : -(intmax_t)accum; ~~~~~~ ^~~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:136:29: note: expanded from macro 'INTMAX_MIN' ^~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:65:41: note: expanded from macro 'INT64_MIN' ~~~~~~~~~~~^~~ inttypes/lib_strtoimax.c:106:17: warning: result of comparison of constant 9223372036854775807 with expression of type 'uintmax_t' (aka 'unsigned long') is always false [-Wtautological-constant-out-of-range-compare] if (accum > INTMAX_MAX) ~~~~~ ^ ~~~~~~~~~~ inttypes/lib_strtoimax.c:109:18: warning: implicit conversion from 'long long' to 'intmax_t' (aka 'long') changes value from 9223372036854775807 to -1 [-Wconstant-conversion] return INTMAX_MAX; ~~~~~~ ^~~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:137:29: note: expanded from macro 'INTMAX_MAX' ^~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:66:29: note: expanded from macro 'INT64_MAX' ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/vela/work/nuttx/include/arch/inttypes.h:35:23: note: expanded from macro 'INT64_C' ^~~~~~~ <scratch space>:12:1: note: expanded from here 9223372036854775807ll ^~~~~~~~~~~~~~~~~~~~~ syslog/vsyslog.c:212:32: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat] , (uintmax_t)ts.tv_sec ^~~~~~~~~~~~~~~~~~~~ CC: iob/iob_free.c 4 warnings generated. 1 warning generated. CC: mqueue/mq_msgqalloc.c inttypes/lib_strtoumax.c:91:23: warning: implicit conversion from 'unsigned long long' to 'uintmax_t' (aka 'unsigned long') changes value from 18446744073709551615 to 4294967295 [-Wconstant-conversion] accum = UINTMAX_MAX; ~ ^~~~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:140:29: note: expanded from macro 'UINTMAX_MAX' ^~~~~~~~~~ /Users/vela/work/nuttx/include/stdint.h:67:29: note: expanded from macro 'UINT64_MAX' ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /Users/vela/work/nuttx/include/arch/inttypes.h:36:23: note: expanded from macro 'UINT64_C' ^~~~~~~~ <scratch space>:8:1: note: expanded from here 18446744073709551615ull ^~~~~~~~~~~~~~~~~~~~~~~ CC: icmp/icmp_ioctl.c 1 warning generated. time/lib_strftime.c:584:52: warning: format specifies type 'uintmax_t' (aka 'unsigned long long') but the argument has type 'uintmax_t' (aka 'unsigned long') [-Wformat] len = snprintf(dest, chleft, "%ju", (uintmax_t)mktime(&tmp)); ~~~ ^~~~~~~~~~~~~~~~~~~~~~~ %ju Signed-off-by: Bowen Wang <[email protected]>

github-actions bot added Board: simulator Size: M The size of the change in this PR is medium labels Oct 11, 2024

xiaoxiang781216 approved these changes Oct 11, 2024

View reviewed changes

CV-Bowen force-pushed the rpmsg-virtio branch 2 times, most recently from 0f6c306 to 2a18181 Compare October 15, 2024 05:47

CV-Bowen force-pushed the rpmsg-virtio branch 3 times, most recently from 2da76ed to 010ad92 Compare October 16, 2024 09:34

CV-Bowen force-pushed the rpmsg-virtio branch from 010ad92 to 1382de0 Compare October 16, 2024 11:58

CV-Bowen force-pushed the rpmsg-virtio branch from 1382de0 to 2d1c3ae Compare October 16, 2024 14:45

xiaoxiang781216 approved these changes Oct 16, 2024

View reviewed changes

CV-Bowen force-pushed the rpmsg-virtio branch from 2d1c3ae to f0472d9 Compare October 17, 2024 09:08

github-actions bot added the Arch: simulator Issues related to the SIMulator label Oct 17, 2024

CV-Bowen and others added 4 commits October 21, 2024 21:14

rpmsg/virtio: fix compile issue, feature uint32_t to uint64_t

bbe28d3

Has change the virtio feature bit to 64bit, so rpmsg virtio need change to 64bit too. Signed-off-by: buxiasen <[email protected]>

rpmsg_virtio: move notify_wait_cb to struct rpmsg_virtio_device

189ce28

notify_wait_cb has been moved to struct rpmsg_virtio_device, so change rpmsg_virtio.c transport too. Signed-off-by: Bowen Wang <[email protected]>

sim:rpserver_virtio and rpproxy_virtio: add rpmsg_virtio config for sim

a647006

add rpserver_virtio and rproxy_virtio to verify the rpmsg virtio transport Signed-off-by: Bowen Wang <[email protected]>

CV-Bowen force-pushed the rpmsg-virtio branch from f0472d9 to 563a12a Compare October 21, 2024 13:14

github-actions bot removed the Arch: simulator Issues related to the SIMulator label Oct 21, 2024

xiaoxiang781216 reviewed Oct 21, 2024

View reviewed changes

include/wanring-mac Outdated Show resolved Hide resolved

CV-Bowen force-pushed the rpmsg-virtio branch from 563a12a to 48e5f5c Compare October 21, 2024 15:41

xiaoxiang781216 approved these changes Oct 21, 2024

View reviewed changes

xiaoxiang781216 merged commit 71fe4ac into apache:master Oct 22, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rpmsg virtio: update rpmsg virtio and add sim config to verify rpmsg virtio #14077

Rpmsg virtio: update rpmsg virtio and add sim config to verify rpmsg virtio #14077

CV-Bowen commented Oct 11, 2024 •

edited

Loading

nuttxpr commented Oct 11, 2024

CV-Bowen commented Oct 11, 2024 •

edited

Loading

CV-Bowen commented Oct 15, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 17, 2024

xiaoxiang781216 commented Oct 17, 2024

Rpmsg virtio: update rpmsg virtio and add sim config to verify rpmsg virtio #14077

Rpmsg virtio: update rpmsg virtio and add sim config to verify rpmsg virtio #14077

Conversation

CV-Bowen commented Oct 11, 2024 • edited Loading

Summary

Impact

Testing

nuttxpr commented Oct 11, 2024

NuttX PR Requirements Review

CV-Bowen commented Oct 11, 2024 • edited Loading

CV-Bowen commented Oct 15, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 16, 2024

CV-Bowen commented Oct 17, 2024

xiaoxiang781216 commented Oct 17, 2024

CV-Bowen commented Oct 11, 2024 •

edited

Loading

CV-Bowen commented Oct 11, 2024 •

edited

Loading