Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pci_ivshmem.c: ivshmem_support_irq API support #14124

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

CV-Bowen
Copy link
Contributor

Summary

ivshmem based driver can use this api to judge weather current ivshmem device support irq or not, and use polling mode or irq mode to process the event.

Impact

ivshmem based drivers

Testing

qemu armv8a and rptun-ivshmem

@github-actions github-actions bot added Area: PCI Size: S The size of the change in this PR is small labels Oct 11, 2024
@nuttxpr
Copy link

nuttxpr commented Oct 11, 2024

[Experimental Bot, please feedback here]

This PR appears incomplete based on the NuttX requirements.

Here's why:

  • Summary:

    • Lacks details about the necessity of the change. Is it a fix, update, or new feature?
    • The description of the change's functionality is vague. Be more specific about what the API does and how it determines IRQ support.
    • Missing links to related NuttX issues or pull requests.
  • Impact:

    • While it mentions "ivshmem based drivers," it doesn't explain how they are impacted. Will existing drivers need modification?
    • The impact sections (build, hardware, documentation, security, compatibility) are completely blank. Address each one with either "NO" or a "YES" followed by a clear explanation.
  • Testing:

    • While it mentions the testing environments, it lacks the actual testing logs before and after the change. This is crucial to demonstrate the PR's functionality.

To improve this PR:

  1. Expand the Summary: Clearly articulate the problem this PR solves or the feature it adds. Provide specific details about the API's functionality and link any related issues.
  2. Complete the Impact Section: Address all impact categories (build, hardware, documentation, security, compatibility) with either "NO" or a "YES" + explanation.
  3. Include Testing Logs: Paste the relevant logs from your testing both before and after implementing the changes.

ivshmem based driver can use this api to judge weather current
ivshmem device support irq or not, and use polling mode or irq
mode to process the event.

Signed-off-by: wangyongrong <[email protected]>
@xiaoxiang781216 xiaoxiang781216 merged commit ad2e6fb into apache:master Oct 12, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: PCI Size: S The size of the change in this PR is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants