[fix][broker] System topic should not be migrated during blue-green cluster migration #23767
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Dec 21, 2024
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23767 +/- ##
============================================
+ Coverage 73.57% 74.26% +0.69%
+ Complexity 32624 31740 -884
============================================
Files 1877 1838 -39
Lines 139502 143066 +3564
Branches 15299 16237 +938
============================================
+ Hits 102638 106250 +3612
+ Misses 28908 28441 -467
- Partials 7956 8375 +419
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
pushed a commit
that referenced
this pull request
Dec 21, 2024
…luster migration (#23767) Co-authored-by: ruihongzhou <[email protected]> (cherry picked from commit 1967a93)
lhotari
pushed a commit
that referenced
this pull request
Dec 21, 2024
…luster migration (#23767) Co-authored-by: ruihongzhou <[email protected]> (cherry picked from commit 1967a93)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23572
Motivation
If the topic is a system topic, then we should not migrate it during the blue-green cluster migration
Modifications
If the topic is a system topic, then we should not migrate it during the blue-green cluster migration
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: hrzzzz#14