Skip to content

[Bug] Adjust ack number condition in GroupTransferService#doWaitTransfer #9642

@mxsm

Description

@mxsm

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.

  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.

  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Windows

RocketMQ version

Master

JDK Version

jdk8

Describe the Bug

Image

The number of ackNums running to GroupTransferService must be greater than or equal to 2. This is to handle the case where there is only one slave node. If it is less than 1, the code in the if statement will never be executed.

Steps to Reproduce

req.getAckNums() == 2

What Did You Expect to See?

Run this code

What Did You See Instead?

Image This code is invalid and will not run.

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions